thr3ads.net - freebsd stable - 3ware 3dmd broken in STABLE ( perhaps Re: cvs commit: src/sys/kern uipc

If this information is useful, please help other people find it:
Share via:

Mike Tancsa

2003-Apr-09 09:45 UTC

3ware 3dmd broken in STABLE ( perhaps Re: cvs commit: src/sys/kern uipc_syscalls.c ?)

Hi,
         I noticed that the 3ware disk monitoring daemon was no longer 
working on a stable box.  It works up until the 3rd of April
There seems to be something that broke the 3ware 3dmd daemon due to MFCs 
between april 4 and 5th.

If I cvsup with
default release=cvs tag=RELENG_4 date=2003.04.04.00.00.00

all is OK.

if I cvsup with
default release=cvs tag=RELENG_4 date=2003.04.05.00.00.00
It seems the commits of that day break the 3ware daemon.

The program normally starts up and forks 2 additional programs, one of 
which binds to a port and LISTENS for incomming connections. However it 
does not get that far on a kernel post April 4rd.  Instead the single 
process hangs there and is non functional.

The commits that day are below. I dont use ipx, nor the em nor puc drivers 
so I dont think its one of those.

  Edit src/UPDATING
   Add delta 1.73.2.81 2003.04.04.06.25.18 murray
  Edit src/bin/sh/jobs.c
   Add delta 1.27.2.10 2003.04.04.08.16.26 tjr
  Edit src/etc/mail/aliases
   Add delta 1.10.4.7 2003.04.04.06.15.55 gshapiro
  Edit src/release/Makefile
   Add delta 1.536.2.107 2003.04.04.15.48.17 ru
  Edit src/release/alpha/dokern.sh
   Add delta 1.56.2.6 2003.04.04.17.10.30 ru
  Edit src/release/doc/en_US.ISO8859-1/errata/article.sgml
   Add delta 1.1.2.99 2003.04.04.06.51.06 bmah
   Add delta 1.1.2.100 2003.04.04.07.39.47 bmah
   Add delta 1.1.2.101 2003.04.04.18.45.55 bmah
  Edit src/release/doc/en_US.ISO8859-1/hardware/common/dev.sgml
   Add delta 1.13.2.80 2003.04.04.15.13.23 bmah
  Edit src/release/doc/en_US.ISO8859-1/relnotes/common/new.sgml
   Add delta 1.22.2.347 2003.04.04.06.49.20 bmah
  Edit src/release/doc/share/sgml/release.ent
   Add delta 1.1.2.18 2003.04.04.06.47.07 bmah
  Edit src/release/i386/dokern.sh
   Add delta 1.58.2.6 2003.04.04.11.51.11 ru
   Add delta 1.58.2.7 2003.04.04.17.10.31 ru
  Edit src/release/pc98/dokern.sh
   Add delta 1.66.2.2 2003.04.04.17.10.31 ru
  Edit src/release/scripts/doFS.sh
   Add delta 1.24.2.12 2003.04.04.11.58.05 ru
  Edit src/secure/lib/Makefile
   Add delta 1.19.2.5 2003.04.04.21.33.15 ru
  Edit src/sys/conf/files
   Add delta 1.340.2.133 2003.04.04.22.21.29 tegge
  Edit src/sys/conf/newvers.sh
   Add delta 1.44.2.30 2003.04.04.07.02.46 murray
  Edit src/sys/conf/options
   Add delta 1.191.2.50 2003.04.04.22.21.29 tegge
  Edit src/sys/dev/em/LICENSE
   Add delta 1.1.2.2 2003.04.04.18.39.28 pdeuskar
  Edit src/sys/dev/em/README
   Add delta 1.1.2.6 2003.04.04.18.39.28 pdeuskar
  Edit src/sys/dev/em/if_em.c
   Add delta 1.2.2.12 2003.04.04.18.39.28 pdeuskar
  Edit src/sys/dev/em/if_em.h
   Add delta 1.1.2.12 2003.04.04.18.39.28 pdeuskar
  Edit src/sys/dev/em/if_em_hw.c
   Add delta 1.1.2.7 2003.04.04.18.39.28 pdeuskar
  Edit src/sys/dev/em/if_em_hw.h
   Add delta 1.1.2.7 2003.04.04.18.39.28 pdeuskar
  Edit src/sys/dev/em/if_em_osdep.h
   Add delta 1.1.2.10 2003.04.04.18.39.28 pdeuskar
  Edit src/sys/dev/puc/puc.c
   Add delta 1.3.2.5 2003.04.04.08.42.17 sobomax
  Edit src/sys/dev/puc/pucdata.c
   Add delta 1.2.2.10 2003.04.04.08.42.17 sobomax
  Edit src/sys/dev/puc/pucvar.h
   Add delta 1.1.2.4 2003.04.04.08.42.17 sobomax
  Edit src/sys/fs/smbfs/smbfs_vnops.c
   Add delta 1.2.2.8 2003.04.04.08.57.23 tjr
  Edit src/sys/i386/conf/LINT
   Add delta 1.749.2.140 2003.04.04.22.21.30 tegge
  Edit src/sys/i386/i386/machdep.c
   Add delta 1.385.2.29 2003.04.04.22.21.29 tegge
  Edit src/sys/isa/sio.c
   Add delta 1.291.2.34 2003.04.04.08.42.17 sobomax
  Edit src/sys/isa/sioreg.h
   Add delta 1.15.2.3 2003.04.04.08.42.17 sobomax
  Edit src/sys/kern/kern_descrip.c
   Add delta 1.81.2.16 2003.04.04.17.24.44 tegge
  Edit src/sys/kern/kern_fork.c
   Add delta 1.72.2.12 2003.04.04.17.24.44 tegge
  Edit src/sys/kern/uipc_syscalls.c
   Add delta 1.65.2.16 2003.04.04.17.04.04 tegge
   Add delta 1.65.2.17 2003.04.04.17.11.16 tegge
  Edit src/sys/kern/vfs_subr.c
   Add delta 1.249.2.30 2003.04.04.20.35.57 tegge
  Edit src/sys/kern/vfs_syscalls.c
   Add delta 1.151.2.18 2003.04.04.20.35.58 tegge
  Edit src/sys/netipx/ipx.c
   Add delta 1.17.2.2 2003.04.04.08.47.50 tjr
   Add delta 1.17.2.3 2003.04.04.09.35.43 tjr
  Edit src/sys/sys/mount.h
   Add delta 1.89.2.7 2003.04.04.20.35.57 tegge
  Edit src/sys/ufs/ffs/ffs_rawread.c
   Add delta 1.3.2.1 2003.04.04.22.21.30 tegge
  Edit src/sys/ufs/ufs/ufs_readwrite.c
   Add delta 1.65.2.14 2003.04.04.22.21.29 tegge
Shutting down connection to server



At 09:11 AM 04/04/2003 -0800, Tor Egge wrote:>tegge       2003/04/04 09:11:16 PST
>
>   FreeBSD src repository
>
>   Modified files:        (Branch: RELENG_4)
>     sys/kern             uipc_syscalls.c
>   Log:
>   MFC: Sync new socket nonblocking/async state with file flags in accept().
>
>   PR:             1775
>
>   Revision   Changes    Path
>   1.65.2.17  +7 -0      src/sys/kern/uipc_syscalls.c
>_______________________________________________
>cvs-all@freebsd.org mailing list
>http://lists.freebsd.org/mailman/listinfo/cvs-all
>To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"

Mike Tancsa

2003-Apr-09 11:00 UTC

head link

3ware 3dmd broken in STABLE ( perhaps Re: cvs commit: src/sys/kern uipc_syscalls.c ?)

OK, some more information.  As I narrowed it down to one day worth of 
commits, its easy enough to jump back and forth. Running ktrace -di 
/usr/local/sbin/3dmd shows its barfing when it goes to fork.


A *normal* chain of events first, and then the failing one.

....
   198 3dmd     RET   sigaction 0
    198 3dmd     CALL  sigaction(0x7f,0xbfbffa54,0xbfbffa3c)
    198 3dmd     RET   sigaction 0
    198 3dmd     CALL  fork
    198 3dmd     RET   fork 199/0xc7
    198 3dmd     CALL  close(0xffffffff)
    198 3dmd     RET   close -1 errno 9 Bad file descriptor
    198 3dmd     CALL  exit(0)
    199 3dmd     RET   fork 0
    199 3dmd     CALL  rfork(0x10)
    199 3dmd     RET   rfork 200/0xc8
    199 3dmd     CALL  rfork(0x10)
    199 3dmd     RET   rfork 201/0xc9
    199 3dmd     CALL  nanosleep(0xbfbffa64,0xbfbffa5c)
    200 3dmd     RET   fork 0
    200 3dmd     CALL  socket(0x2,0x1,0)
    200 3dmd     RET   socket 3
    200 3dmd     CALL  bind(0x3,0xbfbff77c,0x10)
    200 3dmd     RET   bind 0
    200 3dmd     CALL  listen(0x3,0x80)
    200 3dmd     RET   listen 0
    200 3dmd     CALL  open(0x80ba214,0x2,0xbfbff00c)
    200 3dmd     NAMI  "/dev/twe0"
    200 3dmd     RET   open 4


All looks good in the above.  In the below, the rfork fails for some reason.

  143 3dmd     RET   sigaction 0
    143 3dmd     CALL  sigaction(0x7f,0xbfbffa54,0xbfbffa3c)
    143 3dmd     RET   sigaction 0
    143 3dmd     CALL  fork
    143 3dmd     RET   fork 144/0x90
    143 3dmd     CALL  close(0xffffffff)
    143 3dmd     RET   close -1 errno 9 Bad file descriptor
    143 3dmd     CALL  exit(0)
    144 3dmd     RET   fork 0
    144 3dmd     CALL  rfork(0x10)
    144 3dmd     RET   rfork -1 errno 22 Invalid argument
    144 3dmd     CALL  rfork(0x10)
    144 3dmd     RET   rfork -1 errno 22 Invalid argument
    144 3dmd     CALL  nanosleep(0xbfbffa64,0xbfbffa5c)


At 12:51 PM 09/04/2003 -0400, Mike Tancsa wrote:
>Hi,
>         I noticed that the 3ware disk monitoring daemon was no longer 
> working on a stable box.  It works up until the 3rd of April
>There seems to be something that broke the 3ware 3dmd daemon due to MFCs 
>between april 4 and 5th.
>
>If I cvsup with
>default release=cvs tag=RELENG_4 date=2003.04.04.00.00.00
>
>all is OK.
>
>if I cvsup with
>default release=cvs tag=RELENG_4 date=2003.04.05.00.00.00
>It seems the commits of that day break the 3ware daemon.
>
>The program normally starts up and forks 2 additional programs, one of 
>which binds to a port and LISTENS for incomming connections. However it 
>does not get that far on a kernel post April 4rd.  Instead the single 
>process hangs there and is non functional.
>
>The commits that day are below. I dont use ipx, nor the em nor puc drivers 
>so I dont think its one of those.
>
>  Edit src/UPDATING
>   Add delta 1.73.2.81 2003.04.04.06.25.18 murray
>  Edit src/bin/sh/jobs.c
>   Add delta 1.27.2.10 2003.04.04.08.16.26 tjr
>  Edit src/etc/mail/aliases
>   Add delta 1.10.4.7 2003.04.04.06.15.55 gshapiro
>  Edit src/release/Makefile
>   Add delta 1.536.2.107 2003.04.04.15.48.17 ru
>  Edit src/release/alpha/dokern.sh
>   Add delta 1.56.2.6 2003.04.04.17.10.30 ru
>  Edit src/release/doc/en_US.ISO8859-1/errata/article.sgml
>   Add delta 1.1.2.99 2003.04.04.06.51.06 bmah
>   Add delta 1.1.2.100 2003.04.04.07.39.47 bmah
>   Add delta 1.1.2.101 2003.04.04.18.45.55 bmah
>  Edit src/release/doc/en_US.ISO8859-1/hardware/common/dev.sgml
>   Add delta 1.13.2.80 2003.04.04.15.13.23 bmah
>  Edit src/release/doc/en_US.ISO8859-1/relnotes/common/new.sgml
>   Add delta 1.22.2.347 2003.04.04.06.49.20 bmah
>  Edit src/release/doc/share/sgml/release.ent
>   Add delta 1.1.2.18 2003.04.04.06.47.07 bmah
>  Edit src/release/i386/dokern.sh
>   Add delta 1.58.2.6 2003.04.04.11.51.11 ru
>   Add delta 1.58.2.7 2003.04.04.17.10.31 ru
>  Edit src/release/pc98/dokern.sh
>   Add delta 1.66.2.2 2003.04.04.17.10.31 ru
>  Edit src/release/scripts/doFS.sh
>   Add delta 1.24.2.12 2003.04.04.11.58.05 ru
>  Edit src/secure/lib/Makefile
>   Add delta 1.19.2.5 2003.04.04.21.33.15 ru
>  Edit src/sys/conf/files
>   Add delta 1.340.2.133 2003.04.04.22.21.29 tegge
>  Edit src/sys/conf/newvers.sh
>   Add delta 1.44.2.30 2003.04.04.07.02.46 murray
>  Edit src/sys/conf/options
>   Add delta 1.191.2.50 2003.04.04.22.21.29 tegge
>  Edit src/sys/dev/em/LICENSE
>   Add delta 1.1.2.2 2003.04.04.18.39.28 pdeuskar
>  Edit src/sys/dev/em/README
>   Add delta 1.1.2.6 2003.04.04.18.39.28 pdeuskar
>  Edit src/sys/dev/em/if_em.c
>   Add delta 1.2.2.12 2003.04.04.18.39.28 pdeuskar
>  Edit src/sys/dev/em/if_em.h
>   Add delta 1.1.2.12 2003.04.04.18.39.28 pdeuskar
>  Edit src/sys/dev/em/if_em_hw.c
>   Add delta 1.1.2.7 2003.04.04.18.39.28 pdeuskar
>  Edit src/sys/dev/em/if_em_hw.h
>   Add delta 1.1.2.7 2003.04.04.18.39.28 pdeuskar
>  Edit src/sys/dev/em/if_em_osdep.h
>   Add delta 1.1.2.10 2003.04.04.18.39.28 pdeuskar
>  Edit src/sys/dev/puc/puc.c
>   Add delta 1.3.2.5 2003.04.04.08.42.17 sobomax
>  Edit src/sys/dev/puc/pucdata.c
>   Add delta 1.2.2.10 2003.04.04.08.42.17 sobomax
>  Edit src/sys/dev/puc/pucvar.h
>   Add delta 1.1.2.4 2003.04.04.08.42.17 sobomax
>  Edit src/sys/fs/smbfs/smbfs_vnops.c
>   Add delta 1.2.2.8 2003.04.04.08.57.23 tjr
>  Edit src/sys/i386/conf/LINT
>   Add delta 1.749.2.140 2003.04.04.22.21.30 tegge
>  Edit src/sys/i386/i386/machdep.c
>   Add delta 1.385.2.29 2003.04.04.22.21.29 tegge
>  Edit src/sys/isa/sio.c
>   Add delta 1.291.2.34 2003.04.04.08.42.17 sobomax
>  Edit src/sys/isa/sioreg.h
>   Add delta 1.15.2.3 2003.04.04.08.42.17 sobomax
>  Edit src/sys/kern/kern_descrip.c
>   Add delta 1.81.2.16 2003.04.04.17.24.44 tegge
>  Edit src/sys/kern/kern_fork.c
>   Add delta 1.72.2.12 2003.04.04.17.24.44 tegge
>  Edit src/sys/kern/uipc_syscalls.c
>   Add delta 1.65.2.16 2003.04.04.17.04.04 tegge
>   Add delta 1.65.2.17 2003.04.04.17.11.16 tegge
>  Edit src/sys/kern/vfs_subr.c
>   Add delta 1.249.2.30 2003.04.04.20.35.57 tegge
>  Edit src/sys/kern/vfs_syscalls.c
>   Add delta 1.151.2.18 2003.04.04.20.35.58 tegge
>  Edit src/sys/netipx/ipx.c
>   Add delta 1.17.2.2 2003.04.04.08.47.50 tjr
>   Add delta 1.17.2.3 2003.04.04.09.35.43 tjr
>  Edit src/sys/sys/mount.h
>   Add delta 1.89.2.7 2003.04.04.20.35.57 tegge
>  Edit src/sys/ufs/ffs/ffs_rawread.c
>   Add delta 1.3.2.1 2003.04.04.22.21.30 tegge
>  Edit src/sys/ufs/ufs/ufs_readwrite.c
>   Add delta 1.65.2.14 2003.04.04.22.21.29 tegge
>Shutting down connection to server
>
>
>
>At 09:11 AM 04/04/2003 -0800, Tor Egge wrote:
>>tegge       2003/04/04 09:11:16 PST
>>
>>   FreeBSD src repository
>>
>>   Modified files:        (Branch: RELENG_4)
>>     sys/kern             uipc_syscalls.c
>>   Log:
>>   MFC: Sync new socket nonblocking/async state with file flags in
accept().
>>
>>   PR:             1775
>>
>>   Revision   Changes    Path
>>   1.65.2.17  +7 -0      src/sys/kern/uipc_syscalls.c
>>_______________________________________________
>>cvs-all@freebsd.org mailing list
>>http://lists.freebsd.org/mailman/listinfo/cvs-all
>>To unsubscribe, send any mail to
"cvs-all-unsubscribe@freebsd.org"
>
>_______________________________________________
>freebsd-stable@freebsd.org mailing list
>http://lists.freebsd.org/mailman/listinfo/freebsd-stable
>To unsubscribe, send any mail to
"freebsd-stable-unsubscribe@freebsd.org"

Mike Tancsa

2003-Apr-09 11:29 UTC

head link

3ware 3dmd broken in STABLE ( due to cvs commit: src/sys/kern kern_descrip.c kern_fork.c )

At 06:18 PM 09/04/2003 +0000, Tor.Egge@cvsup.no.freebsd.org
wrote:> >
> > OK, some more information.  As I narrowed it down to one day worth of
> > commits, its easy enough to jump back and forth. Running ktrace -di
> > /usr/local/sbin/3dmd shows its barfing when it goes to fork.
>
> >     199 3dmd     CALL  rfork(0x10)
> >     199 3dmd     RET   rfork 200/0xc8
>
>This explains the problem.  The program calls rfork(RFPROC) which now
>fails due to my commit to kern_fork.c.  Reverting back to revision
>1.72.2.11 of kern_fork.c should allow 3dmd to run, but it will also
>allow for file lock leakage due to a shared file descriptor table
>being used without a shared p_leader.

Thanks.  Is there a work around where the lock leakage can be fixed and the 
3ware daemon can work ?  I dont know who (if anyone) has the source code to 
the 3dmd program, is this something that could be easily fixed in it ?  Are 
there any other programs that will break as a result of your commit as well ?

         ---Mike

vizion communication

2003-Apr-09 11:52 UTC

head link

Proxim Harmony Wireless PCI card 802.11a

Hi Guys

Does anyone happen to know if theProxim Harmony 802.11a is
supported for 4.7?

David

Tor.Egge@cvsup.no.freebsd.org

2003-Apr-09 12:34 UTC

head link

3ware 3dmd broken in STABLE ( due to cvs commit: src/sys/kern kern_descrip.c kern_fork.c )

> Thanks.  Is there a work around where the lock leakage can be fixed and the
> 3ware daemon can work ?  I dont know who (if anyone) has the source code to
> the 3dmd program, is this something that could be easily fixed in it ?  Are
> there any other programs that will break as a result of your commit as well
?
Changing the rfork() system call in kern_fork.c to add the RFTHREAD
flag instead of returning EINVAL might allow the 3ware daemon to work.

Another alternative is to modify the 3dmd binary to add the RFTHREAD
flag in rfork() at 0x806b39c.

- Tor Egge

freebsd stable - Apr 2003 - 3ware 3dmd broken in STABLE ( perhaps Re: cvs commit: src/sys/kern uipc_syscalls.c ?)

3ware 3dmd broken in STABLE ( perhaps Re: cvs commit: src/sys/kern uipc_syscalls.c ?)

3ware 3dmd broken in STABLE ( perhaps Re: cvs commit: src/sys/kern uipc_syscalls.c ?)

3ware 3dmd broken in STABLE ( due to cvs commit: src/sys/kern kern_descrip.c kern_fork.c )

Proxim Harmony Wireless PCI card 802.11a

3ware 3dmd broken in STABLE ( due to cvs commit: src/sys/kern kern_descrip.c kern_fork.c )