configure.in | 44 ++++++++++++++++++++++++--------------------
1 file changed, 24 insertions(+), 20 deletions(-)
New commits:
commit 9fa7b7c8f2d1d8a9c50f3ba0f99087f653b6a9b8
Author: Akira TAGOH <akira at tagoh.org>
Date: Fri Apr 20 11:17:41 2012 +0900
Rework to avoid adding the unexpected value to ICONV_CFLAGS and ICONV_LIBS
diff --git a/configure.in b/configure.in
index 9c9de30..9bb0988 100644
--- a/configure.in
+++ b/configure.in
@@ -150,7 +150,11 @@ AC_DEFINE_UNQUOTED(USE_REGEX,$use_regex,[Use regex.])
AC_ARG_WITH(libiconv,
[AC_HELP_STRING([--with-libiconv=DIR],
[Use libiconv in DIR])],
- [libiconv_prefix=$withval],
+ [if test "x$withval" = "xyes"; then
+ libiconv_prefix=$prefix
+ else
+ libiconv_prefix=$withval
+ fi],
[libiconv_prefix=auto])
AC_ARG_WITH(libiconv-includes,
[AC_HELP_STRING([--with-libiconv-includes=DIR],
@@ -163,33 +167,33 @@ AC_ARG_WITH(libiconv-lib,
[libiconv_lib=$withval],
[libiconv_lib=auto])
-# if none of libiconv,libiconv-includes,libiconv-libs are specified
-if test "$libiconv_prefix" != "auto" -o
"$libiconv_includes" != "auto" -o "$libiconv_lib"
!= "auto"; then
- if test "$libiconv_includes" != "auto" -a -r
${libiconv_includes}/iconv.h; then
- libiconv_cflags="-I${libiconv_includes}"
- elif test "$libiconv_prefix" != "auto" -a -r
${libiconv_prefix}/include/iconv.h; then
- libiconv_cflags="-I${libiconv_prefix}/include"
- else
- libiconv_cflags=""
- fi
- if test "$libiconv_lib" != "auto"; then
- libiconv_lib="-L${libiconv_lib} -liconv"
- elif test "$libiconv_prefix" != "auto"; then
- libiconv_lib="-L${libiconv_prefix}/lib -liconv"
- elif test "x$libiconv_cflags" != "x"; then
- libiconv_lib="-liconv"
+# if no libiconv,libiconv-includes,libiconv-lib are specified,
+# libc''s iconv has a priority.
+if test "$libiconv_includes" != "auto" -a -r
${libiconv_includes}/iconv.h; then
+ libiconv_cflags="-I${libiconv_includes}"
+elif test "$libiconv_prefix" != "auto" -a -r
${libiconv_prefix}/include/iconv.h; then
+ libiconv_cflags="-I${libiconv_prefix}/include"
+else
+ libiconv_cflags=""
+fi
+libiconv_libs=""
+if test "x$libiconv_cflags" != "x"; then
+ if test "$libiconv_lib" != "auto" -a -d ${libiconv_lib};
then
+ libiconv_libs="-L${libiconv_lib} -liconv"
+ elif test "$libiconv_prefix" != "auto" -a -d
${libiconv_prefix}/lib; then
+ libiconv_libs="-L${libiconv_prefix}/lib -liconv"
else
- libiconv_lib=""
+ libiconv_libs="-liconv"
fi
fi
use_iconv=0
AC_MSG_CHECKING([for a usable iconv])
-if test "x$libiconv_cflags" != "x" -o
"x$libiconv_lib" != "x"; then
+if test "x$libiconv_cflags" != "x" -o
"x$libiconv_libs" != "x"; then
iconvsaved_CFLAGS="$CFLAGS"
iconvsaved_LIBS="$LIBS"
CFLAGS="$CFLAGS $libiconv_cflags"
- LIBS="$LIBS $libiconv_lib"
+ LIBS="$LIBS $libiconv_libs"
AC_TRY_LINK([#include <iconv.h>],
[iconv_open ("from", "to");],
@@ -200,7 +204,7 @@ if test "x$libiconv_cflags" != "x" -o
"x$libiconv_lib" != "x"; then
CFLAGS="$iconvsaved_CFLAGS"
LIBS="$iconvsaved_LIBS"
ICONV_CFLAGS="$libiconv_cflags"
- ICONV_LIBS="$libiconv_lib"
+ ICONV_LIBS="$libiconv_libs"
fi
if test "x$use_iconv" = "x0"; then
AC_TRY_LINK([#include <iconv.h>],
On 04/19/2012 10:19 PM, Akira TAGOH wrote:> Rework to avoid adding the unexpected value to ICONV_CFLAGS and ICONV_LIBSTo be honest, I''d suggest we just remove the iconv and non-Unicode cmap support altogether. 2012 afterall... b
On Fri, Apr 20, 2012 at 11:24 AM, Behdad Esfahbod <behdad at behdad.org> wrote:> To be honest, I''d suggest we just remove the iconv and non-Unicode cmap > support altogether. ?2012 afterall...Maybe. though I have these non-Unicode cmap fonts here... So that may be good to drop this feature in a phased manner. first step would be to enable it only when the sort of --with-non-unicode-cmap is specified. more comments on this is welcome. -- Akira TAGOH
On 04/19/2012 10:44 PM, Akira TAGOH wrote:> On Fri, Apr 20, 2012 at 11:24 AM, Behdad Esfahbod <behdad at behdad.org> wrote: >> To be honest, I''d suggest we just remove the iconv and non-Unicode cmap >> support altogether. 2012 afterall... > > Maybe. though I have these non-Unicode cmap fonts here...Maybe lets survey how widely the feature is used then? What fonts do you have? Others? behdad> So that may be good to drop this feature in a phased manner. first > step would be to enable it only when the sort of > --with-non-unicode-cmap is specified. > > more comments on this is welcome.
just created: https://bugs.freedesktop.org/show_bug.cgi?id=48947 On Fri, Apr 20, 2012 at 11:46 AM, Behdad Esfahbod <behdad at behdad.org> wrote:> Maybe lets survey how widely the feature is used then?Good idea. but how? :) we can ask on some mailing list perhaps.> ?What fonts do you > have? ?Others?It''s Japanese fonts. though I don''t use those fonts so often. so might just works without them. -- Akira TAGOH
Adobe''s CoolType font engine (used by InDesign and Photoshop, for example) supported non-Unicode cmaps for a long while because early on we''d found that certain CJK fonts didn''t have Unicode cmaps. However, our relatively newer CTS font engine (the new world-ready text engine in Flash) only has Unicode cmap support, and we haven''t encountered any issues with that for the past several years it''s been shipping. One question to ask may be: Are there OSes out there that ship with fonts without Unicode cmaps? I highly doubt it. Speaking of deprecating old formats, CTS also put a stake in the ground and supports only OpenType fonts (no legacy Type 1 fonts or bitmapped fonts). Again, I''ve heard absolutely no complaints about this. Sairus -----Original Message----- From: fontconfig-bounces+sppatel=adobe.com at lists.freedesktop.org [mailto:fontconfig-bounces+sppatel=adobe.com at lists.freedesktop.org] On Behalf Of Akira TAGOH Sent: Thursday, April 19, 2012 8:08 PM To: Behdad Esfahbod Cc: fontconfig at fontconfig.org Subject: Re: [Fontconfig] fontconfig: Branch ''master'' just created: https://bugs.freedesktop.org/show_bug.cgi?id=48947 On Fri, Apr 20, 2012 at 11:46 AM, Behdad Esfahbod <behdad at behdad.org> wrote:> Maybe lets survey how widely the feature is used then?Good idea. but how? :) we can ask on some mailing list perhaps.> ?What fonts do you > have? ?Others?It''s Japanese fonts. though I don''t use those fonts so often. so might just works without them. -- Akira TAGOH _______________________________________________ Fontconfig mailing list Fontconfig at lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/fontconfig
On Thu, 19 Apr 2012 22:39:32 -0700, Sairus Patel <sppatel at adobe.com> wrote:> Speaking of deprecating old formats, CTS also put a stake in the > ground and supports only OpenType fonts (no legacy Type 1 fonts or > bitmapped fonts). Again, I''ve heard absolutely no complaints about > this.I''ve had a plan to convert the bitmap X fonts to otf format, which would eliminate PCF/BDF code from the X server... -- keith.packard at intel.com -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 827 bytes Desc: not available URL: <http://lists.freedesktop.org/archives/fontconfig/attachments/20120420/94f43baa/attachment-0001.pgp>
On Fri, Apr 20, 2012 at 01:55:21AM EDT, Keith Packard wrote:> On Thu, 19 Apr 2012 22:39:32 -0700, Sairus Patel <sppatel at adobe.com> wrote: > > > Speaking of deprecating old formats, CTS also put a stake in the > > ground and supports only OpenType fonts (no legacy Type 1 fonts or > > bitmapped fonts). Again, I''ve heard absolutely no complaints about > > this. > > I''ve had a plan to convert the bitmap X fonts to otf format, which would > eliminate PCF/BDF code from the X server...Forgive the naive question. Regarding fixed fonts, would conversion be possible without loss of quality? I am thinking of GNU/Unifont (used by grub''s menu for instance), which is available both in PCF & TTF form. As it hapens, the TTF version as rendered on an xterm is practically illegible. CJ -- Alex Perez is aliveeeeeeee!!!
On 04/20/2012 01:55 AM, Keith Packard wrote:> I''ve had a plan to convert the bitmap X fonts to otf format, which would > eliminate PCF/BDF code from the X server...Keith, face it, you''ve had that plan since, 2006 at least :-). Not that I object if someone goes ahead and does this! (hint hint) Cheers, behdad
On Fri, 20 Apr 2012 17:16:16 -0400, Behdad Esfahbod <behdad at behdad.org> wrote:> On 04/20/2012 01:55 AM, Keith Packard wrote: > > I''ve had a plan to convert the bitmap X fonts to otf format, which would > > eliminate PCF/BDF code from the X server... > > Keith, face it, you''ve had that plan since, 2006 at least :-).I got most of the way done, then got sidetracked :-) -- keith.packard at intel.com -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 827 bytes Desc: not available URL: <http://lists.freedesktop.org/archives/fontconfig/attachments/20120420/2d868167/attachment.pgp>
Le Ven 20 avril 2012 04:46, Behdad Esfahbod a ?crit :> On 04/19/2012 10:44 PM, Akira TAGOH wrote: >> On Fri, Apr 20, 2012 at 11:24 AM, Behdad Esfahbod <behdad at behdad.org> wrote: >>> To be honest, I''d suggest we just remove the iconv and non-Unicode cmap >>> support altogether. 2012 afterall... >> >> Maybe. though I have these non-Unicode cmap fonts here... > > Maybe lets survey how widely the feature is used then? What fonts do you > have? Others?You also have all the old crap non-standard fonts which have been embedded in pdf documents (and continue to be because some pdf generators are expensive and people try to keep them forever), will those documents still work if fontconfig stops supporting cmap ? -- Nicolas Mailhot
On Tue, Apr 24, 2012 at 12:37 AM, Nicolas Mailhot <nicolas.mailhot at laposte.net> wrote:> You also have all the old crap non-standard fonts which have been embedded in > pdf documents (and continue to be because some pdf generators are expensive > and people try to keep them forever), will those documents still work if > fontconfig stops supporting cmap ?That may depends on the implementation. poppler seems not using FcFreeTypeQueryFace() at least, which will be affected by that change. -- Akira TAGOH
On 04/23/2012 10:05 PM, Akira TAGOH wrote:> On Tue, Apr 24, 2012 at 12:37 AM, Nicolas Mailhot > <nicolas.mailhot at laposte.net> wrote: >> You also have all the old crap non-standard fonts which have been embedded in >> pdf documents (and continue to be because some pdf generators are expensive >> and people try to keep them forever), will those documents still work if >> fontconfig stops supporting cmap ? > > That may depends on the implementation. poppler seems not using > FcFreeTypeQueryFace() at least, which will be affected by that change.Off the top of my head, PDF fonts never use cmap, so they should be fine. I may be wrong though. b
On 04/20/2012 01:39 AM, Sairus Patel wrote:> Adobe''s CoolType font engine (used by InDesign and Photoshop, for example) supported non-Unicode cmaps for a long while because early on we''d found that certain CJK fonts didn''t have Unicode cmaps. However, our relatively newer CTS font engine (the new world-ready text engine in Flash) only has Unicode cmap support, and we haven''t encountered any issues with that for the past several years it''s been shipping.Thanks Sairus, this is encouraging.> One question to ask may be: Are there OSes out there that ship with fonts without Unicode cmaps? I highly doubt it.Same here. I can imagine X bitmap fonts fall in that category, but we don''t really care about those in the fontconfig-using side of things. behdad> Speaking of deprecating old formats, CTS also put a stake in the ground and supports only OpenType fonts (no legacy Type 1 fonts or bitmapped fonts). Again, I''ve heard absolutely no complaints about this. > > Sairus > > > -----Original Message----- > From: fontconfig-bounces+sppatel=adobe.com at lists.freedesktop.org [mailto:fontconfig-bounces+sppatel=adobe.com at lists.freedesktop.org] On Behalf Of Akira TAGOH > Sent: Thursday, April 19, 2012 8:08 PM > To: Behdad Esfahbod > Cc: fontconfig at fontconfig.org > Subject: Re: [Fontconfig] fontconfig: Branch ''master'' > > just created: https://bugs.freedesktop.org/show_bug.cgi?id=48947 > > On Fri, Apr 20, 2012 at 11:46 AM, Behdad Esfahbod <behdad at behdad.org> wrote: >> Maybe lets survey how widely the feature is used then? > > Good idea. but how? :) we can ask on some mailing list perhaps. > >> What fonts do you >> have? Others? > > It''s Japanese fonts. though I don''t use those fonts so often. so might just works without them. > > > -- > Akira TAGOH > _______________________________________________ > Fontconfig mailing list > Fontconfig at lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/fontconfig
Okay, so that may be worth trying to disable iconv by default in next release but still keep it as optional and let''s see how many people still want this feature and get rid of it at the end. On Tue, Apr 24, 2012 at 11:12 AM, Behdad Esfahbod <behdad at behdad.org> wrote:> On 04/20/2012 01:39 AM, Sairus Patel wrote: >> Adobe''s CoolType font engine (used by InDesign and Photoshop, for example) supported non-Unicode cmaps for a long while because early on we''d found that certain CJK fonts didn''t have Unicode cmaps. However, our relatively newer CTS font engine (the new world-ready text engine in Flash) only has Unicode cmap support, and we haven''t encountered any issues with that for the past several years it''s been shipping. > > Thanks Sairus, this is encouraging. > >> One question to ask may be: Are there OSes out there that ship with fonts without Unicode cmaps? I highly doubt it. > > Same here. ?I can imagine X bitmap fonts fall in that category, but we don''t > really care about those in the fontconfig-using side of things. > > > behdad > >> Speaking of deprecating old formats, CTS also put a stake in the ground and supports only OpenType fonts (no legacy Type 1 fonts or bitmapped fonts). Again, I''ve heard absolutely no complaints about this. >> >> Sairus >> >> >> -----Original Message----- >> From: fontconfig-bounces+sppatel=adobe.com at lists.freedesktop.org [mailto:fontconfig-bounces+sppatel=adobe.com at lists.freedesktop.org] On Behalf Of Akira TAGOH >> Sent: Thursday, April 19, 2012 8:08 PM >> To: Behdad Esfahbod >> Cc: fontconfig at fontconfig.org >> Subject: Re: [Fontconfig] fontconfig: Branch ''master'' >> >> just created: https://bugs.freedesktop.org/show_bug.cgi?id=48947 >> >> On Fri, Apr 20, 2012 at 11:46 AM, Behdad Esfahbod <behdad at behdad.org> wrote: >>> Maybe lets survey how widely the feature is used then? >> >> Good idea. but how? :) we can ask on some mailing list perhaps. >> >>> ? What fonts do you >>> have? ?Others? >> >> It''s Japanese fonts. though I don''t use those fonts so often. so might just works without them. >> >> >> -- >> Akira TAGOH >> _______________________________________________ >> Fontconfig mailing list >> Fontconfig at lists.freedesktop.org >> http://lists.freedesktop.org/mailman/listinfo/fontconfig-- Akira TAGOH