Fontconfig - Feb 2006 - Remaining bugs and feature requests before 2.3.94

Hi all,

To my knowledge, the only remaining issue is with Bitstream Charter and
lang=en (in an email I sent about 30 minutes ago).  Please let me know
if there''s anything else that I forgot about.

There are a couple of small features that would be nice to have:

* fc-cat <dirname> should produce a fonts.cache-1-style listing for the
directory.
* fc-cache --really-force (this should take approximately 15 minutes).

Could someone cook up patches for these features?

pat

Le jeudi 09 f?vrier 2006 ? 11:27 -0500, Patrick Lam a ?crit
:
> Hi all,
> 
> To my knowledge, the only remaining issue is with Bitstream Charter and
> lang=en (in an email I sent about 30 minutes ago).  Please let me know
> if there''s anything else that I forgot about.
Hmm, what about the cache always growing / updating bug when
fonts.cache-2 is present in the same directory as fonts that I reported
earlier this week ?

-- 
Frederic Crozat <fcrozat@mandriva.com>
Mandriva

Le jeudi 09 f?vrier 2006 ? 17:37 +0100, Frederic Crozat a ?crit
:
> Le jeudi 09 f?vrier 2006 ? 11:27 -0500, Patrick Lam a ?crit :
> > Hi all,
> > 
> > To my knowledge, the only remaining issue is with Bitstream Charter
and
> > lang=en (in an email I sent about 30 minutes ago).  Please let me know
> > if there''s anything else that I forgot about.
> 
> Hmm, what about the cache always growing / updating bug when
> fonts.cache-2 is present in the same directory as fonts that I reported
> earlier this week ?
Woops, I didn''t saw your reply about this specific bug.. 

-- 
Frederic Crozat <fcrozat@mandriva.com>
Mandriva

Frederic Crozat wrote:
> Le jeudi 09 f?vrier 2006 ? 11:27 -0500, Patrick Lam a ?crit :
> 
>>Hi all,
>>
>>To my knowledge, the only remaining issue is with Bitstream Charter and
>>lang=en (in an email I sent about 30 minutes ago).  Please let me know
>>if there''s anything else that I forgot about.
> 
> 
> Hmm, what about the cache always growing / updating bug when
> fonts.cache-2 is present in the same directory as fonts that I reported
> earlier this week ?
See the mail I sent just before this one.  I believe I''ve fixed it.

pat

"fc-list" from the current CVS snapshot of fontconfig
lists pcf even if BDF properties like

    FAMILY_NAME "Fixed"
    CHARSET_REGISTRY "ISO8859"
    CHARSET_ENCODING "15"

are missing. For details see:

http://bugzilla.novell.com/show_bug.cgi?id=150552

As FAMILY_NAME is missing, fontconfig lists the file name instead.

But as fontconfig only supports ISO-8859-1 and ISO-10646-1 encoded
fonts, it cannot use such broken fonts with other encodings anyway, if
trying to use them for example with "xfd", one gets only crashes:

mfabian@magellan:~$ fc-match johabshp16.pcf
johabshp16.pcf.gz: "johabshp16.pcf" "Regular"
mfabian@magellan:~$ fc-match ptpR24.pcf
ptpR24.pcf.gz: "ptpR24.pcf" "Regular"
mfabian@magellan:~$ xfd -fa johabshp16.pcf
Warning: Cannot convert string "johabshp16.pcf" to type XftFont
????????????? (core dumped)
mfabian@magellan:~$ xfd -fa ptpR24.pcf
Warning: Cannot convert string "ptpR24.pcf" to type XftFont
????????????? (core dumped)
mfabian@magellan:~$

Probably fontconfig shouldn''t list such fonts in the first place
to avoid such problems.

-- 
Mike FABIAN   <mfabian@suse.de>   http://www.suse.de/~mfabian
?????????????

Mike FABIAN <mfabian@suse.de> ????????:

[...]
> For details see:
>
> http://bugzilla.novell.com/show_bug.cgi?id=150552
>
> As FAMILY_NAME is missing, fontconfig lists the file name instead.
[...]
> Probably fontconfig shouldn''t list such fonts in the first place
> to avoid such problems.
I made a patch to ignore all bitmap fonts which lack the BDF property
FAMILY_NAME. Attached.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: ignore-broken-bitmap-fonts.patch
Type: text/x-patch
Size: 748 bytes
Desc: not available
Url :
http://lists.freedesktop.org/archives/fontconfig/attachments/20060213/fb6b16f7/ignore-broken-bitmap-fonts.bin
-------------- next part --------------

-- 
Mike FABIAN   <mfabian@suse.de>   http://www.suse.de/~mfabian
?????????????

Mike FABIAN wrote:
> +		goto bail1;
I think that should be bail1, because cs isn''t freed yet. 
I''ve
committed with a goto to bail2.

pat

Patrick Lam <plam@MIT.EDU> ????????:
> Mike FABIAN wrote:
>> +		goto bail1;
>
> I think that should be bail1, because cs isn''t freed yet. 
I''ve
> committed with a goto to bail2.
I see.

Then what about the two "bail1" a few lines up?:


    if (!(face->face_flags & FT_FACE_FLAG_SCALABLE))
    {
    for (i = 0; i < face->num_fixed_sizes; i++)
        if (!FcPatternAddDouble (pat, FC_PIXEL_SIZE,
                                           FcGetPixelSize (face, i)))
                                                          goto bail1;
                                                          if
(!FcPatternAddBool (pat, FC_ANTIALIAS, FcFalse))
                       goto bail1;
#


Shouldn''t those be "bail2" as well?

-- 
Mike FABIAN   <mfabian@suse.de>   http://www.suse.de/~mfabian
?????????????

Patrick Lam wrote:
> * fc-cat <dirname> should produce a fonts.cache-1-style listing for
the
> directory.
Ok, I''ve implemented this feature. I wish I could say where fontconfig 
was getting this information (e.g. potentially which cache file 
corresponds to the direcotry), but that would require some more cutting 
and pasting, and I didn''t feel like doing that.  In any case, e.g.

fc-cat /usr/share/fonts/truetype/ttf-bitstream-vera

should produce the same output as the fonts.cache-1 file in that 
directory, as generated by old fontconfig.

Are there any more open fontconfig issues?  I''m not aware of any...

pat

Patrick Lam <plam@MIT.EDU> ????????:
> Patrick Lam wrote:
>> * fc-cat <dirname> should produce a fonts.cache-1-style listing
for the
>> directory.
>
> Ok, I''ve implemented this feature. I wish I could say where
fontconfig
> was getting this information (e.g. potentially which cache file
> corresponds to the direcotry), but that would require some more
> cutting and pasting, and I didn''t feel like doing that.  In any
case,
> e.g.
>
> fc-cat /usr/share/fonts/truetype/ttf-bitstream-vera
>
> should produce the same output as the fonts.cache-1 file in that
> directory, as generated by old fontconfig.
Well, it doesn''t:

mfabian@magellan:~$ fc-cat /usr/X11R6/lib/X11/fonts/truetype
????????????? (core dumped)
mfabian@magellan:~$ fc-cat /usr/X11R6/lib/X11/fonts/Type1
????????????? (core dumped)
mfabian@magellan:~$

(with today''s CVS snapshot).

-- 
Mike FABIAN   <mfabian@suse.de>   http://www.suse.de/~mfabian
?????????????

Mike FABIAN <mfabian@suse.de> ????????:
> Patrick Lam <plam@MIT.EDU> ????????:
>
>> Patrick Lam wrote:
>>> * fc-cat <dirname> should produce a fonts.cache-1-style
listing for the
>>> directory.
>>
>> Ok, I''ve implemented this feature. I wish I could say where
fontconfig
>> was getting this information (e.g. potentially which cache file
>> corresponds to the direcotry), but that would require some more
>> cutting and pasting, and I didn''t feel like doing that.  In
any case,
>> e.g.
>>
>> fc-cat /usr/share/fonts/truetype/ttf-bitstream-vera
>>
>> should produce the same output as the fonts.cache-1 file in that
>> directory, as generated by old fontconfig.
>
> Well, it doesn''t:
>
> mfabian@magellan:~$ fc-cat /usr/X11R6/lib/X11/fonts/truetype
> ????????????? (core dumped)
> mfabian@magellan:~$ fc-cat /usr/X11R6/lib/X11/fonts/Type1
> ????????????? (core dumped)
> mfabian@magellan:~$
>
> (with today''s CVS snapshot).
The attached patch seems to fix it.

See also:

    http://bugzilla.novell.com/show_bug.cgi?id=152453

-------------- next part --------------
A non-text attachment was scrubbed...
Name: fc-cat-crash.patch
Type: text/x-patch
Size: 1244 bytes
Desc: not available
Url :
http://lists.freedesktop.org/archives/fontconfig/attachments/20060221/72a32923/fc-cat-crash.bin
-------------- next part --------------

-- 
Mike FABIAN   <mfabian@suse.de>   http://www.suse.de/~mfabian
?????????????

Mike FABIAN wrote:
> The attached patch seems to fix it.
Yeah, it seems harmless to initialize fontconfig in fc-cat, so I
committed your patch.

pat