-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Patrick Lam wrote:> There''s a patch at > > https://bugs.freedesktop.org/show_bug.cgi?id=4549 > > which looks good to me. Keith, should I commit it to the branch? [Do > we eventually want to deprecate expat support?]I''ve also tested it, and it works for me; the most recent revision of the patch, anyhow. pat -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.1 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org iD8DBQFDNIsKNTVxnNGEyOgRAnv5AJ9n4+210jSTJMjBAKh0/rIHIv4mrACeIglv 2tZzHuwDMkMuigzplduUC+0=1saW -----END PGP SIGNATURE-----
Behdad Esfahbod
2005-Nov-21 08:51 UTC
[Fontconfig] Re: Mathias Hasselmann''s libxml2 patch
On Sat, 24 Sep 2005, Keith Packard wrote:> I''d like to have a matching layer so you could build against either xml > library; there remain a few environments which may prefer to use expat > for a while longer yet. Realize that expat is rather a lot smaller tha > libxml2. Of course, many applications are already using libxml2, making > expat entirely spurious. If only there were a way to make > per-application choices about which xml library to use.Well, on glibc, dlsym(RTLD_DEFAULT, .) can be used to check whether libxml2 and/or expat are already linked in.> -keith--behdad http://behdad.org/
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Keith Packard wrote:> > I''d like to have a matching layer so you could build against either xml > library; there remain a few environments which may prefer to use expat > for a while longer yet. Realize that expat is rather a lot smaller tha > libxml2. Of course, many applications are already using libxml2, making > expat entirely spurious. If only there were a way to make > per-application choices about which xml library to use.I don''t have a lot of configure-fu, but it would be at least good if configure could deal with the possibility of only one of expat and libxml2 being installed and do the right thing. Is that possible? Oh, and is it ok by you to make 2.3.91 with the libxml2 patch included? pat -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.1 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org iD8DBQFDNT0gNTVxnNGEyOgRArVDAJ9RdL6D1AsFhSF5IGtMok1QLz3+BgCgmr6+ 6dBM3oI/Fw/JnxcBhGUBx7Q=p5Vb -----END PGP SIGNATURE-----
Mathias Hasselmann wrote:> Next revision of the patch: > https://bugs.freedesktop.org/attachment.cgi?id=3424&action=diffLooks good. I''ve committed this version of the patch. 2.3.91 coming soon. pat
On Fri, 2005-09-23 at 19:08 -0400, Patrick Lam wrote:> -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > Patrick Lam wrote: > > There''s a patch at > > > > https://bugs.freedesktop.org/show_bug.cgi?id=4549 > > > > which looks good to me. Keith, should I commit it to the branch? [Do > > we eventually want to deprecate expat support?]I''d like to have a matching layer so you could build against either xml library; there remain a few environments which may prefer to use expat for a while longer yet. Realize that expat is rather a lot smaller tha libxml2. Of course, many applications are already using libxml2, making expat entirely spurious. If only there were a way to make per-application choices about which xml library to use. -keith -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 189 bytes Desc: This is a digitally signed message part Url : http://lists.freedesktop.org/archives/fontconfig/attachments/20050923/352597d4/attachment.pgp
On Sat, 2005-09-24 at 14:42 +0200, Mathias Hasselmann wrote:> Am Samstag, den 24.09.2005, 07:48 -0400 schrieb Patrick Lam: > > I don''t have a lot of configure-fu, but it would be at least good if > > configure could deal with the possibility of only one of expat and > > libxml2 being installed and do the right thing. Is that possible? > > Could do that quite quickly. Only question to resolve: Which one to > choose, if both exist and no option was specified? Based on Keith''s > statements I guess, expat should stay as default?I think for now we should leave expat as the default, and allow the configure script to override this option. At some point, it might make sense to switch the default. A bit of history -- fontconfig started with libxml2 (not in SAX mode) and I switched it when people complained about the size of that library. -keith -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 189 bytes Desc: This is a digitally signed message part Url : http://lists.freedesktop.org/archives/fontconfig/attachments/20050924/3f773ba1/attachment.pgp
Keith Packard wrote:> On Sat, 2005-09-24 at 14:42 +0200, Mathias Hasselmann wrote: > >>Am Samstag, den 24.09.2005, 07:48 -0400 schrieb Patrick Lam: >> >>>I don''t have a lot of configure-fu, but it would be at least good if >>>configure could deal with the possibility of only one of expat and >>>libxml2 being installed and do the right thing. Is that possible? >> >>Could do that quite quickly. Only question to resolve: Which one to >>choose, if both exist and no option was specified? Based on Keith''s >>statements I guess, expat should stay as default? > > I think for now we should leave expat as the default, and allow the > configure script to override this option. At some point, it might make > sense to switch the default.Ok. Mathias, if you create a patch that uses expat as the default and uses libxml2 if configure says so or if expat is not present, I''ll commit it to the 2_4 branch and make a dev release. pat