Le samedi 19 novembre 2005 ? 11:28 -0500, Patrick Lam a ?crit :> Great; thanks a lot. I''ve committed this patch. (Yeah, now I don''t > need to go back to fc-lang and understand what''s going on there; it''s > not completely straightforward). > > The other patch I''d like to include before 2.4 is Mathias Clasen''s > freetype internals patch, but I need to understand what''s going on > there. Apart from that, I think we just need some stability testing of > the branch before we make a 2.4 release. Keep those bug reports and > patches coming!BTW, it seems the crosscheck patch was never merged in 2.4 branch. Is it wanted ? (I''m followed Mathias footsteps and merged it in Mandriva cooker package). -- Frederic Crozat <fcrozat@mandriva.com> Mandriva
Frederic Crozat wrote:> BTW, it seems the crosscheck patch was never merged in 2.4 branch. Is it > wanted ? (I''m followed Mathias footsteps and merged it in Mandriva > cooker package).Nope. It isn''t really a generally useful patch, especially since it never gets triggered anyway. pat
On Mon, 2005-11-21 at 10:26 -0500, Patrick Lam wrote:> Frederic Crozat wrote: > > BTW, it seems the crosscheck patch was never merged in 2.4 branch. Is it > > wanted ? (I''m followed Mathias footsteps and merged it in Mandriva > > cooker package). > > Nope. It isn''t really a generally useful patch, especially since it > never gets triggered anyway. >I''ll remove it before fc5, but leave it in for now.
One thing that would be great to change for 2.4 is to ship pre-generated documentation in the tarball, and have a --disable-docs configure option to avoid regenerating the docs when installing from the tarball. This is generally accepted best practice, and avoids a lot of fragile build-time dependencies on jade, tex, sgml tools, etc. I am currently having problems building fontconfig in rawhide, because jade has problems on ppc. This should not be necessary at all unless the docs are platform-dependent. Matthias
Great; thanks a lot. I''ve committed this patch. (Yeah, now I don''t need to go back to fc-lang and understand what''s going on there; it''s not completely straightforward). The other patch I''d like to include before 2.4 is Mathias Clasen''s freetype internals patch, but I need to understand what''s going on there. Apart from that, I think we just need some stability testing of the branch before we make a 2.4 release. Keep those bug reports and patches coming! pat sunmoon1997 wrote:> Here comes the further fix. There is a few of issues in Pat''s patch. - > -miscounted numbers count (numbers_count) > -didn''t strip duplicate numbers (langBankNumbers) > -leafidx_offset and numbers_offset in fcLangCharSets are wrong. > > This patch fixes all of above. I removed leafidx_count and > numbers_count since they are the same and I replaced them with > offset_count. > Now fontcong works as before;) > > Patrick Lam wrote: > >>Matthias Clasen wrote: >> >> >>>Another interesting bug in this area is 2878, which complains that >>>all the FcCharSets in fcLangCharSets are stored in .data and cause >>>relocations, although they are not modified at runtime. It seems to me >>>that it should be possible to fix this by generating the charsets >>>in the form in which fc-cache stores them in the mmap cache, but I > > have > >>>not been able to work out the details. >> >> >>I''ve committed the attached patch to the branch subsequent to tagging >>2.3.92 (release announcement for that will follow once I get home and >>type in my gpg password). However, I''m also sending it to the list > > for > >>comments: I''m not entirely sure that this patch is correct, as I don''t >>know how to test it. Keith and Matthias, can you take a look? It > > does > >>seem to work, for what that''s worth. >> >>pat >> >>
On Sat, 2005-11-19 at 11:28 -0500, Patrick Lam wrote:> Great; thanks a lot. I''ve committed this patch. (Yeah, now I don''t > need to go back to fc-lang and understand what''s going on there; it''s > not completely straightforward). > > The other patch I''d like to include before 2.4 is Mathias Clasen''s > freetype internals patch, but I need to understand what''s going on > there. Apart from that, I think we just need some stability testing of > the branch before we make a 2.4 release. Keep those bug reports and > patches coming! >The freetype internals patch replaces uses of freetype internal api by the ftglue code which David Turner provided for the same purpose in Pango. I''m using a fontconfig with this patch on my system, and it seems to work fine. (As far as I can tell as a non-CJK user, since the freetype internals are only used to extract information about complex features from OpenType fonts...). I''ll push a current cvs snapshot of fontconfig + this patch into rawhide as soon as FC5 test1 is out. Or maybe you can do a 2.3.93 with this patch, to get some more testing. Matthias
Skipped content of type multipart/mixed-------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 189 bytes Desc: =?UTF-8?Q?=E8=BF=99=E6=98=AF=E4=BF=A1=E4=BB=B6=E7=9A=84=E6=95=B0? =?UTF-8?Q?=E5=AD=97=E7=AD=BE=E5=90=8D=E9=83=A8=E5=88=86?Url : http://lists.freedesktop.org/archives/fontconfig/attachments/20051119/6bf7e9f4/attachment.pgp