Thanks for the help Martijn, I get the same FLAC__STREAM_DECODER_END_OF_STREAM error after doing the 2 steps you suggested. Scott On Mon, May 19, 2014 at 9:36 AM, Martijn van Beurden <mvanb1 at gmail.com>wrote:> Once more hi, > > I've tried to reproduce this issue, but I am unable to do so. Could you > try to re-encode the file with FLAC (to make sure it is not an issue with > Taglib) and try to strip with metaflac again? This can be done as follows > > flac input.flac -o output.flac > metaflac --dont-use-padding --remove --block-type=PADDING output.flac > > If this turns out to be fine it probably solves your problem, but still I > would be interested in a file to check whether Taglib produces > non-compliant files or metaflac doesn't accept all valid input. If it turns > out that metaflac doesn't like this either, there is something rather weird > going on. > > > op 19-05-14 15:21, Scott Brown schreef: > > ERROR while decoding data > state = FLAC__STREAM_DECODER_END_OF_STREAM > > It's happening with every file that I've tried now, using both 1.2.1 and > 1.3.0. > > If a file has artwork and I remove padding, I get the above error when > verifying or decompressing. If no artwork and I remove padding, the file > verifies and decompresses with no issues. > > I'm writing tags via Taglib's file.save() but removing padding via > metaflac. > > Thanks, > Scott > > > On Mon, May 19, 2014 at 9:16 AM, Martijn van Beurden <mvanb1 at gmail.com>wrote: > >> Hi Scott, >> >> Can you be a little more specific? What error do you get? I'm unable to >> reproduce this error currently, do you have any files you can share that >> are problematic? What version of metaflac are you using? >> >> It might be a bug, it might be corruption induced by some other part of >> the system. >> >> op 19-05-14 15:04, Scott Brown schreef: >> >> I want to remove padding from flac files, so I ran the following >> command on files with artwork in them: >> >> metaflac --dont-use-padding --remove --block-type=PADDING [filename] >> >> >> but now my files are corrupt. Verifying them reports a stream error >> and they won't decode. >> >> If the files had no picture data in them, the remove padding command >> did not corrupt them. >> >> Is this a bug, or did I run something bad with metaflac? >> >> Thanks, >> Scott >> >> >> _______________________________________________ >> Flac mailing listFlac at xiph.orghttp://lists.xiph.org/mailman/listinfo/flac >> >> >> >> _______________________________________________ >> Flac mailing list >> Flac at xiph.org >> http://lists.xiph.org/mailman/listinfo/flac >> >> > > > _______________________________________________ > Flac mailing list > Flac at xiph.org > http://lists.xiph.org/mailman/listinfo/flac > >-------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.xiph.org/pipermail/flac/attachments/20140519/0f850761/attachment-0001.htm
Oh, I forgot to tell (but you probably had that figured out anyway) that those 2 steps were for a file that you didn't strip of padding before. Would it be possible you send me a part of a file that is affected? I'd like to know what happened, so this can be fixed. I presume the FLAC__STREAM_DECODER_END_OF_STREAM errors occur right after the album art? In that case, if the files are too big and you are using linux you could use head -c 500kB input.flac > input-first500kb.flac I don't know any equivalent methods on other operating systems. If the included album art is bigger than 500kb, you might want to change the numbers accordingly. op 19-05-14 15:56, Scott Brown schreef:> Thanks for the help Martijn, > > I get the same FLAC__STREAM_DECODER_END_OF_STREAM error > after doing the 2 steps you suggested. > > Scott > > > On Mon, May 19, 2014 at 9:36 AM, Martijn van Beurden > <mvanb1 at gmail.com <mailto:mvanb1 at gmail.com>> wrote: > > Once more hi, > > I've tried to reproduce this issue, but I am unable to do > so. Could you try to re-encode the file with FLAC (to make > sure it is not an issue with Taglib) and try to strip with > metaflac again? This can be done as follows > > flac input.flac -o output.flac > metaflac --dont-use-padding --remove --block-type=PADDING > output.flac > > If this turns out to be fine it probably solves your > problem, but still I would be interested in a file to > check whether Taglib produces non-compliant files or > metaflac doesn't accept all valid input. If it turns out > that metaflac doesn't like this either, there is something > rather weird going on. > > > op 19-05-14 15:21, Scott Brown schreef: >> ERROR while decoding data >> state >> FLAC__STREAM_DECODER_END_OF_STREAM >> >> It's happening with every file that I've tried now, using >> both 1.2.1 and 1.3.0. >> >> If a file has artwork and I remove padding, I get the >> above error when verifying or decompressing. If no >> artwork and I remove padding, the file verifies and >> decompresses with no issues. >> >> I'm writing tags via Taglib's file.save() but removing >> padding via metaflac. >> >> Thanks, >> Scott >> >> >> On Mon, May 19, 2014 at 9:16 AM, Martijn van Beurden >> <mvanb1 at gmail.com <mailto:mvanb1 at gmail.com>> wrote: >> >> Hi Scott, >> >> Can you be a little more specific? What error do you >> get? I'm unable to reproduce this error currently, do >> you have any files you can share that are >> problematic? What version of metaflac are you using? >> >> It might be a bug, it might be corruption induced by >> some other part of the system. >> >> op 19-05-14 15:04, Scott Brown schreef: >>> I want to remove padding from flac files, so I ran >>> the following command on files with artwork in them: >>> >>> metaflac --dont-use-padding --remove >>> --block-type=PADDING [filename] >>> >>> >>> but now my files are corrupt. Verifying them reports >>> a stream error and they won't decode. >>> >>> If the files had no picture data in them, the remove >>> padding command did not corrupt them. >>> >>> Is this a bug, or did I run something bad with metaflac? >>> >>> Thanks, >>> Scott >>> >>> >>> _______________________________________________ >>> Flac mailing list >>> Flac at xiph.org <mailto:Flac at xiph.org> >>> http://lists.xiph.org/mailman/listinfo/flac >> >> >> _______________________________________________ >> Flac mailing list >> Flac at xiph.org <mailto:Flac at xiph.org> >> http://lists.xiph.org/mailman/listinfo/flac >> >> > > > _______________________________________________ > Flac mailing list > Flac at xiph.org <mailto:Flac at xiph.org> > http://lists.xiph.org/mailman/listinfo/flac > >-------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.xiph.org/pipermail/flac/attachments/20140519/9c5fbb73/attachment.htm
I thought I ran it on a fresh file, but I just double checked and I must have run it on a stripped file earlier because I don't get the error now on an un-stripped file. I suppose it is an issue with TagLib? Would you still be curious to see one of the "bad" files? Thanks, Scott On Mon, May 19, 2014 at 10:06 AM, Martijn van Beurden <mvanb1 at gmail.com>wrote:> Oh, I forgot to tell (but you probably had that figured out anyway) that > those 2 steps were for a file that you didn't strip of padding before. > > Would it be possible you send me a part of a file that is affected? I'd > like to know what happened, so this can be fixed. I presume the > FLAC__STREAM_DECODER_END_OF_STREAM errors occur right after the album art? > In that case, if the files are too big and you are using linux you could > use head -c 500kB input.flac > input-first500kb.flac I don't know any > equivalent methods on other operating systems. If the included album art is > bigger than 500kb, you might want to change the numbers accordingly. > > op 19-05-14 15:56, Scott Brown schreef: > > Thanks for the help Martijn, > > I get the same FLAC__STREAM_DECODER_END_OF_STREAM error after doing the > 2 steps you suggested. > > Scott > > > On Mon, May 19, 2014 at 9:36 AM, Martijn van Beurden <mvanb1 at gmail.com>wrote: > >> Once more hi, >> >> I've tried to reproduce this issue, but I am unable to do so. Could you >> try to re-encode the file with FLAC (to make sure it is not an issue with >> Taglib) and try to strip with metaflac again? This can be done as follows >> >> flac input.flac -o output.flac >> metaflac --dont-use-padding --remove --block-type=PADDING output.flac >> >> If this turns out to be fine it probably solves your problem, but still I >> would be interested in a file to check whether Taglib produces >> non-compliant files or metaflac doesn't accept all valid input. If it turns >> out that metaflac doesn't like this either, there is something rather weird >> going on. >> >> >> op 19-05-14 15:21, Scott Brown schreef: >> >> ERROR while decoding data >> state = FLAC__STREAM_DECODER_END_OF_STREAM >> >> It's happening with every file that I've tried now, using both 1.2.1 >> and 1.3.0. >> >> If a file has artwork and I remove padding, I get the above error when >> verifying or decompressing. If no artwork and I remove padding, the file >> verifies and decompresses with no issues. >> >> I'm writing tags via Taglib's file.save() but removing padding via >> metaflac. >> >> Thanks, >> Scott >> >> >> On Mon, May 19, 2014 at 9:16 AM, Martijn van Beurden <mvanb1 at gmail.com>wrote: >> >>> Hi Scott, >>> >>> Can you be a little more specific? What error do you get? I'm unable to >>> reproduce this error currently, do you have any files you can share that >>> are problematic? What version of metaflac are you using? >>> >>> It might be a bug, it might be corruption induced by some other part of >>> the system. >>> >>> op 19-05-14 15:04, Scott Brown schreef: >>> >>> I want to remove padding from flac files, so I ran the following >>> command on files with artwork in them: >>> >>> metaflac --dont-use-padding --remove --block-type=PADDING [filename] >>> >>> >>> but now my files are corrupt. Verifying them reports a stream error >>> and they won't decode. >>> >>> If the files had no picture data in them, the remove padding command >>> did not corrupt them. >>> >>> Is this a bug, or did I run something bad with metaflac? >>> >>> Thanks, >>> Scott >>> >>> >>> _______________________________________________ >>> Flac mailing listFlac at xiph.orghttp://lists.xiph.org/mailman/listinfo/flac >>> >>> >>> >>> _______________________________________________ >>> Flac mailing list >>> Flac at xiph.org >>> http://lists.xiph.org/mailman/listinfo/flac >>> >>> >> >> >> _______________________________________________ >> Flac mailing list >> Flac at xiph.org >> http://lists.xiph.org/mailman/listinfo/flac >> >> > >-------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.xiph.org/pipermail/flac/attachments/20140519/892ec20c/attachment-0001.htm