flac dev - Mar 2022 - nasm: error: unrecognised option `-m' compilation on i686

Hi,

When compiling on IA32 I get a nasm option -mstackrealign which
results in 'nasm: error: unrecognised option `-m'.

I believe that the compile option -mstackrealign is meant
to be used only for C, so I propose the following patch:

diff -rauN flac-1.3.4/CMakeLists.txt
flac-1.3.4-no-mstackrealign-for-nasm-patch/CMakeLists.txt
--- flac-1.3.4/CMakeLists.txt   2022-02-14 06:21:14.011609811 +0100
+++ flac-1.3.4-no-mstackrealign-for-nasm-patch/CMakeLists.txt   2022-03-10
09:54:48.719704370 +0100
@@ -97,7 +97,7 @@
 endif()

 if(CMAKE_SYSTEM_PROCESSOR STREQUAL "i686" AND HAVE_STACKREALIGN_FLAG)
-    add_compile_options(-mstackrealign)
+    add_compile_options($<$<COMPILE_LANGUAGE:C>:-mstackrealign>)
 endif()

 include_directories("include")

Cheers

Andreas

--
Andreas Baumann
Trottenstrasse 20
CH-8037 Zuerich
Telefon: +41(0)76/373 01 29
E-mail: mail at andreasbaumann.cc
Homepage: www.andreasbaumann.cc
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL:
<http://lists.xiph.org/pipermail/flac-dev/attachments/20220310/615e1210/attachment.sig>

Op do 10 mrt. 2022 10:16 schreef Andreas Baumann <mail at
andreasbaumann.cc>:
> When compiling on IA32 I get a nasm option -mstackrealign which
> results in 'nasm: error: unrecognised option `-m'.
>
> I believe that the compile option -mstackrealign is meant
> to be used only for C, so I propose the following patch:
>
There's a patch waiting for inclusion already here:
https://github.com/xiph/flac/pull/216
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.xiph.org/pipermail/flac-dev/attachments/20220312/ff38a272/attachment.htm>