flac dev - May 2018 - [bug] --keep-foreign-metadata discards WAV cue markers

Hello,
I noticed that option --keep-foreign-metadata discards WAV cue
markers. Here is how to reproduce the bug:
1) Create a 24-bit 96khz in SoundForge8, add 20 seconds of silence,
and add two markers with "m" key shortcut
2) Save it, compress it with "flac --keep-foreign-metadata
testmarkers.wav"
3) Decompress it with "flac -d testmarkers.flac"
4) Open the decompressed WAV in SoundForge: the markers have disappeared.

Here is the WAV containing markers:  http://gget.it/q4uh4/testmarkers.zip

Best regards,
NC

Try using the following to decompress, instead:

flac -d —keep-foreign-metadata testmarkers.wav

Thanks for providing a test file. I was able to reproduce your issue following
your commands, then I was able to restore the original WAV file with markers by
adding the extra parameter. I’ve always used it this way, but often wondered
whether the extra option was necessary. Apparently, it is.

Hope this helps,

Brian Willoughby


On May 11, 2018, at 5:21 PM, Nouvelle Collection <nouvellecollection at
gmail.com> wrote:
> Hello,
> I noticed that option --keep-foreign-metadata discards WAV cue
> markers. Here is how to reproduce the bug:
> 1) Create a 24-bit 96khz in SoundForge8, add 20 seconds of silence,
> and add two markers with "m" key shortcut
> 2) Save it, compress it with "flac --keep-foreign-metadata
testmarkers.wav"
> 3) Decompress it with "flac -d testmarkers.flac"
> 4) Open the decompressed WAV in SoundForge: the markers have disappeared.
> 
> Here is the WAV containing markers:  http://gget.it/q4uh4/testmarkers.zip
> 
> Best regards,
> NC

Thank you  very much, it works indeed with:
flac -d --keep-foreign-metadata testmarkers.flac

Suggestion for devs:
1) If a file has been compressed with  "--keep-foreign-metadata", then
make
"flac -d" decompress the file with metadata *by default*, without
having to
also do "--keep-foreign-metadata" during decompression. It makes sense
that, if we compressed with this option enabled, the file should keep the
metadata, also during decompression.

2) Could we enable --stdout also when using "flac -d 
--keep-foreign-metadata"?
It would be useful for this purpose:

    md5sum myfile.wav
    flac -d --keep-foreign-metadata myfile.flac --stdout | md5sum

This would allow to compare the original file (including the markers and
metadata) and the result of the decompression of the flac, to be 100% sure
that the metadata are kept in the compressed file.

Best regards.
​
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.xiph.org/pipermail/flac-dev/attachments/20180513/8e3685d8/attachment.html>