lvqcl wrote:> > These versions of Visual Studio don't have stdint.h and > > all [u]intNN_t types. But now these types are everywhere > > in FLAC codebase. > > Here is the patch that fixes the problem: > it moves definitions of all [u]intNN_t types from share/compat.h > into new file share/msvc2005_int.h and then includes this file > into all files (via "Force Includes" option in *.vcproj files). > > The definitions of these types are inside #if block with > _MSC_VER < 1600 condition, so these changes affect only MS Visual > Studio compilers with _MSC_VER < 1600 (i.e. MSVS 2005 and 2008).Thats a really great solution to this problem. Applied! Cheers, Erik -- ---------------------------------------------------------------------- Erik de Castro Lopo http://www.mega-nerd.com/
On 1/18/17, Erik de Castro Lopo <mle+la at mega-nerd.com> wrote:> lvqcl wrote: > >> > These versions of Visual Studio don't have stdint.h and >> > all [u]intNN_t types. But now these types are everywhere >> > in FLAC codebase. >> >> Here is the patch that fixes the problem: >> it moves definitions of all [u]intNN_t types from share/compat.h >> into new file share/msvc2005_int.h and then includes this file >> into all files (via "Force Includes" option in *.vcproj files). >> >> The definitions of these types are inside #if block with >> _MSC_VER < 1600 condition, so these changes affect only MS Visual >> Studio compilers with _MSC_VER < 1600 (i.e. MSVS 2005 and 2008). > > Thats a really great solution to this problem. Applied!New file is not in the repo (you possibly forgot to 'git add' )
Erik de Castro Lopo wrote:>> The definitions of these types are inside #if block with >> _MSC_VER < 1600 condition, so these changes affect only MS Visual >> Studio compilers with _MSC_VER < 1600 (i.e. MSVS 2005 and 2008). > > Thats a really great solution to this problem. Applied!Thanks. But I can't see new file share/msvc2005_int.h in the current git snapshot.
lvqcl wrote:> Thanks. But I can't see new file share/msvc2005_int.h in > the current git snapshot.Yeah, fixed in a later commit. This is why I prefer git patches over plain diffs :). Erik -- ---------------------------------------------------------------------- Erik de Castro Lopo http://www.mega-nerd.com/