Hugo Beauzée-Luyssen wrote:>> configure.ac: Allow the programs to be disabled >> configure.ac: Allow bench to be disabled >> configure.ac: Don't build any tests when they are explicitely disabled >> configure.ac: Allow examples to be disabled >> win_utf8_io: Avoid forbidden functions when building for WinRT/UWP >> >> configure.ac | 10 ++++++++++ >> examples/Makefile.am | 2 ++ >> microbench/Makefile.am | 4 ++++ >> src/Makefile.am | 10 +++++++--- >> src/flac/Makefile.am | 13 +++++++++---- >> src/metaflac/Makefile.am | 8 ++++++-- >> src/share/win_utf8_io/win_utf8_io.c | 9 +++++++++ >> src/test_libFLAC++/Makefile.am | 5 +++++ >> 8 files changed, 52 insertions(+), 9 deletions(-) >> > > Ping :)I think that FLAC sources should remain compatible with Visual Studio 2010 (and probably earlier), people still need it. For example: <https://github.com/xiph/flac/issues/23> Is it possible to simply exclude win_utf8_io.c from compiling if target OS is WinRT/non-desktop?
Erik de Castro Lopo
2017-Jan-15 02:21 UTC
[flac-dev] [PATCH 0/5] Allow multiple targets to be disabled
lvqcl wrote:> I think that FLAC sources should remain compatible with Visual > Studio 2010 (and probably earlier), people still need it. > For example: <https://github.com/xiph/flac/issues/23> > > Is it possible to simply exclude win_utf8_io.c from compiling > if target OS is WinRT/non-desktop?And I defer to others like lvqcl for what we do and do not support on Windows. Erik -- ---------------------------------------------------------------------- Erik de Castro Lopo http://www.mega-nerd.com/
Hugo Beauzée-Luyssen
2017-Jan-18 09:57 UTC
[flac-dev] [PATCH 0/5] Allow multiple targets to be disabled
On 01/15/2017 03:21 AM, Erik de Castro Lopo wrote:> lvqcl wrote: > >> I think that FLAC sources should remain compatible with Visual >> Studio 2010 (and probably earlier), people still need it. >> For example: <https://github.com/xiph/flac/issues/23> >> >> Is it possible to simply exclude win_utf8_io.c from compiling >> if target OS is WinRT/non-desktop? > > And I defer to others like lvqcl for what we do and do not > support on Windows. > > Erik >Then the best solution would be to allow libflac to be built by disabling other targets, thus disabling the need for shared convenience libraries. However, as noted in the cover letter, I don't see any way of doing this without switching to non recursive Makefile.am Any opinion on that? In the meantime, I guess it's OK to simply drop patch 5 Regards,