flac dev - Jun 2016 - Please test more libFLAC/cpu.c changes

lvqcl wrote:
> Erik de Castro Lopo wrote:
> 
> >> Found a bug in Android OS SSE test.
> >
> > Sorry, what is the bug and how does this fix it?
> 
> FLAC__cpu_info(FLAC__CPUInfo *info): detects CPU features
> that can be used and sets corresponding flags in the info
> struct.
This code is in flux and in the current state the logic probably
has inconsistencies that will be fixed in due course.

What I am very much more interested in is if the code in the
wip/cpu branch currently compiles and passes the test on
Windows with MSVS.

Erik

-- 
----------------------------------------------------------------------
Erik de Castro Lopo
http://www.mega-nerd.com/

Erik de Castro Lopo wrote:
> This code is in flux and in the current state the logic probably
> has inconsistencies that will be fixed in due course.
>
> What I am very much more interested in is if the code in the
> wip/cpu branch currently compiles and passes the test on
> Windows with MSVS.
No, it doesn't:

     error C2010: '.' : unexpected in macro formal parameter list

It complains about the line

     #define dfprintf(file, format, args...)

The correct syntax for variadic macro in MSVC is:

     #define dfprintf(file, format, ...)


After this change, MSVC can compile flac without problems.

lvqcl wrote:
> Erik de Castro Lopo wrote:
> 
> > This code is in flux and in the current state the logic probably
> > has inconsistencies that will be fixed in due course.
> >
> > What I am very much more interested in is if the code in the
> > wip/cpu branch currently compiles and passes the test on
> > Windows with MSVS.
> 
> No, it doesn't:
> 
>      error C2010: '.' : unexpected in macro formal parameter list
> 
> It complains about the line
> 
>      #define dfprintf(file, format, args...)
> 
> The correct syntax for variadic macro in MSVC is:
> 
>      #define dfprintf(file, format, ...)
> 
> 
> After this change, MSVC can compile flac without problems.
Thanks. I'll get that fixed and merge that branch to master.

Erik
-- 
----------------------------------------------------------------------
Erik de Castro Lopo
http://www.mega-nerd.com/