lvqcl wrote:> No, FLAC__AVX_SUPPORTED is 0 (initially it's undefined, then inside cpu.h > it's defined as 0). > > MSVC cannot discard unused references in debug builds and when LTCG is on, > for example: <http://lists.ffmpeg.org/pipermail/ffmpeg-devel/2016-April/193437.html> > > And currently LTCG is enabled for release builds.Ok, I think I've fixed it in: commit a08e90c425343630d820b8775d5a2a63a02689ee Author: Erik de Castro Lopo <erikd at mega-nerd.com> Date: Sun Jun 26 21:09:08 2016 +1000 libFLAC/cpu.c: Fixes for MSVC Please test. Erik -- ---------------------------------------------------------------------- Erik de Castro Lopo http://www.mega-nerd.com/
Erik de Castro Lopo wrote:> Ok, I think I've fixed it in: > > commit a08e90c425343630d820b8775d5a2a63a02689ee > Author: Erik de Castro Lopo <erikd at mega-nerd.com> > Date: Sun Jun 26 21:09:08 2016 +1000 > > libFLAC/cpu.c: Fixes for MSVC > > > Please test.MSVC 2005 win32: OK MSVC 2010 win32: OK MSVC 2015 win32: OK MSVC 2010 x64: failed MSVC 2015 x64: failed error C4235: nonstandard extension used: '__asm' keyword not supported on this architecture MSVC doesn't support inline asm for x86_64 code. That's why it cannot compile ia32_cpu_info() for x86_64 arch. This can be fixed with the attached patch. -------------- next part -------------- A non-text attachment was scrubbed... Name: cpufix.patch Type: application/octet-stream Size: 574 bytes Desc: not available URL: <http://lists.xiph.org/pipermail/flac-dev/attachments/20160626/cbdf5734/attachment.obj>
lvqcl wrote:> MSVC 2005 win32: OK > MSVC 2010 win32: OK > MSVC 2015 win32: OK > MSVC 2010 x64: failed > MSVC 2015 x64: failed > > error C4235: nonstandard extension used: '__asm' keyword not supported on this architecture > > MSVC doesn't support inline asm for x86_64 code. That's why it > cannot compile ia32_cpu_info() for x86_64 arch. > > This can be fixed with the attached patch.Applied. Thanks. Unfortunately I think there will be quite a bit more breakage and pain before this thing is resolved. Erik -- ---------------------------------------------------------------------- Erik de Castro Lopo http://www.mega-nerd.com/