Has anyone tried to build flac with the INTEGER_ONLY_LIBRARY flag set lately? I'm getting link errors on IA32 for the SSE optimizations lpc_restore_signal_16_intrin_sse2 and lpc_restore_signal_wide_intrin_sse41. Looks like a define check is missing since the implementation of these functions is only included when not building for integer. I had to exclude them at libFLAC/stream_decoder.c:408 by adding a check for !FLAC__INTEGER_ONLY_LIBRARY. //Joakim ---------------------------------------------------------------------- Intel Sweden AB Registered Office: Isafjordsgatan 30B, 164 40 Kista, Stockholm, Sweden Registration Number: 556189-6027 This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies. -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.xiph.org/pipermail/flac-dev/attachments/20160318/c697c64d/attachment.htm
Landberg, Joakim wrote:> Has anyone tried to build flac with the INTEGER_ONLY_LIBRARY flag set lately?Actually, no. In fact, I am not even sure *how* to set that flag. How are you doing it? Erik -- ---------------------------------------------------------------------- Erik de Castro Lopo http://www.mega-nerd.com/
Landberg, Joakim wrote:> Has anyone tried to build flac with the INTEGER_ONLY_LIBRARY flag set lately?Well: ./configure echo "#define FLAC__INTEGER_ONLY_LIBRARY" >> config.h seems to do the trick.> I'm getting link errors on IA32 for the SSE optimizations lpc_restore_signal_16_intrin_sse2 > and lpc_restore_signal_wide_intrin_sse41. Looks like a define check is missing since the > implementation of these functions is only included when not building for integer. I had to > exclude them at libFLAC/stream_decoder.c:408 by adding a check for !FLAC__INTEGER_ONLY_LIBRARY.Fixed in: commit eae85ee7665d4d8604617d7bfb6529d112e7db91 Author: Erik de Castro Lopo <erikd at mega-nerd.com> Date: Sun Mar 20 17:49:39 2016 +1100 libFLAC/stream_decoder.c: Fix compiling with integer only Was failing to compile on IA32 with FLAC__INTEGER_ONLY_LIBRARY defined. Reported-by: "Joakim Landberg" <joakim.landberg at intel.com> Cheers, Erik -- ---------------------------------------------------------------------- Erik de Castro Lopo http://www.mega-nerd.com/