lvqcl wrote:> Then IMHO all three build systems (configure && make, Makefile.lite > and MSVC) should be synchronized with each other+1> TO ERIK: > > I have some patches, but they either modify MSVC .vcxproj files, > or win_utf8_io.c/.h, so they conflict with patches from Evan Ramos. > So should they be applied? rejected? postponed until after flac 1.3.2?We should figure out the bext way to get them appled. Erik -- ---------------------------------------------------------------------- Erik de Castro Lopo http://www.mega-nerd.com/
Erik de Castro Lopo wrote:>> I have some patches, but they either modify MSVC .vcxproj files, >> or win_utf8_io.c/.h, so they conflict with patches from Evan Ramos. >> So should they be applied? rejected? postponed until after flac 1.3.2? > > We should figure out the bext way to get them appled.I see now that my message wasn't clear enough... As a result your answer isn't clear to me. My question was about the patch from Evan Ramos that moves win_utf8_io.c into libFLAC: <http://lists.xiph.org/pipermail/flac-dev/2016-January/005746.html> If your answer was about this patch too, then all I can suggest is to apply this patch, then fix issues if they'll happen after this. (I already see one issue - it leaves some garbage in *.sln files. But it's quite easy to fix).
lvqcl wrote:> all I can suggest > is to apply this patch, then fix issues if they'll happen after > this.But seriously, as a matter of fact win_utf8_io is a part of libFLAC. Functions from libFLAC call functions from win_utf8_io... For example: FLAC__stream_decoder_init_file() calls init_file_internal_() that calls flac_fopen() that is defined as fopen_utf8(). Currently functions in win_utf8_io.c are a compatibility layer for libFLAC. I can't see reasons not to move win_utf8_io.c into libFLAC.