Evan Ramos wrote:> > Yes please. > > Patch attached.Sorry, I misunderstood your intention. The utf8_static library should stay as a separate component, but should be statically linked as needed (ie its only needed for Windows) Erik -- ---------------------------------------------------------------------- Erik de Castro Lopo http://www.mega-nerd.com/
Erik de Castro Lopo wrote:>> Patch attached. > > Sorry, I misunderstood your intention. The utf8_static library should > stay as a separate component, but should be statically linked as needed > (ie its only needed for Windows)My patch does not touch src/share/utf8, only src/share/win_utf8_io, which the objects in libFLAC.a depend on. Without the patch, any Windows project that links with -lFLAC would need to modify their build scripts to add -lwin_utf8_io (as opposed to the library being self-sufficient, other than libogg, optionally). -Evan
Evan Ramos wrote:> Erik de Castro Lopo wrote: > > >> Patch attached. > > > > Sorry, I misunderstood your intention. The utf8_static library should > > stay as a separate component, but should be statically linked as needed > > (ie its only needed for Windows) > > My patch does not touch src/share/utf8, only src/share/win_utf8_io, > which the objects in libFLAC.a depend on. Without the patch, any > Windows project that links with -lFLAC would need to modify their > build scripts to add -lwin_utf8_io (as opposed to the library being > self-sufficient, other than libogg, optionally).I may have double misunderstood :-). Let me have another look. Erik -- ---------------------------------------------------------------------- Erik de Castro Lopo http://www.mega-nerd.com/
Evan Ramos wrote:>> Sorry, I misunderstood your intention. The utf8_static library should >> stay as a separate component, but should be statically linked as needed >> (ie its only needed for Windows) > > My patch does not touch src/share/utf8, only src/share/win_utf8_io, > which the objects in libFLAC.a depend on. Without the patch, any > Windows project that links with -lFLAC would need to modify their > build scripts to add -lwin_utf8_io (as opposed to the library being > self-sufficient, other than libogg, optionally).IIRC libFLAC.a built with "./autogen.sh && ./configure && make" contains all functions from win_utf8_io. So I think it's possible to change some Makefile.lite or maybe build/*.mk files so that there will be no need to add -lwin_utf8_io to -lFLAC. Unfortunately I don't know much about this build system, and I can't help here.