flac dev - Nov 2014 - [PATCH] Re: [flac:bugs] #420 flac make check fails on os x

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

On 2014-11-24 9:49 PM, mark4o wrote:
> $ make check ... Original file size   441044 bytes. Compression
> level 0, file size   421389 bytes. ./test_compression.sh: line 42:
> let: last_size=: syntax error: operand expected (error token is
> "=")
I can reproduce on MacOS X 10.8.5. It doesn't seem to like the
assignment inside the let statement. Possible an issue with the older
bash (3.2) Apple ships?

The attached patch resolves the issue, and I believe does the same
thing. Martin, does this look correct to you?

 -r

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQEcBAEBCAAGBQJUdPRKAAoJEEcAD3uxRB3vxfEH/A75c5UycOYpnC06Kz9f9KM8
xjzWFfVaB8Fl0X7F586BkyRgmwJQK+NrLkb2FR4+m0MdTvpywpVrKSF9KjDc6p5x
ruuQSYJje1X8D4mIR/BeZZUJHtY7YIVIOnPoBfocn1lDtd/pEM4gUZxcaH9p5NWZ
GACOtdBOYh56RbH86AX5wbWuPADFnUTo2/09zME/3y4q1mPLjuZ5jOhPc3G82s+J
kRZSwxAKCE0jTtyk0qVraHOzU3bE2Et9FtbkWjeosEvS9O3bgj1aH+q5+Trhm+mb
6PPWi7npVVunoXfRrWyQieSTBJFrgboL6fYOfr3nOIu+GqJM4z5QQ/jARUwaaaI=jc02
-----END PGP SIGNATURE-----
-------------- next part --------------

Ralph Giles wrote:
> I can reproduce on MacOS X 10.8.5. It doesn't seem to like the
> assignment inside the let statement. Possible an issue with the older
> bash (3.2) Apple ships?
> 
> The attached patch resolves the issue, and I believe does the same
> thing. Martin, does this look correct to you?
I've applied a variant of Mark Harris' patch from sf.net.

Cheers,
Erik
-- 
----------------------------------------------------------------------
Erik de Castro Lopo
http://www.mega-nerd.com/

On 2014-11-25 9:29 PM, Erik de Castro Lopo wrote:
> I've applied a variant of Mark Harris' patch from sf.net.
Confirmed. 'make check' works on Mac for me now.

 -r