Erik de Castro Lopo wrote:>> I suspect that PPC/Altivec asm code is disabled for good. > > I agree.Does it make sense to keep this code, then? Nobody managed to fix this when it was timely, and now PPC (at least PPC for desktop use) is a legacy platform. 2) Also I suspect that 3dnow is useless for 99.999% of FLAC users. And not so useful for the rest 0.001%. 3) A lot of code in cpu.c that detects OS SSE support is inside unused branches of #ifdef/#else/#endif. USE_TRY_CATCH_FLAVOR was defined in Jan 2009, and USE_OBSOLETE_SIGCONTEXT_FLAVOR was undef'ed in Mar 2007. Is it a good idea to remove all that code, or it's too early yet?
lvqcl wrote:> Does it make sense to keep this code, then? Nobody managed to fix this > when it was timely, and now PPC (at least PPC for desktop use) is a > legacy platform. > > 2) Also I suspect that 3dnow is useless for 99.999% of FLAC users. > And not so useful for the rest 0.001%. > > 3) A lot of code in cpu.c that detects OS SSE support is inside unused > branches of #ifdef/#else/#endif. USE_TRY_CATCH_FLAVOR was defined in > Jan 2009, and USE_OBSOLETE_SIGCONTEXT_FLAVOR was undef'ed in Mar 2007. > > > > Is it a good idea to remove all that code, or it's too early yet?I think it should go. Would love to see a patch :-). Cheers, Erik -- ---------------------------------------------------------------------- Erik de Castro Lopo http://www.mega-nerd.com/
Erik de Castro Lopo wrote:> I think it should go. Would love to see a patch :-).During making a patch I found that PPC asm code wasn't disabled in Makefile.lite. Anybody uses it on Linux/Darwin PPC platform? I think I'll post a patch, anyway.