lvqcl wrrote:> ...more about PPC ASM: > http://git.xiph.org/?p=flac.git;a=commitdiff;h=63d489ae3140296419afdfc4cfc87cc2c7cb9faf > Does it mean that PowerPC/Altivec asm optimizations were disabled almost 10 years ago?Found the cause: http://lists.xiph.org/pipermail/flac-dev/2005-January/001696.html http://www.mail-archive.com/flac-dev at xiph.org/msg00104.html "Back in October 2004, I did a bit of work on FLAC to get version 1.1.1 to build correctly under GNU/Linux/PPC. Only now have I realised that somewhere along the way something broke in FLAC's decoding. On my machine, roughly 50% of FLAC files are being decoded incorrectly" -- John Steele Scott http://lists.xiph.org/pipermail/flac-dev/2005-January/001718.html "since it is going to take me a while to sort this out, and since we need to get a release out to fix the sonames problem, I have disabled PPC asm functions for now and will get back to it after the release. the static binaries I make for the darwin binary release will have them though, because it's easy for me to compile the right one" -- Josh Coalson I suspect that PPC/Altivec asm code is disabled for good.
lvqcl wrote:> Found the cause: > > http://lists.xiph.org/pipermail/flac-dev/2005-January/001696.html > http://www.mail-archive.com/flac-dev at xiph.org/msg00104.html > > "Back in October 2004, I did a bit of work on FLAC to get version 1.1.1 to > build correctly under GNU/Linux/PPC. Only now have I realised that somewhere > along the way something broke in FLAC's decoding. On my machine, roughly 50% > of FLAC files are being decoded incorrectly" -- John Steele Scott > > > http://lists.xiph.org/pipermail/flac-dev/2005-January/001718.html > > "since it is going to take me a while to sort this out, and since > we need to get a release out to fix the sonames problem, I have > disabled PPC asm functions for now and will get back to it after > the release. the static binaries I make for the darwin binary > release will have them though, because it's easy for me to > compile the right one" -- Josh Coalson > > > I suspect that PPC/Altivec asm code is disabled for good.I agree. Thanks for looking into this. Cheers, Erik -- ---------------------------------------------------------------------- Erik de Castro Lopo http://www.mega-nerd.com/
Erik de Castro Lopo wrote:>> I suspect that PPC/Altivec asm code is disabled for good. > > I agree.Does it make sense to keep this code, then? Nobody managed to fix this when it was timely, and now PPC (at least PPC for desktop use) is a legacy platform. 2) Also I suspect that 3dnow is useless for 99.999% of FLAC users. And not so useful for the rest 0.001%. 3) A lot of code in cpu.c that detects OS SSE support is inside unused branches of #ifdef/#else/#endif. USE_TRY_CATCH_FLAVOR was defined in Jan 2009, and USE_OBSOLETE_SIGCONTEXT_FLAVOR was undef'ed in Mar 2007. Is it a good idea to remove all that code, or it's too early yet?