Erik de Castro Lopo wrote:> That's a really good question. Haven't was already dropped support for > MSVC6? If so, we should drop this #ifdef hackery. Can test this without > the hackery for versions of MSVC > 6?I don't have VC 2002/2003, but the oldest Visual Studio that FLAC supports is MSVS 2005 anyway. It can compile FLAC__uint64 -> FLAC__double conversion without intermediate FLAC__int64. So this "spoon feed" isn't necessary. (found another place with this double conversion, inside src/utils/flactimer/main.cpp. It also has unnecessary #defines for int64_t/uint64_t)
lvqcl wrote:> I don't have VC 2002/2003, but the oldest Visual Studio that FLAC supports > is MSVS 2005 anyway. It can compile FLAC__uint64 -> FLAC__double conversion > without intermediate FLAC__int64. So this "spoon feed" isn't necessary. > > > (found another place with this double conversion, inside > src/utils/flactimer/main.cpp. It also has unnecessary #defines > for int64_t/uint64_t)Do you want to create a patch for this or should I? Erik -- ---------------------------------------------------------------------- Erik de Castro Lopo http://www.mega-nerd.com/
Erik de Castro Lopo wrote:> Do you want to create a patch for this or should I?I'll do it, it is MSVS-specific and I can test it on Visual Studio. But it will change src/libFLAC/stream_decoder.c, so it interferes with this patch: http://lists.xiph.org/pipermail/flac-dev/2014-July/004878.html Did you decide that those patches ain't worth applying? (I admit that they don't really solve any problem).