flac dev - Jul 2014 - Message about compression ratio with stdin input

Erik de Castro Lopo wrote:
>     INFO: Make sure you know what you're doing when using
--ignore-chunk-sizes.
>           Improper use can cause flac to encode non-audio data as audio.
>     -: WARNING: skipping unknown chunk 'LIST' (use
--keep-foreign-metadata to keep)
>     -: WARNING: 'data' chunk has non-zero size, using
--ignore-chunk-sizes is probably a bad idea
>     (No runtime statistics possible; please wait for encoding to finish...)
>     (No runtime statistics possible; please wait for encoding to finish...)
>     -: INFO: hit EOF with --ignore-chunk-sizes, got 148471808 samples
>     FAILURE: Compression failed (ratio 7742270.591, should be < 1.0).
>     This happens for some files for one or more of the following reasons:
>      * Recompressing an existing FLAC from a higher to a lower compression
setting.
>      * Insufficient input data  (eg, very short files, < 10000 frames).
>      * The audio data is not compressable (eg a full range white noise
signal).
>
> Removing the last four lines is easy but is it sufficient?


I tried myself to fix this message. How about the attached patch?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: encode.patch
Type: application/octet-stream
Size: 6733 bytes
Desc: not available
Url :
http://lists.xiph.org/pipermail/flac-dev/attachments/20140701/2961bd69/attachment.obj

lvqcl wrote:
> I tried myself to fix this message. How about the attached patch?

The second, shorter version of the patch is attached.
Not sure which is better.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: encode_v2.patch
Type: application/octet-stream
Size: 2444 bytes
Desc: not available
Url :
http://lists.xiph.org/pipermail/flac-dev/attachments/20140701/58ed8be9/attachment.obj

lvqcl wrote:
> lvqcl wrote:
> 
> > I tried myself to fix this message. How about the attached patch?
> 
> 
> The second, shorter version of the patch is attached.
> Not sure which is better.
I like this one. Applied.

Thanks,
Erik
-- 
----------------------------------------------------------------------
Erik de Castro Lopo
http://www.mega-nerd.com/