Martijn van Beurden wrote:> Like I reported just before the release of 1.3.0 (mail of Fri, > 05 Apr 2013 08:25:10 +0200, to be specific), compiling on > Raspbian (Debian Wheezy, GCC 4.6) returns quite some warnings of > the type -Wcast-align. > > > CC lpc_intrin_sse2.lo > > CC lpc_intrin_sse41.lo > > CC md5.lo > > md5.c: In function 'format_input_': > > md5.c:282:25: warning: cast increases required alignment of > > target type [-Wcast-align] > > md5.c:288:24: warning: cast increases required alignment of > > target type [-Wcast-align] > > CC memory.loDoes the test suite pass after you have compiled it?> One other issue that I've brought up before but hasn't been > fixed yet: none of the people that have contributed to FLAC in > the last few years (save Miroslav) are in the AUTHORS file :)I've pushed an update to that file. If anyone feels they or someone else has been left off that list, please let me know. Erik -- ---------------------------------------------------------------------- Erik de Castro Lopo http://www.mega-nerd.com/
op 27-06-14 12:26, Erik de Castro Lopo schreef:> Martijn van Beurden wrote: > >> Like I reported just before the release of 1.3.0 (mail of Fri, >> 05 Apr 2013 08:25:10 +0200, to be specific), compiling on >> Raspbian (Debian Wheezy, GCC 4.6) returns quite some warnings of >> the type -Wcast-align. >> >>> CC lpc_intrin_sse2.lo >>> CC lpc_intrin_sse41.lo >>> CC md5.lo >>> md5.c: In function 'format_input_': >>> md5.c:282:25: warning: cast increases required alignment of >>> target type [-Wcast-align] >>> md5.c:288:24: warning: cast increases required alignment of >>> target type [-Wcast-align] >>> CC memory.lo > Does the test suite pass after you have compiled it?Yes, it does. At least, make check does (with ./configure --disable-thorough-tests, as the thorough tests take more than a day on that ARM platform), make fullcheck is broken because of recent changes to the ReplayGain calculations, but that doesn't have anything to do with this platform.
Martijn van Beurden wrote:> op 27-06-14 12:26, Erik de Castro Lopo schreef: > > > Does the test suite pass after you have compiled it? > > Yes, it does. At least, make check does (with ./configure > --disable-thorough-tests, as the thorough tests take more than a > day on that ARM platform), make fullcheck is broken because of > recent changes to the ReplayGain calculations, but that doesn't > have anything to do with this platform.This suggests that the cast-align warning is warning that some ARM CPUs can't do un-aligned access, but the one you have can. I'm having a look at this issue. I can recreate the compiler warning by compiling in an armhf chroot. The problem in src/flac/decoder.c is probably easily fixable with the use of a union. The problem in src/libFLAC/md5.c is much less easily fixable. I'll see what I can do. Erik -- ---------------------------------------------------------------------- Erik de Castro Lopo http://www.mega-nerd.com/
Erik de Castro Lopo wrote:>> One other issue that I've brought up before but hasn't been >> fixed yet: none of the people that have contributed to FLAC in >> the last few years (save Miroslav) are in the AUTHORS file :) > > I've pushed an update to that file. If anyone feels they or > someone else has been left off that list, please let me know.There are two typos there: becamse -> became Optimisations -> Optimizations Also I think that it's better to use my SF mail: <lvqcl at users.sourceforge.net> PS: I thought that you became FLAC maintainer in 2012, not in 2014...
lvqcl wrote:> There are two typos there: > becamse -> becameFixed.> Optimisations -> OptimizationsThats the difference between British/Australian spelling and US spelling. Not worth fixing that. :-)> Also I think that it's better to use my SF mail: <lvqcl at users.sourceforge.net>Done!> PS: I thought that you became FLAC maintainer in 2012, not in 2014...Also fixed. Cheers, Erik -- ---------------------------------------------------------------------- Erik de Castro Lopo http://www.mega-nerd.com/