Hi Guys,
I've just faced a wrong warning trying to encode a 24 bits WAV file
if(wFormatTag == 1) {
if(bps != 8 && bps != 16) {
if(bps == 24 || bps == 32) {
/* let these slide with a warning since they're
unambiguous */
flac__utils_printf(stderr, 1, "%s: WARNING:
legacy WAVE file has format type %u but bits-per-sample=%u\n",
e->inbasefilename, (unsigned)wFormatTag, bps);
AFAIK only 32bits file require a format of 3 while it's fine for 8, 16
and 24bits
Thanks !
--
Olivier TRISTAN
uvi.net
Olivier Tristan wrote:> I've just faced a wrong warning trying to encode a 24 bits WAV file > > if(wFormatTag == 1) { > if(bps != 8 && bps != 16) { > if(bps == 24 || bps == 32) { > /* let these slide with a warning since they're > unambiguous */ > flac__utils_printf(stderr, 1, "%s: WARNING: > legacy WAVE file has format type %u but bits-per-sample=%u\n", > e->inbasefilename, (unsigned)wFormatTag, bps); > > AFAIK only 32bits file require a format of 3 while it's fine for 8, 16 > and 24bitsFLAC expects wFormatTag == 0xFFFE when bitdepth is not 8 or 16. See http://msdn.microsoft.com/en-us/library/windows/desktop/dd757713.aspx "If wFormatTag is WAVE_FORMAT_PCM, then wBitsPerSample should be equal to 8 or 16. [...] If wFormatTag is WAVE_FORMAT_EXTENSIBLE, this value can be any integer multiple of 8."
I never seen this before. Thanks a lot. Le 20/03/2014 16:45, lvqcl a ?crit :> Olivier Tristan wrote: > >> I've just faced a wrong warning trying to encode a 24 bits WAV file >> >> if(wFormatTag == 1) { >> if(bps != 8 && bps != 16) { >> if(bps == 24 || bps == 32) { >> /* let these slide with a warning since they're >> unambiguous */ >> flac__utils_printf(stderr, 1, "%s: WARNING: >> legacy WAVE file has format type %u but bits-per-sample=%u\n", >> e->inbasefilename, (unsigned)wFormatTag, bps); >> >> AFAIK only 32bits file require a format of 3 while it's fine for 8, 16 >> and 24bits > FLAC expects wFormatTag == 0xFFFE when bitdepth is not 8 or 16. > > See http://msdn.microsoft.com/en-us/library/windows/desktop/dd757713.aspx > > "If wFormatTag is WAVE_FORMAT_PCM, then wBitsPerSample should be equal to 8 or 16. > [...] > If wFormatTag is WAVE_FORMAT_EXTENSIBLE, this value can be any integer multiple of 8." > _______________________________________________ > flac-dev mailing list > flac-dev at xiph.org > http://lists.xiph.org/mailman/listinfo/flac-dev >-- Olivier TRISTAN uvi.net