flac dev - May 2013 - FLAC currently won't compile for Android [bisected]

Hi,

I couldn't figure out how to file a bug in the bugtracker at sourceforge.
So I send a report this way.

Building FLAC from git for Android fails with the following message:

utils.c: In function 'get_console_width':
utils.c:181:17: error: storage size of 'w' isn't known
utils.c:181:17: warning: unused variable 'w' [-Wunused-variable]
make[3]: *** [utils.o] Error


I have bisected the bug.

 03a9e6064d406e3656afacdbe50e8e47ebfa0de3 is the first bad commit
commit 03a9e6064d406e3656afacdbe50e8e47ebfa0de3
Author: Erik de Castro Lopo <erikd at mega-nerd.com>
Date:   Sun Apr 7 20:15:09 2013 +1000

    src/libFLAC/include/private/macros.h : Check GNUC version for MIN macro.

:040000 040000 b280a8ffb3737f3e50d2f9862bf93b1b925b27a7
327ba77b0b795650b24b254104d4639f427a7a5a M      src


See http://showlabor.blogspot.de on how to set up a build environment for
Android.

Regards,

Felix
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
http://lists.xiph.org/pipermail/flac-dev/attachments/20130515/f60913db/attachment.htm

Felix Homann wrote:
> utils.c: In function 'get_console_width':
> utils.c:181:17: error: storage size of 'w' isn't known
> utils.c:181:17: warning: unused variable 'w' [-Wunused-variable]
[That's apparently src/flac/utils.c.]

Strange thing. It looks like "struct winsize" isn't known anymore.
>  03a9e6064d406e3656afacdbe50e8e47ebfa0de3 is the first bad commit
-#if defined(__GNUC__)
+#if defined(__GNUC__) && (__GNUC__ > 4) && (__GNUC_MINOR__
> 4)

Arguably, this should have said ">= 4" at least for __GNUC__,
because
otherwise the condition will always be false (until a GCC 5.x is  
released). If sys/param.h is present, it causes that header to be  
included; if it is not present, it causes flac_max and flac_min to be  
undefined. (I guess that isn't intended either.) But I don't see how  
this causes the problem in src/flac/utils.c, which doesn't use any of  
MIN, MAX, flac_min, flac_max.

Felix, is HAVE_SYS_PARAM_H set or unset in an Android build? This  
information would eliminate one of the possibilities.

Ulrich

2013/5/15 Ulrich Klauer <ulrich at chirlu.de>
>
> Felix, is HAVE_SYS_PARAM_H set or unset in an Android build? This
> information would eliminate one of the possibilities.
>
> Ulrich
>
Yes, HAVE_SYS_PARAM_H is set in config.h:

#define HAVE_SYS_PARAM_H 1
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
http://lists.xiph.org/pipermail/flac-dev/attachments/20130515/380684b2/attachment.htm