Janne Hyv?rinen wrote:> I re-did the patch with these limitations. I also noticed I had left > stat() and fstat() functions unfixed previously. And encoder was limited > to 4G in many places when printing status info.Unfortunately, this patch did not apply cleanly. There were two problems; one in src/flac/main.c that was easy and obvious to fix, the other in include/share/compat.h. Can you please send your version of that file? Thanks, Erik -- ---------------------------------------------------------------------- Erik de Castro Lopo http://www.mega-nerd.com/
On 13.3.2013 12:17, Erik de Castro Lopo wrote:> Janne Hyv?rinen wrote: > >> I re-did the patch with these limitations. I also noticed I had left >> stat() and fstat() functions unfixed previously. And encoder was limited >> to 4G in many places when printing status info. > Unfortunately, this patch did not apply cleanly. > > There were two problems; one in src/flac/main.c that was easy and > obvious to fix, the other in include/share/compat.h. Can you please > send your version of that file? >The patch was made from the published pre2 version. It missed the MinGW changes that were applied to git version. -------------- next part -------------- A non-text attachment was scrubbed... Name: compat.zip Type: application/x-zip-compressed Size: 1903 bytes Desc: not available Url : http://lists.xiph.org/pipermail/flac-dev/attachments/20130313/2cd59782/attachment.bin
Janne Hyv?rinen wrote:> The patch was made from the published pre2 version. It missed the MinGW > changes that were applied to git version.And a couple of others. Usually better to go from the code that's actually in git. Anyway I have the code that you intended to sumbit. I will do a thorough review and test before committing. Thanks! Erik -- ---------------------------------------------------------------------- Erik de Castro Lopo http://www.mega-nerd.com/
Janne Hyv?rinen wrote:> The patch was made from the published pre2 version. It missed the MinGW > changes that were applied to git version.Patch applied. Thanks. Erik -- ---------------------------------------------------------------------- Erik de Castro Lopo http://www.mega-nerd.com/