Gentoo bundles flac 1.2.1 with numerous patches applied. Some of these patches are already included in upstream flac-dev (for example the gcc 4.3 cstring issue). Below are the patches supplied by Gentoo (merged against MASTER) and with the Changelog explanations of them as well as the discussion link surrounding the patch: *flac-9999-asm.patch:* *28 Sep 2007; Samuli Suominen <drac at gentoo.org>* +files/flac-1.2.1-asm.patch, Fix TEXTRELs using patch from PaX Team from bug 193222 and while at it, attempt to clean up ebuild a bit. Revert last commit restoring elibtoolize for fbsd since eautoreconf allready does libtoolize. *Gentoo bug where this is discussed:* *https://bugs.gentoo.org/show_bug.cgi?id=193222* * * *flac-9999-asneeded.patch* *20 Sep 2007; Samuli Suominen <drac at gentoo.org>* +files/flac-1.2.1-asneeded.patch, Version bump. *There isn't a bug detailing why this patch is here, but I believe it's to allow the --as-needed flag to the bfd linker. More information can be found here:* *http://www.gentoo.org/proj/en/qa/asneeded.xml* * * *flac-9999-ogg-m4.patch* *28 Mar 2011; Arun Raghavan <ford_prefect at gentoo.org>* +files/flac-1.2.1-ogg-m4.patch: Update the shipped version of ogg.m4 so that users of libflac don't get a ton of libtool warnings while linking. *There isn't a bug detailing why this patch is here, but the Changelog explanation is sufficient.* * * Thanks for taking a look! * * -- Jaren Stangret -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.xiph.org/pipermail/flac-dev/attachments/20120712/108fbe00/attachment.htm -------------- next part -------------- A non-text attachment was scrubbed... Name: flac-9999-asm.patch Type: application/octet-stream Size: 2843 bytes Desc: not available Url : http://lists.xiph.org/pipermail/flac-dev/attachments/20120712/108fbe00/attachment.obj -------------- next part -------------- A non-text attachment was scrubbed... Name: flac-9999-asneeded.patch Type: application/octet-stream Size: 769 bytes Desc: not available Url : http://lists.xiph.org/pipermail/flac-dev/attachments/20120712/108fbe00/attachment-0001.obj -------------- next part -------------- A non-text attachment was scrubbed... Name: flac-9999-ogg-m4.patch Type: application/octet-stream Size: 2851 bytes Desc: not available Url : http://lists.xiph.org/pipermail/flac-dev/attachments/20120712/108fbe00/attachment-0002.obj
Jaren Stangret wrote:> Gentoo bundles flac 1.2.1 with numerous patches applied. > > Some of these patches are already included in upstream flac-dev (for > example the gcc 4.3 cstring issue). > > Below are the patches supplied by Gentoo (merged against MASTER) and with > the Changelog explanations of them as well as the discussion link > surrounding the patch:Hi Jaren, Sorry for the delay on this. I am looking at it but found that I couldn't test the i386 assembler patches in an i386 chroot so I am now setting up an i386 VM. Cheers, Erik -- ---------------------------------------------------------------------- Erik de Castro Lopo http://www.mega-nerd.com/
Hi Jaren, Sorry for the delat dealing with these patches. Jaren Stangret wrote:> Below are the patches supplied by Gentoo (merged against MASTER) and with > the Changelog explanations of them as well as the discussion link > surrounding the patch:Unfortunately the Gentoo changelog explanations are a little lacking and very Gentoo specific.> > *flac-9999-asm.patch:* > *28 Sep 2007; Samuli Suominen <drac at gentoo.org>* > +files/flac-1.2.1-asm.patch, > Fix TEXTRELs using patch from PaX Team from bug 193222 and while at it, > attempt to clean up ebuild a bit. Revert last commit restoring elibtoolize > for fbsd since eautoreconf allready does libtoolize. > > *Gentoo bug where this is discussed:* > *https://bugs.gentoo.org/show_bug.cgi?id=193222*I followed those links and did some reading and came up with a commit message that made sense for FLAC.> *flac-9999-asneeded.patch* > *20 Sep 2007; Samuli Suominen <drac at gentoo.org>* > +files/flac-1.2.1-asneeded.patch, > Version bump. > > *There isn't a bug detailing why this patch is here, but I believe it's to > allow the --as-needed flag to the bfd linker. More information can be > found here:* > *http://www.gentoo.org/proj/en/qa/asneeded.xml*I've read all that and I still can't figure out why that patch is needed.> *flac-9999-ogg-m4.patch* > *28 Mar 2011; Arun Raghavan <ford_prefect at gentoo.org>* > +files/flac-1.2.1-ogg-m4.patch: > Update the shipped version of ogg.m4 so that users of libflac don't get a > ton of libtool warnings while linking.Same for that one. I am happy to take patches but I need information about what they do and why. Cheers, Erik -- ---------------------------------------------------------------------- Erik de Castro Lopo http://www.mega-nerd.com/
Hi Erik, I must also apologize for the delay. Thanks for taking the look at the patches. I'll have to look into why Gentoo has these patches. I mostly just grabbed and forwarded them onto you to help minimize the amount of patches needed for Gentoo's FLAC package. I'll ask around and see what happens. Thanks again. On Thu, Jul 26, 2012 at 3:30 PM, Erik de Castro Lopo <mle+la at mega-nerd.com>wrote:> Hi Jaren, > > Sorry for the delat dealing with these patches. > > Jaren Stangret wrote: > > > Below are the patches supplied by Gentoo (merged against MASTER) and with > > the Changelog explanations of them as well as the discussion link > > surrounding the patch: > > Unfortunately the Gentoo changelog explanations are a little lacking > and very Gentoo specific. > > > > > *flac-9999-asm.patch:* > > *28 Sep 2007; Samuli Suominen <drac at gentoo.org>* > > +files/flac-1.2.1-asm.patch, > > Fix TEXTRELs using patch from PaX Team from bug 193222 and while at it, > > attempt to clean up ebuild a bit. Revert last commit restoring > elibtoolize > > for fbsd since eautoreconf allready does libtoolize. > > > > *Gentoo bug where this is discussed:* > > *https://bugs.gentoo.org/show_bug.cgi?id=193222* > > I followed those links and did some reading and came up with a > commit message that made sense for FLAC. > > > *flac-9999-asneeded.patch* > > *20 Sep 2007; Samuli Suominen <drac at gentoo.org>* > > +files/flac-1.2.1-asneeded.patch, > > Version bump. > > > > *There isn't a bug detailing why this patch is here, but I believe it's > to > > allow the --as-needed flag to the bfd linker. More information can be > > found here:* > > *http://www.gentoo.org/proj/en/qa/asneeded.xml* > > I've read all that and I still can't figure out why that patch is > needed. > > > *flac-9999-ogg-m4.patch* > > *28 Mar 2011; Arun Raghavan <ford_prefect at gentoo.org>* > > +files/flac-1.2.1-ogg-m4.patch: > > Update the shipped version of ogg.m4 so that users of libflac don't > get a > > ton of libtool warnings while linking. > > Same for that one. > > I am happy to take patches but I need information about what they do > and why. > > Cheers, > Erik > -- > ---------------------------------------------------------------------- > Erik de Castro Lopo > http://www.mega-nerd.com/ > _______________________________________________ > flac-dev mailing list > flac-dev at xiph.org > http://lists.xiph.org/mailman/listinfo/flac-dev >-- Jaren Stangret Computer Science Engineering/Mathematics University Of Minnesota -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.xiph.org/pipermail/flac-dev/attachments/20120912/20209f3a/attachment.htm