Erik de Castro Lopo
2012-Apr-25 23:30 UTC
[flac-dev] Fix cuesheet.c to allow metaflac_test.sh to run to completion
Josh Coalson wrote:> I haven't checked git yet but I hope this patch has not gone in.? I > don't like the special case that this is creating. > > It would be better to allow MM:SS everywhere but I consider that low priority.I modified version of that patch did go in. See the following commits: https://git.xiph.org/?p=flac.git;a=commit;h=19050f74eaa1aa6d609ca065e1a854ada5bb6b4c https://git.xiph.org/?p=flac.git;a=commit;h=7ee908403e8be011b8a7dd3bf511408b40312c2e https://git.xiph.org/?p=flac.git;a=commit;h=ce8a75134cace056f6c436d54b57bad1a1d93797 Erik -- ---------------------------------------------------------------------- Erik de Castro Lopo http://www.mega-nerd.com/
Josh Coalson
2012-Apr-26 00:14 UTC
[flac-dev] Fix cuesheet.c to allow metaflac_test.sh to run to completion
> From: Erik de Castro Lopo <mle+la at mega-nerd.com> > To: flac-dev at xiph.org > Cc: Josh Coalson <xflac at yahoo.com> > Sent: Wednesday, April 25, 2012 4:30 PM > Subject: Re: [flac-dev] Fix cuesheet.c to allow metaflac_test.sh to run to completion > > Josh Coalson wrote: > >> I haven't checked git yet but I hope this patch has not gone in.? I >> don't like the special case that this is creating. >> >> It would be better to allow MM:SS everywhere but I consider that low > priority. > > I modified version of that patch did go in. See the following commits: > > https://git.xiph.org/?p=flac.git;a=commit;h=19050f74eaa1aa6d609ca065e1a854ada5bb6b4c > https://git.xiph.org/?p=flac.git;a=commit;h=7ee908403e8be011b8a7dd3bf511408b40312c2e > https://git.xiph.org/?p=flac.git;a=commit;h=ce8a75134cace056f6c436d54b57bad1a1d93797 > > > ErikI saw.? I like almost all the progress on recent patches but not this one.? Can it be backed out or replaced with proper MM:SS handling?
Erik de Castro Lopo
2012-Apr-26 00:50 UTC
[flac-dev] Fix cuesheet.c to allow metaflac_test.sh to run to completion
Josh Coalson wrote:> > From: Erik de Castro Lopo <mle+la at mega-nerd.com> > > To: flac-dev at xiph.org > > Cc: Josh Coalson <xflac at yahoo.com> > > Sent: Wednesday, April 25, 2012 4:30 PM > > Subject: Re: [flac-dev] Fix cuesheet.c to allow metaflac_test.sh to run to completion > > > > Josh Coalson wrote: > > > >> I haven't checked git yet but I hope this patch has not gone in.? I > >> don't like the special case that this is creating. > >> > >> It would be better to allow MM:SS everywhere but I consider that low > > priority. > > > > I modified version of that patch did go in. See the following commits: > > > > https://git.xiph.org/?p=flac.git;a=commit;h=19050f74eaa1aa6d609ca065e1a854ada5bb6b4c > > https://git.xiph.org/?p=flac.git;a=commit;h=7ee908403e8be011b8a7dd3bf511408b40312c2e > > https://git.xiph.org/?p=flac.git;a=commit;h=ce8a75134cace056f6c436d54b57bad1a1d93797 > > > > > > Erik > > I saw.? I like almost all the progress on recent patches but not this one.? Can it be > backed out or replaced with proper MM:SS handling?I really like the idea of fixing it with proper MM:SS handling. Erik -- ---------------------------------------------------------------------- Erik de Castro Lopo http://www.mega-nerd.com/