Hi all, I think we're getting close to the first FLAC release in over 4 years. I have tested whats currently in Git on x86, x86_64 and PowerPC Linux and would appreciate reports of successful compiles (and even more importantly any failures) on OSX, Windows and elsewhere. Cheers, Erik -- ---------------------------------------------------------------------- Erik de Castro Lopo http://www.mega-nerd.com/
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 26.02.2012 14:18, Erik de Castro Lopo wrote:> I ... would appreciate reports of successful compiles (and even > more importantly any failures) on ... Windows ... >1) I have to update automake version from 1.7 to 1.11. This might be fixable with installing automake-1.7 for mingw, but i haven't bothered with that, and i prefer 1.11 anyway (i also doubt that silent rules work with pre-1.11). 2) Compile-time warnings: f:/src/mingw-flac/flac-1.2.2-rc1/src/share/utf8/iconvert.c: In function 'iconvert': f:/src/mingw-flac/flac-1.2.2-rc1/src/share/utf8/iconvert.c:114:5: warning: passing argument 2 of 'libiconv' from incompatible pointer type [enabled by default] f:\mingw02\mingw-pc-i686\bin\../lib/gcc/mingw32/4.6.2/../../../../include/iconv.h:83:15: note: expected 'const char **' but argument is of type 'char **' f:/src/mingw-flac/flac-1.2.2-rc1/src/share/utf8/iconvert.c:175:5: warning: passing argument 2 of 'libiconv' from incompatible pointer type [enabled by default] f:\mingw02\mingw-pc-i686\bin\../lib/gcc/mingw32/4.6.2/../../../../include/iconv.h:83:15: note: expected 'const char **' but argument is of type 'char **' f:/src/mingw-flac/flac-1.2.2-rc1/src/share/utf8/iconvert.c:187:7: warning: passing argument 2 of 'libiconv' from incompatible pointer type [enabled by default] f:\mingw02\mingw-pc-i686\bin\../lib/gcc/mingw32/4.6.2/../../../../include/iconv.h:83:15: note: expected 'const char **' but argument is of type 'char **' f:/src/mingw-flac/flac-1.2.2-rc1/src/share/utf8/iconvert.c:210:5: warning: passing argument 2 of 'libiconv' from incompatible pointer type [enabled by default] f:\mingw02\mingw-pc-i686\bin\../lib/gcc/mingw32/4.6.2/../../../../include/iconv.h:83:15: note: expected 'const char **' but argument is of type 'char **' f:/src/mingw-flac/flac-1.2.2-rc1/src/share/utf8/iconvert.c:220:7: warning: passing argument 2 of 'libiconv' from incompatible pointer type [enabled by default] f:\mingw02\mingw-pc-i686\bin\../lib/gcc/mingw32/4.6.2/../../../../include/iconv.h:83:15: note: expected 'const char **' but argument is of type 'char **' f:/src/mingw-flac/flac-1.2.2-rc1/src/share/utf8/utf8.c: In function 'utf8_encode': f:/src/mingw-flac/flac-1.2.2-rc1/src/share/utf8/utf8.c:184:6: warning: pointer targets in assignment differ in signedness [-Wpointer-sign] f:/src/mingw-flac/flac-1.2.2-rc1/src/share/utf8/utf8.c: In function 'utf8_decode': f:/src/mingw-flac/flac-1.2.2-rc1/src/share/utf8/utf8.c:198:5: warning: pointer targets in passing argument 1 of 'make_unicode_string' differ in signedness [-Wpointer-sign] f:/src/mingw-flac/flac-1.2.2-rc1/src/share/utf8/utf8.c:95:17: note: expected 'const unsigned char *' but argument is of type 'const char *' 3) Test results: All tests passed MinGW buildscripts are attached, in case anyone needs them. -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (MingW32) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBAgAGBQJPSmMyAAoJEOs4Jb6SI2CwfF8H/jrFQTdpxtrM+wMXLMIeEd+W sVqtRUmkcWxGui/nsJTLXfauHEeRGrlNo4fle760wQjGiNmRkPJR4xVyUVX+UcS9 W3S+ydj1d4HBWW3JYZ/pwPlXZKhA5Vnq7OM4libTkmiQKqaIq2zIc+VrL30f5g7a IWLvD57htN/AKh2QxQ6RrhOle9WDi3W25/2ERwS/9duoiBZiX9S/0hxDtLTjTMXF urAgLK0HEcqu9BDfMCXxmFkMKUPNX1mOpLicNHvRaKC/IDU5KnP4D9ldUNy1OYfW 7Rp0+PewYbHcik61c0PR9xrQ79QFEZgAxsJ/XIAaURakpPAfXOIpDcehYFD93+A=jXWS -----END PGP SIGNATURE----- -------------- next part -------------- A non-text attachment was scrubbed... Name: flac-1.2.2-rc1-1-mingw32-bld.tar.xz Type: application/octet-stream Size: 3696 bytes Desc: not available Url : http://lists.xiph.org/pipermail/flac-dev/attachments/20120226/d985c0e2/attachment-0001.obj
On 02/26/12 02:18 am, Erik de Castro Lopo wrote:> Hi all, > > I think we're getting close to the first FLAC release in over 4 > years. > > I have tested whats currently in Git on x86, x86_64 and PowerPC > Linux and would appreciate reports of successful compiles (and even > more importantly any failures) on OSX, Windows and elsewhere.Hi, build dies here on OS/2 as aout is a very simple object format and doesn't support most types of .section. ... sh ../../../strip_non_asm_libtool_args.sh nasm -f aout -d OBJ_FORMAT_aout -i./ bitreader_asm.nasm -DDLL_EXPORT -DPIC -o .libs/bitreader_asm.o nasm -f aout -d OBJ_FORMAT_aout -i./ bitreader_asm.nasm -DDLL_EXPORT -o .libs/bitreader_asm.o nasm.h:77: error: segment name `.note.GNU-stack progbits noalloc noexec nowrite align=1' not recognized ... Wrapping the section with %ifndef OBJ_FORMAT_aout fixes it. There are also warnings about implicit declarations of _response() and _wildcard() fixed by including stdlib.h I also see the same iconv warnings as mingw. Couple of simple patches attached. Dave -------------- next part -------------- A non-text attachment was scrubbed... Name: 0001-a.out-format-does-not-support-many-.section-directiv.patch Type: application/x-patch Size: 620 bytes Desc: not available Url : http://lists.xiph.org/pipermail/flac-dev/attachments/20120226/e63cd568/attachment.bin -------------- next part -------------- A non-text attachment was scrubbed... Name: 0002-Include-stdlib.h-for-_response-and-_wildcard-declara.patch Type: application/x-patch Size: 619 bytes Desc: not available Url : http://lists.xiph.org/pipermail/flac-dev/attachments/20120226/e63cd568/attachment-0001.bin
Dave Yeo wrote:> Couple of simple patches attached.Patches applied. Thanks. Erik -- ---------------------------------------------------------------------- Erik de Castro Lopo http://www.mega-nerd.com/
LRN wrote:> f:/src/mingw-flac/flac-1.2.2-rc1/src/share/utf8/iconvert.c:175:5: > warning: passing argument 2 of 'libiconv' from incompatible pointer > type [enabled by default] > f:\mingw02\mingw-pc-i686\bin\../lib/gcc/mingw32/4.6.2/../../../../include/iconv.h:83:15: > note: expected 'const char **' but argument is of type 'char **'Firstly, what version of the mingw compiler are you using? This to me seems a big silly. From the error message I infer that the iconv function provided by mingw expects the argument to have type 'const char **' but the argument passed is of type 'char **'. However, it was my understanding that the C standard specified that conversions from 'char **' to 'const char **' should be allowed without warning. If you're interested in pursuing this please try changing line 175 of src/share/utf8/iconvert.c from: k = iconv(cd2, 0, 0, &ob, &obl); to: k = iconv(cd2, 0, 0, (const char**) &ob, &obl); and seeing if there is a warning with the replacement. Cheers, Erik -- ---------------------------------------------------------------------- Erik de Castro Lopo http://www.mega-nerd.com/
On 2/26/2012 2:18 AM, Erik de Castro Lopo wrote:> I have tested whats currently in Git on x86, x86_64 and PowerPC Linux > and would appreciate reports of successful compiles (and even more > importantly any failures) on OSX, Windows and elsewhere.On Cygwin, I had to use automake-1.9 to avoid this error: Generating configuration files for flac, please wait.... aclocal-1.7 -I m4 aclocal: macro `_LT_DECL_SED' required but not defined aclocal: macro `_LT_FUNC_STRIPNAME_CNF' required but not defined Other than that, it builds fine and all tests pass.