JonY wrote:> Looks like there are some missed defines in the test_libFLAC++. Attached > patch fixes that.Good one. Thanks.> Also, wsock32 usage is deprecated, on Win7, wsock32 forwards everything > to ws2_32, suggest changing to -lwsock32 to -lws2_32 in configure.ac. > Additionally, using -lwsock32 on Cygwin is wrong. Fix in config.txt.For that I think I'd prefer to purge all use of ntohl. Will make that a high priority. Erik -- ---------------------------------------------------------------------- Erik de Castro Lopo http://www.mega-nerd.com/
On 2/4/2012 17:45, Erik de Castro Lopo wrote:> JonY wrote: > >> Looks like there are some missed defines in the test_libFLAC++. Attached >> patch fixes that. > > Good one. Thanks. > >> Also, wsock32 usage is deprecated, on Win7, wsock32 forwards everything >> to ws2_32, suggest changing to -lwsock32 to -lws2_32 in configure.ac. >> Additionally, using -lwsock32 on Cygwin is wrong. Fix in config.txt. > > For that I think I'd prefer to purge all use of ntohl. Will make that > a high priority. > > ErikDoes AC_C_BIGENDIAN work well? I assume if a system is not big endian, its small endian. Are mid endian systems still around? -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 196 bytes Desc: OpenPGP digital signature Url : http://lists.xiph.org/pipermail/flac-dev/attachments/20120204/e9eb8f80/attachment.pgp
JonY wrote:> On 2/4/2012 17:45, Erik de Castro Lopo wrote: > > JonY wrote: > > > >> Looks like there are some missed defines in the test_libFLAC++. Attached > >> patch fixes that. > > > > Good one. Thanks. > > > >> Also, wsock32 usage is deprecated, on Win7, wsock32 forwards everything > >> to ws2_32, suggest changing to -lwsock32 to -lws2_32 in configure.ac. > >> Additionally, using -lwsock32 on Cygwin is wrong. Fix in config.txt. > > > > For that I think I'd prefer to purge all use of ntohl. Will make that > > a high priority.Just so you know, I have a patch to remove ntohl() in my queue.> Does AC_C_BIGENDIAN work well?Its ok, but I'll probably replace it with an m4 macro from libsndfile which is quite a bit better.> I assume if a system is not big endian, its small endian.Usually called little endian.> Are mid endian systems still around?I've not heard of one any time in the last 10 years. Erik -- ---------------------------------------------------------------------- Erik de Castro Lopo http://www.mega-nerd.com/