Erik de Castro Lopo
2012-Feb-02 18:50 UTC
[flac-dev] [Flac-dev] Git branch with compiling fixes for win32
JonY wrote:> Attached patch builds without any warnings for MinGW.Sorry JonY, that patch does not apply against current git master which is here: https://git.xiph.org/?p=flac.git;a=summary Specifically I pulled out much of the "#ifdef _MSC_VER" printf stuff in this commit: https://git.xiph.org/?p=flac.git;a=commit;h=ce8a75134cace056f6c436d54b57bad1a1d93797 For example (damn thats a horrible URL): https://git.xiph.org/?p=flac.git;a=blobdiff;f=examples/c/decode/file/main.c;h=e5138b4f9a08f0cf3e9a26c8ab68ac76d161785d;hp=32b555947d5c576693dbb6a9ee13a0a67582d96a;hb=ce8a75134cace056f6c436d54b57bad1a1d93797;hpb=8bbbf56403808ff75126cd0840a936aedbc4113b Since your patch seems pretty similar to what I have already commited, I wouldn't be surprised it what we have now doesn't just compile correctly under MinGW. Cheers, Erik -- ---------------------------------------------------------------------- Erik de Castro Lopo http://www.mega-nerd.com/
JonY
2012-Feb-02 22:33 UTC
[flac-dev] [Flac-dev] Git branch with compiling fixes for win32
On 2/3/2012 02:50, Erik de Castro Lopo wrote:> JonY wrote: > >> Attached patch builds without any warnings for MinGW. > > Sorry JonY, that patch does not apply against current git master > which is here: > > https://git.xiph.org/?p=flac.git;a=summary > > Specifically I pulled out much of the "#ifdef _MSC_VER" printf stuff > in this commit: > > https://git.xiph.org/?p=flac.git;a=commit;h=ce8a75134cace056f6c436d54b57bad1a1d93797 > > For example (damn thats a horrible URL): > > https://git.xiph.org/?p=flac.git;a=blobdiff;f=examples/c/decode/file/main.c;h=e5138b4f9a08f0cf3e9a26c8ab68ac76d161785d;hp=32b555947d5c576693dbb6a9ee13a0a67582d96a;hb=ce8a75134cace056f6c436d54b57bad1a1d93797;hpb=8bbbf56403808ff75126cd0840a936aedbc4113b > > Since your patch seems pretty similar to what I have already commited, > I wouldn't be surprised it what we have now doesn't just compile correctly > under MinGW.OK, will redo patch later today. My git repo still pointed to the old /mirrors/flac.git link, so I didn't get any updates. -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 196 bytes Desc: OpenPGP digital signature Url : http://lists.xiph.org/pipermail/flac-dev/attachments/20120203/ed175124/attachment.pgp
JonY
2012-Feb-04 00:59 UTC
[flac-dev] [Flac-dev] Git branch with compiling fixes for win32
On 2/3/2012 06:33, JonY wrote:> On 2/3/2012 02:50, Erik de Castro Lopo wrote: >> JonY wrote: >> >>> Attached patch builds without any warnings for MinGW. >> >> Sorry JonY, that patch does not apply against current git master >> which is here: >> >> https://git.xiph.org/?p=flac.git;a=summary >> >> Specifically I pulled out much of the "#ifdef _MSC_VER" printf stuff >> in this commit: >> >> https://git.xiph.org/?p=flac.git;a=commit;h=ce8a75134cace056f6c436d54b57bad1a1d93797 >> >> For example (damn thats a horrible URL): >> >> https://git.xiph.org/?p=flac.git;a=blobdiff;f=examples/c/decode/file/main.c;h=e5138b4f9a08f0cf3e9a26c8ab68ac76d161785d;hp=32b555947d5c576693dbb6a9ee13a0a67582d96a;hb=ce8a75134cace056f6c436d54b57bad1a1d93797;hpb=8bbbf56403808ff75126cd0840a936aedbc4113b >> >> Since your patch seems pretty similar to what I have already commited, >> I wouldn't be surprised it what we have now doesn't just compile correctly >> under MinGW. > > OK, will redo patch later today. My git repo still pointed to the old > /mirrors/flac.git link, so I didn't get any updates. > >OK, rebuilt with latest master, no more printf warnings. Here's another attached patch to suppress redefinition warnings with mingw-w64 lfs64 support. -------------- next part -------------- An embedded and charset-unspecified text was scrubbed... Name: fseek.txt Url: http://lists.xiph.org/pipermail/flac-dev/attachments/20120204/54563883/attachment.txt -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 196 bytes Desc: OpenPGP digital signature Url : http://lists.xiph.org/pipermail/flac-dev/attachments/20120204/54563883/attachment.pgp