Hello, The attached patch fixes a typo in md5.c, where a memset is used to clear the digest, but only ends up clearing parts of it due to a missing dereference operator. Would it be possible to get this applied? It is not fixing a serious bug, but this warning comes up in the Chromium build, and fixing it would make the build one bit less noisy. Thanks, Hans -------------- next part -------------- A non-text attachment was scrubbed... Name: libflac-md5.patch Type: text/x-patch Size: 577 bytes Desc: not available Url : http://lists.xiph.org/pipermail/flac-dev/attachments/20120130/cb8e70f0/attachment.bin
Hans Wennborg wrote:> The attached patch fixes a typo in md5.c, where a memset is used to > clear the digest, but only ends up clearing parts of it due to a > missing dereference operator. > > Would it be possible to get this applied?This has already been fixed in the git repo: http://git.xiph.org/?p=flac.git;a=commit;h=19e3918d4e35f4ab99e7fcc58c169025c576dd16 Cheers, Erik -- ---------------------------------------------------------------------- Erik de Castro Lopo http://www.mega-nerd.com/
On Tue, Jan 31, 2012 at 6:52 AM, Erik de Castro Lopo <mle+la at mega-nerd.com> wrote:> Hans Wennborg wrote: > >> The attached patch fixes a typo in md5.c, where a memset is used to >> clear the digest, but only ends up clearing parts of it due to a >> missing dereference operator. >> >> Would it be possible to get this applied? > > This has already been fixed in the git repo: > > ? ?http://git.xiph.org/?p=flac.git;a=commit;h=19e3918d4e35f4ab99e7fcc58c169025c576dd16 > > Cheers, > ErikAre there any plans to make a new release? We are currently using 1.2.1. If there were to be a new release, we would wait for that, otherwise we will probably just apply this locally. Thanks, Hans