On Sat, Nov 11, 2006 at 03:03:12PM -0800, Josh Coalson wrote:> ok, checked in some fixes that should take care of most of the > warnings.Nice! Current complete set of warnings: replaygain.c: In function 'parse_double_': replaygain.c:612: warning: comparison between signed and unsigned replaygain.c:612: warning: signed and unsigned type in conditional expression encode.c:2686: warning: 'limit_channel_mask' defined but not used There are lots of minor differences in the 'make check' output, but two tests still fail. -r
--- Ralph Giles <giles@xiph.org> wrote:> On Sat, Nov 11, 2006 at 03:03:12PM -0800, Josh Coalson wrote: > > > ok, checked in some fixes that should take care of most of the > > warnings. > > Nice! Current complete set of warnings: > > replaygain.c: In function 'parse_double_': > replaygain.c:612: warning: comparison between signed and unsigned > replaygain.c:612: warning: signed and unsigned type in conditional > expression > encode.c:2686: warning: 'limit_channel_mask' defined but not used > > There are lots of minor differences in the 'make check' output, but > two tests still fail.yeah, I'm pretty sure from looking at the log that the only problem is caused by the vendor string. if you change it to "reference libFLAC 1.1.3 20061120" in src/libFLAC/format.c they should all pass. Josh ____________________________________________________________________________________ Do you Yahoo!? Everyone is raving about the all-new Yahoo! Mail beta. http://new.mail.yahoo.com
--- Ralph Giles <giles@xiph.org> wrote:> On Sat, Nov 11, 2006 at 03:03:12PM -0800, Josh Coalson wrote: > > > ok, checked in some fixes that should take care of most of the > > warnings. > > Nice! Current complete set of warnings: > > replaygain.c: In function 'parse_double_': > replaygain.c:612: warning: comparison between signed and unsigned > replaygain.c:612: warning: signed and unsigned type in conditional > expression > encode.c:2686: warning: 'limit_channel_mask' defined but not used > > There are lots of minor differences in the 'make check' output, but > two > tests still fail.OK, I built on one of the sourceforge machines and made a bunch more fixes. there are a couple innocuous warnings but the tests all pass for me. I also checked in changes to the vendor string, can you try one more time now? thanks, Josh ____________________________________________________________________________________ Sponsored Link Degrees online in as fast as 1 Yr MBA, Bachelor's, Master's, Assoc http://yahoo.degrees.info
On Fri, Nov 17, 2006 at 08:32:02AM -0800, Josh Coalson wrote:> OK, I built on one of the sourceforge machines and made a bunch > more fixes. there are a couple innocuous warnings but the tests > all pass for me. I also checked in changes to the vendor string, > can you try one more time now?Yep, all 7 tests pass now. Yay! Attached is an autogen integration patch: (a) pass -I m4 to aclocal (b) set a minimum automake version of 1.7 Both are required to build out of cvs on my Ubuntu system. Cheers, -r -------------- next part -------------- Index: Makefile.am ==================================================================RCS file: /cvsroot/flac/flac/Makefile.am,v retrieving revision 1.26 diff -u -r1.26 Makefile.am --- Makefile.am 25 Apr 2006 06:59:33 -0000 1.26 +++ Makefile.am 17 Nov 2006 22:54:13 -0000 @@ -28,6 +28,8 @@ # distclean: remove everything except what goes in the distribution # +AUTOMAKE_OPTIONS = 1.7 + SUBDIRS = doc include man src test build flac.pbproj obj DISTCLEANFILES = libtool-disable-static Index: autogen.sh ==================================================================RCS file: /cvsroot/flac/flac/autogen.sh,v retrieving revision 1.14 diff -u -r1.14 autogen.sh --- autogen.sh 17 Nov 2006 06:50:19 -0000 1.14 +++ autogen.sh 17 Nov 2006 22:54:13 -0000 @@ -11,6 +11,8 @@ cd "$srcdir" DIE=0 +ACLOCAL_FLAGS="-I m4 $ACLOCAL_FLAGS" + echo "checking for autoconf... " (autoconf --version) < /dev/null > /dev/null 2>&1 || { echo