On Thu, Sep 12, 2002 at 10:54:04PM +0200, Miroslav Lichvar wrote:> I tried tagging using metaflac with some iso-8859-2 chars, but these > chars were replaced by '#' chars, something wrong is here.Ok, here is simple patch, it works for me, but I'm not familiar with this stuff. BTW, metaflac --list prints comments in raw utf8, it can screw terminal easily. -- Miroslav Lichvar -------------- next part -------------- --- src/metaflac/main.c.orig 2002-09-12 23:44:54.000000000 +0200 +++ src/metaflac/main.c 2002-09-12 23:59:10.000000000 +0200 @@ -33,6 +33,7 @@ #include <stdio.h> #include <stdlib.h> #include <string.h> +#include <locale.h> #if 0 /*[JEC] was:#if HAVE_GETOPT_LONG*/ @@ -308,6 +309,7 @@ CommandLineOptions options; int ret = 0; + setlocale(LC_ALL, ""); init_options(&options); if(parse_options(argc, argv, &options))
--- Miroslav Lichvar <lichvarm@phoenix.inf.upol.cz> wrote:> On Thu, Sep 12, 2002 at 10:54:04PM +0200, Miroslav Lichvar wrote: > > I tried tagging using metaflac with some iso-8859-2 chars, but > these > > chars were replaced by '#' chars, something wrong is here. > > Ok, here is simple patch, it works for me, but I'm not familiar with > this stuff.committed.> BTW, metaflac --list prints comments in raw utf8, it can screw > terminal easily.thanks, fixed this too. Miroslav, can you try the latest src/metaflac/main.c from CVS to see if it fixes the problem? thanks, Josh http://cvs.sourceforge.net/cgi-bin/viewcvs.cgi/*checkout*/flac/flac/src/metaflac/main.c?rev=1.44 __________________________________________________ Do you Yahoo!? Yahoo! News - Today's headlines http://news.yahoo.com
On Mon, Sep 16, 2002 at 10:54:16PM -0700, Josh Coalson wrote:> --- Miroslav Lichvar <lichvarm@phoenix.inf.upol.cz> wrote: > > On Thu, Sep 12, 2002 at 10:54:04PM +0200, Miroslav Lichvar wrote: > > > I tried tagging using metaflac with some iso-8859-2 chars, but > > these > > > chars were replaced by '#' chars, something wrong is here. > > > > Ok, here is simple patch, it works for me, but I'm not familiar with > > this stuff. > > committed. > > > BTW, metaflac --list prints comments in raw utf8, it can screw > > terminal easily. > > thanks, fixed this too. > > Miroslav, can you try the latest src/metaflac/main.c from CVS to > see if it fixes the problem? thanks,OK, it is fixed. -- Miroslav Lichvar