Fedora xen - Oct 2009 - Fedora xen-3.4.1-5 bugfixes / [Xen-devel] [PATCH 0 of 12] backport critical fixes from qemu upstream

Hello,

Gerd: The earlier qemu mem leak patch should be dropped, and these
fixes applied instead.

These patches are committed to qemu-xen-unstable, and can also be found from
xen-devel archives:

"[Xen-devel] [PATCH 0 of 12] backport critical fixes from qemu
upstream":
http://lists.xensource.com/archives/html/xen-devel/2009-10/msg00155.html
http://lists.xensource.com/archives/html/xen-devel/2009-10/msg00156.html
http://lists.xensource.com/archives/html/xen-devel/2009-10/msg00157.html
http://lists.xensource.com/archives/html/xen-devel/2009-10/msg00158.html
http://lists.xensource.com/archives/html/xen-devel/2009-10/msg00159.html
http://lists.xensource.com/archives/html/xen-devel/2009-10/msg00160.html
http://lists.xensource.com/archives/html/xen-devel/2009-10/msg00161.html
http://lists.xensource.com/archives/html/xen-devel/2009-10/msg00162.html
http://lists.xensource.com/archives/html/xen-devel/2009-10/msg00163.html
http://lists.xensource.com/archives/html/xen-devel/2009-10/msg00164.html
http://lists.xensource.com/archives/html/xen-devel/2009-10/msg00165.html
http://lists.xensource.com/archives/html/xen-devel/2009-10/msg00166.html

-- Pasi

----- Forwarded message from Stefano Stabellini
<stefano.stabellini@eu.citrix.com> -----

From: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
To: xen-devel@lists.xensource.com
Cc: Ian Jackson <Ian.Jackson@eu.citrix.com>
Date: Mon, 5 Oct 2009 14:40:35 +0100
Subject: [Xen-devel] [PATCH 0 of 12] backport critical fixes from qemu
	upstream

Hi all,
the current qemu block layer contains few critical problems, one of them
was fixed by "fix qemu memory leak in block interface" but
unfortunately
others remain.
In particular every time the guest cancels a dma request qemu
segfaults.
In order to completely fix any remaining bug I suggest to revert the
previous fix "fix qemu memory leak in block interface" and backport
instead the following changesets from qemu upstream:

6bbff9a0b495918309074ac60375be5f9dc868b3 # Refactor aio callback allocation to
use an aiocb pool (Avi Kivity)
c07a9008ac6985cd5a15909c2b9977d982defc12 # Convert vectored aio emulation to use
a dedicated pool (Avi Kivity)
6512a2a7106480c19183d6466a6845bc9bdf6ec0 # Implement cancellation method for dma
async I/O (Avi Kivity)
3fb94d56c6adc96ffc4a81b58c752cc4ccfae39c # Use vectored aiocb storage to store
vector translation state (Avi Kivity)
37b7842c2fb405c270efdce714425c17af3c78cd # Move block dma helpers aiocb to store
dma state (Avi Kivity)
c240b9af599d20e06a58090366be682684bd8555 # Fix vectored aio bounce handling
immediate errors (Avi Kivity)
7403b14eeb4670d54497284b110ca3e3be4a99a4 # Fix DMA API when handling an
immediate error from block layer (Avi Kivity)
081501daceca74d2091e798d5dcd342c14d66d1a # check for bs->drv in bdrv_flush
(Christoph Hellwig)
fbb7b4e0804d2168f24142eebf7552adde1968dc # Improve block range checks
6a7ad2998ca47711eddd191caa1a95f14459793f # Call qemu_bh_delete at
bdrv_aio_bh_cb.
36afc451599175eb8f03f1962de74e7f7a8af4db # block: Clean up after deleting BHs

The same should be done to qemu-xen-3.4-testing as well.
Cheers,

Stefano

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

----- End forwarded message -----

On Fri, Oct 09, 2009 at 01:06:53PM +0300, Pasi Kärkkäinen
wrote:
> Hello,
> 
> Gerd: The earlier qemu mem leak patch should be dropped, and these
> fixes applied instead.
> 
Or well, to xen-3.4.1-6, since -5 was already built with other fixes.

-- Pasi
> These patches are committed to qemu-xen-unstable, and can also be found
from
> xen-devel archives:
> 
> "[Xen-devel] [PATCH 0 of 12] backport critical fixes from qemu
upstream":
> http://lists.xensource.com/archives/html/xen-devel/2009-10/msg00155.html
> http://lists.xensource.com/archives/html/xen-devel/2009-10/msg00156.html
> http://lists.xensource.com/archives/html/xen-devel/2009-10/msg00157.html
> http://lists.xensource.com/archives/html/xen-devel/2009-10/msg00158.html
> http://lists.xensource.com/archives/html/xen-devel/2009-10/msg00159.html
> http://lists.xensource.com/archives/html/xen-devel/2009-10/msg00160.html
> http://lists.xensource.com/archives/html/xen-devel/2009-10/msg00161.html
> http://lists.xensource.com/archives/html/xen-devel/2009-10/msg00162.html
> http://lists.xensource.com/archives/html/xen-devel/2009-10/msg00163.html
> http://lists.xensource.com/archives/html/xen-devel/2009-10/msg00164.html
> http://lists.xensource.com/archives/html/xen-devel/2009-10/msg00165.html
> http://lists.xensource.com/archives/html/xen-devel/2009-10/msg00166.html
> 
> -- Pasi
> 
> ----- Forwarded message from Stefano Stabellini
<stefano.stabellini@eu.citrix.com> -----
> 
> From: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
> To: xen-devel@lists.xensource.com
> Cc: Ian Jackson <Ian.Jackson@eu.citrix.com>
> Date: Mon, 5 Oct 2009 14:40:35 +0100
> Subject: [Xen-devel] [PATCH 0 of 12] backport critical fixes from qemu
> 	upstream
> 
> Hi all,
> the current qemu block layer contains few critical problems, one of them
> was fixed by "fix qemu memory leak in block interface" but
unfortunately
> others remain.
> In particular every time the guest cancels a dma request qemu
> segfaults.
> In order to completely fix any remaining bug I suggest to revert the
> previous fix "fix qemu memory leak in block interface" and
backport
> instead the following changesets from qemu upstream:
> 
> 6bbff9a0b495918309074ac60375be5f9dc868b3 # Refactor aio callback allocation
to use an aiocb pool (Avi Kivity)
> c07a9008ac6985cd5a15909c2b9977d982defc12 # Convert vectored aio emulation
to use a dedicated pool (Avi Kivity)
> 6512a2a7106480c19183d6466a6845bc9bdf6ec0 # Implement cancellation method
for dma async I/O (Avi Kivity)
> 3fb94d56c6adc96ffc4a81b58c752cc4ccfae39c # Use vectored aiocb storage to
store vector translation state (Avi Kivity)
> 37b7842c2fb405c270efdce714425c17af3c78cd # Move block dma helpers aiocb to
store dma state (Avi Kivity)
> c240b9af599d20e06a58090366be682684bd8555 # Fix vectored aio bounce handling
immediate errors (Avi Kivity)
> 7403b14eeb4670d54497284b110ca3e3be4a99a4 # Fix DMA API when handling an
immediate error from block layer (Avi Kivity)
> 081501daceca74d2091e798d5dcd342c14d66d1a # check for bs->drv in
bdrv_flush (Christoph Hellwig)
> fbb7b4e0804d2168f24142eebf7552adde1968dc # Improve block range checks
> 6a7ad2998ca47711eddd191caa1a95f14459793f # Call qemu_bh_delete at
bdrv_aio_bh_cb.
> 36afc451599175eb8f03f1962de74e7f7a8af4db # block: Clean up after deleting
BHs
> 
> The same should be done to qemu-xen-3.4-testing as well.
> Cheers,
> 
> Stefano
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel
> 
> ----- End forwarded message -----
> 
> --
> Fedora-xen mailing list
> Fedora-xen@redhat.com
> https://www.redhat.com/mailman/listinfo/fedora-xen

On Sun, Oct 11, 2009 at 12:35:25AM +0300, Pasi Kärkkäinen
wrote:
> On Fri, Oct 09, 2009 at 01:06:53PM +0300, Pasi Kärkkäinen wrote:
> > Hello,
> > 
> > Gerd: The earlier qemu mem leak patch should be dropped, and these
> > fixes applied instead.
> > 
> 
> Or well, to xen-3.4.1-6, since -5 was already built with other fixes.
> 
Actually it seems there are still memleak issues with these patches, so
better wait a while until the issue is properly fixed..

-- Pasi
> 
> > These patches are committed to qemu-xen-unstable, and can also be
found from
> > xen-devel archives:
> > 
> > "[Xen-devel] [PATCH 0 of 12] backport critical fixes from qemu
upstream":
> >
http://lists.xensource.com/archives/html/xen-devel/2009-10/msg00155.html
> >
http://lists.xensource.com/archives/html/xen-devel/2009-10/msg00156.html
> >
http://lists.xensource.com/archives/html/xen-devel/2009-10/msg00157.html
> >
http://lists.xensource.com/archives/html/xen-devel/2009-10/msg00158.html
> >
http://lists.xensource.com/archives/html/xen-devel/2009-10/msg00159.html
> >
http://lists.xensource.com/archives/html/xen-devel/2009-10/msg00160.html
> >
http://lists.xensource.com/archives/html/xen-devel/2009-10/msg00161.html
> >
http://lists.xensource.com/archives/html/xen-devel/2009-10/msg00162.html
> >
http://lists.xensource.com/archives/html/xen-devel/2009-10/msg00163.html
> >
http://lists.xensource.com/archives/html/xen-devel/2009-10/msg00164.html
> >
http://lists.xensource.com/archives/html/xen-devel/2009-10/msg00165.html
> >
http://lists.xensource.com/archives/html/xen-devel/2009-10/msg00166.html
> > 
> > -- Pasi
> > 
> > ----- Forwarded message from Stefano Stabellini
<stefano.stabellini@eu.citrix.com> -----
> > 
> > From: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
> > To: xen-devel@lists.xensource.com
> > Cc: Ian Jackson <Ian.Jackson@eu.citrix.com>
> > Date: Mon, 5 Oct 2009 14:40:35 +0100
> > Subject: [Xen-devel] [PATCH 0 of 12] backport critical fixes from qemu
> > 	upstream
> > 
> > Hi all,
> > the current qemu block layer contains few critical problems, one of
them
> > was fixed by "fix qemu memory leak in block interface" but
unfortunately
> > others remain.
> > In particular every time the guest cancels a dma request qemu
> > segfaults.
> > In order to completely fix any remaining bug I suggest to revert the
> > previous fix "fix qemu memory leak in block interface" and
backport
> > instead the following changesets from qemu upstream:
> > 
> > 6bbff9a0b495918309074ac60375be5f9dc868b3 # Refactor aio callback
allocation to use an aiocb pool (Avi Kivity)
> > c07a9008ac6985cd5a15909c2b9977d982defc12 # Convert vectored aio
emulation to use a dedicated pool (Avi Kivity)
> > 6512a2a7106480c19183d6466a6845bc9bdf6ec0 # Implement cancellation
method for dma async I/O (Avi Kivity)
> > 3fb94d56c6adc96ffc4a81b58c752cc4ccfae39c # Use vectored aiocb storage
to store vector translation state (Avi Kivity)
> > 37b7842c2fb405c270efdce714425c17af3c78cd # Move block dma helpers
aiocb to store dma state (Avi Kivity)
> > c240b9af599d20e06a58090366be682684bd8555 # Fix vectored aio bounce
handling immediate errors (Avi Kivity)
> > 7403b14eeb4670d54497284b110ca3e3be4a99a4 # Fix DMA API when handling
an immediate error from block layer (Avi Kivity)
> > 081501daceca74d2091e798d5dcd342c14d66d1a # check for bs->drv in
bdrv_flush (Christoph Hellwig)
> > fbb7b4e0804d2168f24142eebf7552adde1968dc # Improve block range checks
> > 6a7ad2998ca47711eddd191caa1a95f14459793f # Call qemu_bh_delete at
bdrv_aio_bh_cb.
> > 36afc451599175eb8f03f1962de74e7f7a8af4db # block: Clean up after
deleting BHs
> > 
> > The same should be done to qemu-xen-3.4-testing as well.
> > Cheers,
> > 
> > Stefano
> > 
> > _______________________________________________
> > Xen-devel mailing list
> > Xen-devel@lists.xensource.com
> > http://lists.xensource.com/xen-devel
> > 
> > ----- End forwarded message -----
> > 
> > --
> > Fedora-xen mailing list
> > Fedora-xen@redhat.com
> > https://www.redhat.com/mailman/listinfo/fedora-xen
> 
> --
> Fedora-xen mailing list
> Fedora-xen@redhat.com
> https://www.redhat.com/mailman/listinfo/fedora-xen