https://bugzilla.redhat.com/show_bug.cgi?id=427311 The kernel does not use CONFIG_MODULE_SRCVERSION_ALL=y, which prevents modules that don''t use MODULE_VERSION() tags from getting a srcversion field in their modinfo. DKMS uses the srcversion field to determine if a module is exactly the same or not. It would benefit from having srcversion enabled for all modules. Ubuntu and openSUSE enable this option. Thanks, Matt -- Matt Domsch Linux Technology Strategist, Dell Office of the CTO linux.dell.com & www.dell.com/linux
On Sat, Feb 16, 2008 at 09:55:04AM -0600, Matt Domsch wrote:> https://bugzilla.redhat.com/show_bug.cgi?id=427311 > > The kernel does not use CONFIG_MODULE_SRCVERSION_ALL=y, which prevents > modules that don''t use MODULE_VERSION() tags from getting a srcversion > field in their modinfo. DKMS uses the srcversion field to determine > if a module is exactly the same or not. It would benefit from having > srcversion enabled for all modules. Ubuntu and openSUSE enable this > option.Just reminding folks of this request. -- Matt Domsch Linux Technology Strategist, Dell Office of the CTO linux.dell.com & www.dell.com/linux
On Tuesday 18 March 2008 10:10:17 pm Matt Domsch wrote:> On Sat, Feb 16, 2008 at 09:55:04AM -0600, Matt Domsch wrote: > > https://bugzilla.redhat.com/show_bug.cgi?id=427311 > > > > The kernel does not use CONFIG_MODULE_SRCVERSION_ALL=y, which prevents > > modules that don''t use MODULE_VERSION() tags from getting a srcversion > > field in their modinfo. DKMS uses the srcversion field to determine > > if a module is exactly the same or not. It would benefit from having > > srcversion enabled for all modules. Ubuntu and openSUSE enable this > > option. > > Just reminding folks of this request.Doesn''t look like it''ll cause us any problems, so... Following the ''its easier to ask for forgiveness than to ask for permission'' paradigm, I just flipped it on in rawhide, so next build spit out of koji will have it, barring someone beating me with a cluebat and turning it back off... :) -- Jarod Wilson jwilson@redhat.com
On Tue, Mar 18, 2008 at 11:31:29PM -0400, Jarod Wilson wrote:> On Tuesday 18 March 2008 10:10:17 pm Matt Domsch wrote: > > On Sat, Feb 16, 2008 at 09:55:04AM -0600, Matt Domsch wrote: > > > https://bugzilla.redhat.com/show_bug.cgi?id=427311 > > > > > > The kernel does not use CONFIG_MODULE_SRCVERSION_ALL=y, which prevents > > > modules that don''t use MODULE_VERSION() tags from getting a srcversion > > > field in their modinfo. DKMS uses the srcversion field to determine > > > if a module is exactly the same or not. It would benefit from having > > > srcversion enabled for all modules. Ubuntu and openSUSE enable this > > > option. > > > > Just reminding folks of this request. > > Doesn''t look like it''ll cause us any problems, so... Following the ''its easier > to ask for forgiveness than to ask for permission'' paradigm, I just flipped > it on in rawhide, so next build spit out of koji will have it, barring > someone beating me with a cluebat and turning it back off... :)Thanks, this looks good. $ modinfo edd filename: /lib/modules/2.6.25-0.136.rc6.git5.fc9/kernel/drivers/firmware/edd.ko version: 0.16 license: GPL description: sysfs interface to BIOS EDD information author: Matt Domsch <Matt_Domsch@Dell.com> srcversion: 34DFC3792D5426081F1EA10 depends: vermagic: 2.6.25-0.136.rc6.git5.fc9 SMP mod_unload -- Matt Domsch Linux Technology Strategist, Dell Office of the CTO linux.dell.com & www.dell.com/linux