Facebooker talk - Jul 2008 - Changed to url_rewriting for new facebook profile

I noticed that the change for correct support for url_rewriting uses

@request.parameters["fb_sig_in_new_facebook"] == "1"

But the rest of the code relies on ENV["FACEBOOKER_NEW_API"] --- any
reason
for these not being in sync?

That change is difficult for me to merge into the Adapter based facebooker
fork?

Plus:

Is anyone up for testing out the Adapter branch I emailed about last week? I
really want to get it into the main branch, I am running in production
without any issues at this point, Bebo and Facebook running side by side.
You don''t need to be on Bebo to test it out.


Dave
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://rubyforge.org/pipermail/facebooker-talk/attachments/20080715/fd21f6a7/attachment.html>

One other thing about this change.

The test in RailsIntegrationTest is in with the tests for non facebook
controllers.  I had to move it to use a Facebook Authenticated controller in
order to get my adaptation of it to work,  is this an oversight?  Or should
this test cover Non facebook controllers?

Dave

On Tue, Jul 15, 2008 at 5:11 PM, David Clements <digidigo at gmail.com>
wrote:
> I noticed that the change for correct support for url_rewriting uses
>
> @request.parameters["fb_sig_in_new_facebook"] == "1"
>
> But the rest of the code relies on ENV["FACEBOOKER_NEW_API"] ---
any reason
> for these not being in sync?
>
> That change is difficult for me to merge into the Adapter based facebooker
> fork?
>
> Plus:
>
> Is anyone up for testing out the Adapter branch I emailed about last week?
> I really want to get it into the main branch, I am running in production
> without any issues at this point, Bebo and Facebook running side by side.
> You don''t need to be on Bebo to test it out.
>
>
> Dave
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://rubyforge.org/pipermail/facebooker-talk/attachments/20080715/43f7fdee/attachment.html>

No reason that I can think of. I just merged your adapter changes.  
Thanks for doing them!

Mike


On Jul 15, 2008, at 7:11 PM, David Clements wrote:
> I noticed that the change for correct support for url_rewriting uses
>
> @request.parameters["fb_sig_in_new_facebook"] == "1"
>
> But the rest of the code relies on ENV["FACEBOOKER_NEW_API"] ---
any
> reason for these not being in sync?
>
> That change is difficult for me to merge into the Adapter based  
> facebooker fork?
>
> Plus:
>
> Is anyone up for testing out the Adapter branch I emailed about last  
> week? I really want to get it into the main branch, I am running in  
> production without any issues at this point, Bebo and Facebook  
> running side by side.  You don''t need to be on Bebo to test it
out.
>
>
> Dave
>
> _______________________________________________
> Facebooker-talk mailing list
> Facebooker-talk at rubyforge.org
> http://rubyforge.org/mailman/listinfo/facebooker-talk
--
Mike Mangino
http://www.elevatedrails.com