dtrace discuss - Apr 2006 - Porting DTrace and submitting changes?

What is the procedure to submit operating system specific changes to DTrace code
back so that it is possible to track OpenSolaris developments without having to
re-port each time a new version is imported?

I''ve been reviewing Devon O''Dell''s work in porting
DTrace to FreeBSD and it quickly became obvious that Solaris'' non-SUSv3
include file names require quite a bit of munging to get something that works on
FreeBSD.

Include file names like "sys/sysmacros.h",
"sys/feature_test.h", "sys/isa_types.h" appear everywhere.

Is it going to be acceptable to add things like:

#if defined(__FreeBSD__)

around includes which have to compatible-ise standard headers into definitions
that suit Sun''s code?

And is it possible to put a similar Solaris-specific thing around all the
non-standard headers that are only in Solaris?
 
 
This message posted from opensolaris.org

On Mon, Apr 10, 2006 at 10:15:25PM -0700, John Birrell
wrote:
> What is the procedure to submit operating system specific changes to DTrace
code back so that it is possible to track OpenSolaris developments without
having to re-port each time a new version is imported?
> 
> I''ve been reviewing Devon O''Dell''s work in
porting DTrace to FreeBSD and it quickly became obvious that Solaris''
non-SUSv3 include file names require quite a bit of munging to get something
that works on FreeBSD.
> 
> Include file names like "sys/sysmacros.h",
"sys/feature_test.h", "sys/isa_types.h" appear everywhere.
> 
> Is it going to be acceptable to add things like:
> 
> #if defined(__FreeBSD__)
> 
> around includes which have to compatible-ise standard headers into
definitions that suit Sun''s code?
> 
> And is it possible to put a similar Solaris-specific thing around all the
non-standard headers that are only in Solaris?
Where possible, I''ve been actually trying to take out all the
Solaris-specific stuff and plop it in a file called
opensol-compat.h just to make things a little bit easier for
me. After that, I tried to just put the unused headers in
#ifdefs, if I''m not mistaken. I''ll get a more detailed email
out to you later this evening.

--Devon
>  
> This message posted from opensolaris.org
> _______________________________________________
> dtrace-discuss mailing list
> dtrace-discuss at opensolaris.org

John Birrell <jb at what-creek.com> wrote:
> What is the procedure to submit operating system specific changes to DTrace
code back so that it is possible to track OpenSolaris developments without
having to re-port each time a new version is imported?
>
> I''ve been reviewing Devon O''Dell''s work in
porting DTrace to FreeBSD and it quickly became obvious that Solaris''
non-SUSv3 include file names require quite a bit of munging to get something
that works on FreeBSD.
>
> Include file names like "sys/sysmacros.h",
"sys/feature_test.h", "sys/isa_types.h" appear everywhere.
These files should never included directly from a source but only 
from higher level (official) include files.

J?rg

-- 
 EMail:joerg at schily.isdn.cs.tu-berlin.de (home) J?rg Schilling D-13353 Berlin
       js at cs.tu-berlin.de                (uni)  
       schilling at fokus.fraunhofer.de     (work) Blog:
http://schily.blogspot.com/
 URL:  http://cdrecord.berlios.de/old/private/ ftp://ftp.berlios.de/pub/schily

On 4/24/06, Joerg Schilling <schilling at fokus.fraunhofer.de>
wrote:
>
> John Birrell <jb at what-creek.com> wrote:
>
> > What is the procedure to submit operating system specific changes to
> DTrace code back so that it is possible to track OpenSolaris developments
> without having to re-port each time a new version is imported?
> >
> > I''ve been reviewing Devon O''Dell''s work in
porting DTrace to FreeBSD and
> it quickly became obvious that Solaris'' non-SUSv3 include file
names require
> quite a bit of munging to get something that works on FreeBSD.
> >
> > Include file names like "sys/sysmacros.h",
"sys/feature_test.h",
> "sys/isa_types.h" appear everywhere.
>
> These files should never included directly from a source but only
> from higher level (official) include files.

sys/sysmacros.h does tend to be included in source files, and include
non-standard macros that are used everywhere.  "sys/feature_test.h"
and
"sys/isa_types.h" should indeed never be directly included.

Cheers,
- jonathan
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://mail.opensolaris.org/pipermail/dtrace-discuss/attachments/20060424/03a152c0/attachment.html>