dovecot - Feb 2021 - doveadm user '*' vs sssd: enumeration works only once

Heiko Schlittermann <hs at schlittermann.de> (Do 25 Feb 2021 10:36:21
CET):
> > within a small timeframe returns a subset of the local users only (the
>     say count();
I suppose the following would fix the issue:
(not tested yet)

diff --git a/src/auth/userdb-passwd.c b/src/auth/userdb-passwd.c
index 70b9969f6..4682dc873 100644
--- a/src/auth/userdb-passwd.c
+++ b/src/auth/userdb-passwd.c
@@ -208,6 +208,7 @@ static int passwd_iterate_deinit(struct
userdb_iterate_context *_ctx)
                cur_userdb_iter_to = timeout_add(0, passwd_iterate_next_timeout,
                                                 NULL);
        }
+       endpwent();
        return ret;
 }


-- 
Heiko
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL:
<https://dovecot.org/pipermail/dovecot/attachments/20210225/2d0a2365/attachment.sig>

> On 25/02/2021 11:41 Heiko Schlittermann <hs at schlittermann.de>
wrote:
> 
>  
> Heiko Schlittermann <hs at schlittermann.de> (Do 25 Feb 2021 10:36:21
CET):
> > > within a small timeframe returns a subset of the local users only
(the
> >     say count();
> I suppose the following would fix the issue:
> (not tested yet)
> 
> diff --git a/src/auth/userdb-passwd.c b/src/auth/userdb-passwd.c
> index 70b9969f6..4682dc873 100644
> --- a/src/auth/userdb-passwd.c
> +++ b/src/auth/userdb-passwd.c
> @@ -208,6 +208,7 @@ static int passwd_iterate_deinit(struct
userdb_iterate_context *_ctx)
>                 cur_userdb_iter_to = timeout_add(0,
passwd_iterate_next_timeout,
>                                                  NULL);
>         }
> +       endpwent();
>         return ret;
>  }
> 
> 
> -- 
> Heiko
Hi!

We'll look into it, might be that we are missing endpwent() there indeed.

Aki