Sorry to bump up an old thread. 2.3.11.3 already contains this patch and the error still gets generated.? Anything else we could try ? Scott On Wednesday, 19/08/2020 at 11:37 Josef 'Jeff' Sipek wrote: On Wed, Aug 19, 2020 at 17:03:57 +0200, Alessio Cecchi wrote:> Hi, > > after the upgrade to Dovecot 2.3.11.3, from 2.3.10.1, I seefrequently> these errors from different users:It looks like this has been around for a while and you just got unlucky and started seeing this now.??Here's a quick & dirty patch that should fix this. If you can try it, let us know how it went. Jeff. diff --git a/src/plugins/fts-solr/solr-connection.c b/src/plugins/fts-solr/solr-connection.c index ae720b5e2870a852c1b6c440939e3c7c0fa72b5c..9d364f93e2cd1b716b9ab61bd39656a6c5b1ea04 100644 --- a/src/plugins/fts-solr/solr-connection.c +++ b/src/plugins/fts-solr/solr-connection.c @@ -103,7 +103,7 @@ int solr_connection_init(const struct fts_solr_settings *solr_set, http_set.ssl = ssl_client_set; http_set.debug = solr_set->debug; http_set.rawlog_dir = solr_set->rawlog_dir; -solr_http_client = http_client_init(&http_set); +solr_http_client = http_client_init_private(&http_set); } *conn_r = conn; diff --git a/src/plugins/fts/fts-parser-tika.c b/src/plugins/fts/fts-parser-tika.c index a4b8b5c3034f57e22e77caa759c090da6b62f8ba..b8b57a350b9a710d101ac7ccbcc14560d415d905 100644 --- a/src/plugins/fts/fts-parser-tika.c +++ b/src/plugins/fts/fts-parser-tika.c @@ -77,7 +77,7 @@ tika_get_http_client_url(struct mail_user *user, struct http_url **http_url_r) http_set.request_timeout_msecs = 60*1000; http_set.ssl = &ssl_set; http_set.debug = user->mail_debug; -tika_http_client = http_client_init(&http_set); +tika_http_client = http_client_init_private(&http_set); } *http_url_r = tuser->http_url; return 0; -------------- next part -------------- An HTML attachment was scrubbed... URL: <https://dovecot.org/pipermail/dovecot/attachments/20200902/9bd83ee0/attachment.html>
On Wed, Sep 02, 2020 at 15:07:37 -0400, Scott Q. wrote:> Sorry to bump up an old thread. > > 2.3.11.3 already contains this patch and the error still gets > generated.?I'm not sure where you are finding it. The below patch isn't on the release-2.3.11 branch. It isn't in the 2.3.11.3 tarball. It isn't even on master. Those two files haven't been touched since January. Jeff.> Anything else we could try ? > > Scott > > On Wednesday, 19/08/2020 at 11:37 Josef 'Jeff' Sipek wrote: > > > On Wed, Aug 19, 2020 at 17:03:57 +0200, Alessio Cecchi wrote: > > Hi, > > > > after the upgrade to Dovecot 2.3.11.3, from 2.3.10.1, I see > frequently > > these errors from different users: > > It looks like this has been around for a while and you just got > unlucky and > started seeing this now.??Here's a quick & dirty patch that should > fix this. > If you can try it, let us know how it went. > > Jeff. > > > diff --git a/src/plugins/fts-solr/solr-connection.c > b/src/plugins/fts-solr/solr-connection.c > index > ae720b5e2870a852c1b6c440939e3c7c0fa72b5c..9d364f93e2cd1b716b9ab61bd39656a6c5b1ea04 > 100644 > --- a/src/plugins/fts-solr/solr-connection.c > +++ b/src/plugins/fts-solr/solr-connection.c > @@ -103,7 +103,7 @@ int solr_connection_init(const struct > fts_solr_settings *solr_set, > http_set.ssl = ssl_client_set; > http_set.debug = solr_set->debug; > http_set.rawlog_dir = solr_set->rawlog_dir; > -solr_http_client = http_client_init(&http_set); > +solr_http_client = http_client_init_private(&http_set); > } > > *conn_r = conn; > diff --git a/src/plugins/fts/fts-parser-tika.c > b/src/plugins/fts/fts-parser-tika.c > index > a4b8b5c3034f57e22e77caa759c090da6b62f8ba..b8b57a350b9a710d101ac7ccbcc14560d415d905 > 100644 > --- a/src/plugins/fts/fts-parser-tika.c > +++ b/src/plugins/fts/fts-parser-tika.c > @@ -77,7 +77,7 @@ tika_get_http_client_url(struct mail_user *user, > struct http_url **http_url_r) > http_set.request_timeout_msecs = 60*1000; > http_set.ssl = &ssl_set; > http_set.debug = user->mail_debug; > -tika_http_client = http_client_init(&http_set); > +tika_http_client = http_client_init_private(&http_set); > } > *http_url_r = tuser->http_url; > return 0;-- Hegh QaQ law' quvHa'ghach QaQ puS
Sorry about that. My FreeBSD system automatically applied your patches and I assumed they were already part of the master. Unfortunately it still means the bug isn't resolved with these changes. On Wednesday, 02/09/2020 at 15:34 Josef 'Jeff' Sipek wrote: On Wed, Sep 02, 2020 at 15:07:37 -0400, Scott Q. wrote:> Sorry to bump up an old thread. > > 2.3.11.3 already contains this patch and the error still gets > generated.?I'm not sure where you are finding it.??The below patch isn't on the release-2.3.11 branch.??It isn't in the 2.3.11.3 tarball.??It isn't even on master.??Those two files haven't been touched since January. Jeff.> Anything else we could try ? > > Scott > > On Wednesday, 19/08/2020 at 11:37 Josef 'Jeff' Sipek wrote: > > > On Wed, Aug 19, 2020 at 17:03:57 +0200, Alessio Cecchi wrote: > > Hi, > > > > after the upgrade to Dovecot 2.3.11.3, from 2.3.10.1, I see > frequently > > these errors from different users: > > It looks like this has been around for a while and you just got > unlucky and > started seeing this now.??Here's a quick & dirty patch that should > fix this. > If you can try it, let us know how it went. > > Jeff. > > > diff --git a/src/plugins/fts-solr/solr-connection.c > b/src/plugins/fts-solr/solr-connection.c > index >ae720b5e2870a852c1b6c440939e3c7c0fa72b5c..9d364f93e2cd1b716b9ab61bd39656a6c5b1ea04> 100644 > --- a/src/plugins/fts-solr/solr-connection.c > +++ b/src/plugins/fts-solr/solr-connection.c > @@ -103,7 +103,7 @@ int solr_connection_init(const struct > fts_solr_settings *solr_set, > http_set.ssl = ssl_client_set; > http_set.debug = solr_set->debug; > http_set.rawlog_dir = solr_set->rawlog_dir; > -solr_http_client = http_client_init(&http_set); > +solr_http_client = http_client_init_private(&http_set); > } > > *conn_r = conn; > diff --git a/src/plugins/fts/fts-parser-tika.c > b/src/plugins/fts/fts-parser-tika.c > index >a4b8b5c3034f57e22e77caa759c090da6b62f8ba..b8b57a350b9a710d101ac7ccbcc14560d415d905> 100644 > --- a/src/plugins/fts/fts-parser-tika.c > +++ b/src/plugins/fts/fts-parser-tika.c > @@ -77,7 +77,7 @@ tika_get_http_client_url(struct mail_user *user, > struct http_url **http_url_r) > http_set.request_timeout_msecs = 60*1000; > http_set.ssl = &ssl_set; > http_set.debug = user->mail_debug; > -tika_http_client = http_client_init(&http_set); > +tika_http_client = http_client_init_private(&http_set); > } > *http_url_r = tuser->http_url; > return 0;-- Hegh QaQ law' quvHa'ghach QaQ puS -------------- next part -------------- An HTML attachment was scrubbed... URL: <https://dovecot.org/pipermail/dovecot/attachments/20200902/f51b4c5f/attachment.html>