On Wed, Dec 04, 2019 at 12:19:35 -0500, Josef 'Jeff' Sipek via dovecot wrote:> On Wed, Dec 04, 2019 at 18:06:58 +0100, Pascal Christen via dovecot wrote: > > Hi > > > > I've just tried to build the latest Dovecot 2.3.9 on FreeBSD 11.3. > > Without success...It fails on the following commit which was introduced > > in 2.3.9: > > https://github.com/dovecot/core/commit/c85f1bc3ce612c736c9d2c468cc08306db1b5851 > > > > Following output is the build log: https://pastebin.com/3nvSeDn8 > > > > So I guess it has to do with some changes FreeBSD made: > > https://reviews.freebsd.org/D18630 > > As far as I can tell, dovecot should be checking for the existence of > EAI_ADDRFAMILY and EAI_NODATA. > > The good news is, a quick workaround is to remove the two lines that use > these two constants. (A correct patch would do the proper checks.)Ok. That was easy. I'm going to get the following patch reviewed and committed. Jeff. diff --git a/src/lib/net.c b/src/lib/net.c --- a/src/lib/net.c +++ b/src/lib/net.c @@ -1068,13 +1068,17 @@ enum net_hosterror_type net_get_hosterro int error; enum net_hosterror_type type; } error_map[] = { +#ifdef EAI_ADDRFAIMILY /* Obsoleted by RFC 2553bis-02 */ { EAI_ADDRFAMILY, NET_HOSTERROR_TYPE_NOT_FOUND }, +#endif { EAI_AGAIN, NET_HOSTERROR_TYPE_NAMESERVER }, { EAI_BADFLAGS, NET_HOSTERROR_TYPE_INTERNAL_ERROR }, { EAI_FAIL, NET_HOSTERROR_TYPE_NAMESERVER }, { EAI_FAMILY, NET_HOSTERROR_TYPE_INTERNAL_ERROR }, { EAI_MEMORY, NET_HOSTERROR_TYPE_INTERNAL_ERROR }, +#ifdef EAI_NODATA /* Obsoleted by RFC 2553bis-02 */ { EAI_NODATA, NET_HOSTERROR_TYPE_NOT_FOUND }, +#endif { EAI_NONAME, NET_HOSTERROR_TYPE_NOT_FOUND }, { EAI_SERVICE, NET_HOSTERROR_TYPE_INTERNAL_ERROR }, { EAI_SOCKTYPE, NET_HOSTERROR_TYPE_INTERNAL_ERROR },
I'm working on the port as we type. I've already done this patch (will add the comments). On Wed, Dec 4, 2019 at 11:29 AM Josef 'Jeff' Sipek via dovecot < dovecot at dovecot.org> wrote:> On Wed, Dec 04, 2019 at 12:19:35 -0500, Josef 'Jeff' Sipek via dovecot > wrote: > > On Wed, Dec 04, 2019 at 18:06:58 +0100, Pascal Christen via dovecot > wrote: > > > Hi > > > > > > I've just tried to build the latest Dovecot 2.3.9 on FreeBSD 11.3. > > > Without success...It fails on the following commit which was introduced > > > in 2.3.9: > > > > https://github.com/dovecot/core/commit/c85f1bc3ce612c736c9d2c468cc08306db1b5851 > > > > > > Following output is the build log: https://pastebin.com/3nvSeDn8 > > > > > > So I guess it has to do with some changes FreeBSD made: > > > https://reviews.freebsd.org/D18630 > > > > As far as I can tell, dovecot should be checking for the existence of > > EAI_ADDRFAMILY and EAI_NODATA. > > > > The good news is, a quick workaround is to remove the two lines that use > > these two constants. (A correct patch would do the proper checks.) > > Ok. That was easy. I'm going to get the following patch reviewed and > committed. > > Jeff. > > diff --git a/src/lib/net.c b/src/lib/net.c > --- a/src/lib/net.c > +++ b/src/lib/net.c > @@ -1068,13 +1068,17 @@ enum net_hosterror_type net_get_hosterro > int error; > enum net_hosterror_type type; > } error_map[] = { > +#ifdef EAI_ADDRFAIMILY /* Obsoleted by RFC 2553bis-02 */ > { EAI_ADDRFAMILY, NET_HOSTERROR_TYPE_NOT_FOUND }, > +#endif > { EAI_AGAIN, NET_HOSTERROR_TYPE_NAMESERVER }, > { EAI_BADFLAGS, NET_HOSTERROR_TYPE_INTERNAL_ERROR }, > { EAI_FAIL, NET_HOSTERROR_TYPE_NAMESERVER }, > { EAI_FAMILY, NET_HOSTERROR_TYPE_INTERNAL_ERROR }, > { EAI_MEMORY, NET_HOSTERROR_TYPE_INTERNAL_ERROR }, > +#ifdef EAI_NODATA /* Obsoleted by RFC 2553bis-02 */ > { EAI_NODATA, NET_HOSTERROR_TYPE_NOT_FOUND }, > +#endif > { EAI_NONAME, NET_HOSTERROR_TYPE_NOT_FOUND }, > { EAI_SERVICE, NET_HOSTERROR_TYPE_INTERNAL_ERROR }, > { EAI_SOCKTYPE, NET_HOSTERROR_TYPE_INTERNAL_ERROR }, >-- Larry Rosenman http://www.lerctr.org/~ler Phone: +1 214-642-9640 (c) E-Mail: larryrtx at gmail.com US Mail: 5708 Sabbia Dr, Round Rock, TX 78665-2106 -------------- next part -------------- An HTML attachment was scrubbed... URL: <https://dovecot.org/pipermail/dovecot/attachments/20191204/4757618c/attachment.html>
Thanks, build passed on FreeBSD 11.3 Greetings Pascal
On Wed, Dec 04, 2019 at 18:41:45 +0100, Pascal Christen wrote:> Thanks, build passed on FreeBSD 11.3It turns out I had a typo in the patch I posted on the mailing list. I corrected the typo and it builds fine on 12.1. Jeff. -#ifdef EAI_ADDRFAIMILY /* Obsoleted by RFC 2553bis-02 */ +#ifdef EAI_ADDRFAMILY /* Obsoleted by RFC 2553bis-02 */
Ignore me, I'm talking about the FreeBSD port, not the actual upstream sources. Sorry for the noise. On Wed, Dec 4, 2019 at 11:40 AM Larry Rosenman <larryrtx at gmail.com> wrote:> I'm working on the port as we type. I've already done this patch (will > add the comments). > > > > On Wed, Dec 4, 2019 at 11:29 AM Josef 'Jeff' Sipek via dovecot < > dovecot at dovecot.org> wrote: > >> On Wed, Dec 04, 2019 at 12:19:35 -0500, Josef 'Jeff' Sipek via dovecot >> wrote: >> > On Wed, Dec 04, 2019 at 18:06:58 +0100, Pascal Christen via dovecot >> wrote: >> > > Hi >> > > >> > > I've just tried to build the latest Dovecot 2.3.9 on FreeBSD 11.3. >> > > Without success...It fails on the following commit which was >> introduced >> > > in 2.3.9: >> > > >> https://github.com/dovecot/core/commit/c85f1bc3ce612c736c9d2c468cc08306db1b5851 >> > > >> > > Following output is the build log: https://pastebin.com/3nvSeDn8 >> > > >> > > So I guess it has to do with some changes FreeBSD made: >> > > https://reviews.freebsd.org/D18630 >> > >> > As far as I can tell, dovecot should be checking for the existence of >> > EAI_ADDRFAMILY and EAI_NODATA. >> > >> > The good news is, a quick workaround is to remove the two lines that use >> > these two constants. (A correct patch would do the proper checks.) >> >> Ok. That was easy. I'm going to get the following patch reviewed and >> committed. >> >> Jeff. >> >> diff --git a/src/lib/net.c b/src/lib/net.c >> --- a/src/lib/net.c >> +++ b/src/lib/net.c >> @@ -1068,13 +1068,17 @@ enum net_hosterror_type net_get_hosterro >> int error; >> enum net_hosterror_type type; >> } error_map[] = { >> +#ifdef EAI_ADDRFAIMILY /* Obsoleted by RFC 2553bis-02 */ >> { EAI_ADDRFAMILY, NET_HOSTERROR_TYPE_NOT_FOUND }, >> +#endif >> { EAI_AGAIN, NET_HOSTERROR_TYPE_NAMESERVER }, >> { EAI_BADFLAGS, NET_HOSTERROR_TYPE_INTERNAL_ERROR }, >> { EAI_FAIL, NET_HOSTERROR_TYPE_NAMESERVER }, >> { EAI_FAMILY, NET_HOSTERROR_TYPE_INTERNAL_ERROR }, >> { EAI_MEMORY, NET_HOSTERROR_TYPE_INTERNAL_ERROR }, >> +#ifdef EAI_NODATA /* Obsoleted by RFC 2553bis-02 */ >> { EAI_NODATA, NET_HOSTERROR_TYPE_NOT_FOUND }, >> +#endif >> { EAI_NONAME, NET_HOSTERROR_TYPE_NOT_FOUND }, >> { EAI_SERVICE, NET_HOSTERROR_TYPE_INTERNAL_ERROR }, >> { EAI_SOCKTYPE, NET_HOSTERROR_TYPE_INTERNAL_ERROR }, >> > > > -- > Larry Rosenman http://www.lerctr.org/~ler > Phone: +1 214-642-9640 (c) E-Mail: larryrtx at gmail.com > US Mail: 5708 Sabbia Dr, Round Rock, TX 78665-2106 >-- Larry Rosenman http://www.lerctr.org/~ler Phone: +1 214-642-9640 (c) E-Mail: larryrtx at gmail.com US Mail: 5708 Sabbia Dr, Round Rock, TX 78665-2106 -------------- next part -------------- An HTML attachment was scrubbed... URL: <https://dovecot.org/pipermail/dovecot/attachments/20191204/6dabcb27/attachment-0001.html>