dovecot - Mar 2019 - Dovecot v2.3.5 released

> On 7 March 2019 18:02 A. Schulze via dovecot <dovecot at dovecot.org>
wrote:
> 
>  
> Am 05.03.19 um 17:26 schrieb Aki Tuomi via dovecot:
> > We are happy to release dovecot v2.3.5.
> 
> Hello,
> 
> it build but tests fail...
> 
> make[4]: Entering directory
'/<<PKGBUILDDIR>>/src/lib-http'
> for bin in test-http-date test-http-url test-http-header-parser
test-http-transfer test-http-auth test-http-response-parser
test-http-request-parser test-http-payload test-http-client-errors
test-http-server-errors; do \
>   if !  ./$bin; then exit 1; fi; \
> done
> ...
> unconfigured ssl ..................................................... : ok
> unconfigured ssl abort ............................................... : ok
> invalid url .......................................................... : ok
> host lookup failed ................................................... : ok
> connection refused ................................................... : ok
> connection refused backoff ........................................... : ok
> connection lost prematurely .......................................... : ok
> test-http-client-errors.c:2989: Assert failed: FALSE
> connection timed out ................................................. :
FAILED
> invalid redirect: not accepted ....................................... : ok
> invalid redirect: bad location ....................................... : ok
> invalid redirect: too many ........................................... : ok
> ...
> 1 / 38 tests failed
> 
> 
> looking at test-http-client-errors.c:2989, could this test ever pass?
> 
> 	        test_assert(FALSE);
> 
> Andreas
It does pass over here. Are you running with valgrind or on really slow system?

Does it happen if you run env NOVALGRIND=yes make check?

Aki

Am 07.03.19 um 17:33 schrieb Aki Tuomi via dovecot:
>> test-http-client-errors.c:2989: Assert failed: FALSE
>> connection timed out .................................................
: FAILED
Hello Aki,
> Are you running with valgrind or on really slow system?
I'm not aware my buildsystem use valgrind ...

How do you define "a really slow system"?
All I can mention as reference is a build time of 11 minutes until the error
occur.
> Does it happen if you run env NOVALGRIND=yes make check?
yes, 

Andreas

On 7.3.2019 23.37, A. Schulze via dovecot wrote:
>
> Am 07.03.19 um 17:33 schrieb Aki Tuomi via dovecot:
>
>>> test-http-client-errors.c:2989: Assert failed: FALSE
>>> connection timed out
................................................. : FAILED
> Hello Aki,
>
>> Are you running with valgrind or on really slow system?
> I'm not aware my buildsystem use valgrind ...
>
> How do you define "a really slow system"?
> All I can mention as reference is a build time of 11 minutes until the
error occur.
>
>> Does it happen if you run env NOVALGRIND=yes make check?
> yes, 
>
> Andreas
The assertion occurs because it seems to take too long to complete the
test, that's why it's asserting FALSE (see the comment above the line).
Can you run the test with strace and provide strace output?

Aki