dovecot - Apr 2017 - Pigeonhole / Bug with "duplicate" ?

Hello,

Previously, while running Dovecot 2.2.27/Pigeonhole 0.4.16 the following 
code snippet was working as one would expect:

   if duplicate {
     addflag ["\\seen", "Duplicate"];
     fileinto "Duplicate";
     stop;
   }

   if address :contains "to" "user.email at example.com" {
     addflag "$label1";
   }


After upgrading to Dovecot 2.2.29.1/Pigeonhole 0.4.18 it's not working 
anymore. When an e-mail is sent to the user the "$label1" isn't
applied
at all to the message (in the case it's NOT a duplicate).

Downgrading to Dovecot 2.2.29.1/Pigeonhole 0.4.17 exposes the same 
incorrect behaviour.

Downgrading to Dovecot 2.2.29.1/Pigeonhole 0.4.16 is OK.

When running pigeonhole 0.4.17 & 0.4.18, commenting the "if duplicate 
{}" block restores the expected behaviour.


Looks like a bug that appeared in 0.4.17? Am I correct?


Kind regards,
Gilles.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 3639 bytes
Desc: S/MIME Cryptographic Signature
URL:
<http://dovecot.org/pipermail/dovecot/attachments/20170425/512cb03c/attachment.p7s>

Op 4/25/2017 om 11:52 AM schreef Gilles Chauvin:
> Hello,
>
> Previously, while running Dovecot 2.2.27/Pigeonhole 0.4.16 the
> following code snippet was working as one would expect:
>
>   if duplicate {
>     addflag ["\\seen", "Duplicate"];
>     fileinto "Duplicate";
>     stop;
>   }
>
>   if address :contains "to" "user.email at example.com"
{
>     addflag "$label1";
>   }
>
>
> After upgrading to Dovecot 2.2.29.1/Pigeonhole 0.4.18 it's not working
> anymore. When an e-mail is sent to the user the "$label1"
isn't
> applied at all to the message (in the case it's NOT a duplicate).
>
> Downgrading to Dovecot 2.2.29.1/Pigeonhole 0.4.17 exposes the same
> incorrect behaviour.
>
> Downgrading to Dovecot 2.2.29.1/Pigeonhole 0.4.16 is OK.
>
> When running pigeonhole 0.4.17 & 0.4.18, commenting the "if
duplicate
> {}" block restores the expected behaviour.
>
>
> Looks like a bug that appeared in 0.4.17? Am I correct?
Possibly. Will back on this later. Likely tomorrow.

Regards,

Stephan.

Op 4/25/2017 om 9:23 PM schreef Stephan Bosch:
> Op 4/25/2017 om 11:52 AM schreef Gilles Chauvin:
>> Hello,
>>
>> Previously, while running Dovecot 2.2.27/Pigeonhole 0.4.16 the
>> following code snippet was working as one would expect:
>>
>>   if duplicate {
>>     addflag ["\\seen", "Duplicate"];
>>     fileinto "Duplicate";
>>     stop;
>>   }
>>
>>   if address :contains "to" "user.email at
example.com" {
>>     addflag "$label1";
>>   }
>>
>>
>> After upgrading to Dovecot 2.2.29.1/Pigeonhole 0.4.18 it's not
working
>> anymore. When an e-mail is sent to the user the "$label1"
isn't
>> applied at all to the message (in the case it's NOT a duplicate).
>>
>> Downgrading to Dovecot 2.2.29.1/Pigeonhole 0.4.17 exposes the same
>> incorrect behaviour.
>>
>> Downgrading to Dovecot 2.2.29.1/Pigeonhole 0.4.16 is OK.
>>
>> When running pigeonhole 0.4.17 & 0.4.18, commenting the "if
duplicate
>> {}" block restores the expected behaviour.
>>
>>
>> Looks like a bug that appeared in 0.4.17? Am I correct?
> Possibly. Will back on this later. Likely tomorrow.
I can reproduce it. It doesn't make much sense to me yet. It only
happens in the interaction between duplicate and imap4flags, either
extension on its own seems to work fine.

Investigating...


Regards,

Stephan.

Op 4/25/2017 om 11:52 AM schreef Gilles Chauvin:
> Hello,
>
> Previously, while running Dovecot 2.2.27/Pigeonhole 0.4.16 the
> following code snippet was working as one would expect:
>
>   if duplicate {
>     addflag ["\\seen", "Duplicate"];
>     fileinto "Duplicate";
>     stop;
>   }
>
>   if address :contains "to" "user.email at example.com"
{
>     addflag "$label1";
>   }
>
>
> After upgrading to Dovecot 2.2.29.1/Pigeonhole 0.4.18 it's not working
> anymore. When an e-mail is sent to the user the "$label1"
isn't
> applied at all to the message (in the case it's NOT a duplicate).
>
> Downgrading to Dovecot 2.2.29.1/Pigeonhole 0.4.17 exposes the same
> incorrect behaviour.
>
> Downgrading to Dovecot 2.2.29.1/Pigeonhole 0.4.16 is OK.
>
> When running pigeonhole 0.4.17 & 0.4.18, commenting the "if
duplicate
> {}" block restores the expected behaviour.
>
>
> Looks like a bug that appeared in 0.4.17? Am I correct?
This bug is much older than that. It was exposed by recent changes though.

This should fix it:

https://github.com/dovecot/pigeonhole/commit/3e1a17a286ab0e084577fc267a442cb12aed1cbc

Regards,

Stephan.

On 28/04/2017 00:39, Stephan Bosch wrote:
>> Looks like a bug that appeared in 0.4.17? Am I correct?
> 
> This bug is much older than that. It was exposed by recent changes though.
> 
> This should fix it:
> 
>
https://github.com/dovecot/pigeonhole/commit/3e1a17a286ab0e084577fc267a442cb12aed1cbc
> 
Hi Stephan,

Thanks for taking the time to work on this issue. I applied your patch 
and the problem seems to be gone now.


Regards,
Gilles.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 3639 bytes
Desc: S/MIME Cryptographic Signature
URL:
<http://dovecot.org/pipermail/dovecot/attachments/20170428/d10cf521/attachment.p7s>