dovecot - Mar 2016 - Compilation fails: SSL_TXT_SSLV2 not defined

Hello all,

I'm trying to compile dovecot 2.2.21 on OS-X 10.11.3 and I'm running a
bit of trouble with OpenSSL. I've cloned OpenSSL (OpenSSL
1.1.0-pre4-dev) from github and in openssl/ssl.h SSL_TXT_SSLV2 is not
defined anymore. Compilation fails with:

libtool: compile:  gcc -DHAVE_CONFIG_H -I. -I../.. -I../../src/lib
-I../../src/lib-test -DMODULE_DIR=\"/usr/local/lib/dovecot\"
-std=gnu99
-g -O2 -Wall -W -Wmissing-prototypes -Wmissing-declarations
-Wpointer-arith -Wchar-subscripts -Wformat=2 -Wbad-function-cast
-Wno-duplicate-decl-specifier -Wstrict-aliasing=2 -MT
iostream-openssl-common.lo -MD -MP -MF .deps/iostream-openssl-common.Tpo
-c iostream-openssl-common.c  -fno-common -DPIC -o
.libs/iostream-openssl-common.o
iostream-openssl-common.c:34:24: error: use of undeclared identifier
'SSL_TXT_SSLV2'
                if (strcasecmp(name, SSL_TXT_SSLV2) == 0)
                                     ^
1 error generated.
make[3]: *** [iostream-openssl-common.lo] Error 1
make[2]: *** [all-recursive] Error 1
make[1]: *** [all-recursive] Error 1
make: *** [all] Error 2

In openssl/ssl.h the following is defined:

# define SSL_TXT_SSLV3           "SSLv3"
# define SSL_TXT_TLSV1           "TLSv1"
# define SSL_TXT_TLSV1_1         "TLSv1.1"
# define SSL_TXT_TLSV1_2         "TLSv1.2"

# define SSL_TXT_ALL             "ALL"

Any suggestions on how to fix this?

Kind regards, Maarten

> On March 7, 2016 at 5:54 PM Muffinman <news at koster.tk> wrote:
> 
> 
> Hello all,
> 
> I'm trying to compile dovecot 2.2.21 on OS-X 10.11.3 and I'm
running a
> bit of trouble with OpenSSL. I've cloned OpenSSL (OpenSSL
> 1.1.0-pre4-dev) from github and in openssl/ssl.h SSL_TXT_SSLV2 is not
> defined anymore. Compilation fails with:
> 
> libtool: compile:  gcc -DHAVE_CONFIG_H -I. -I../.. -I../../src/lib
> -I../../src/lib-test -DMODULE_DIR=\"/usr/local/lib/dovecot\"
-std=gnu99
> -g -O2 -Wall -W -Wmissing-prototypes -Wmissing-declarations
> -Wpointer-arith -Wchar-subscripts -Wformat=2 -Wbad-function-cast
> -Wno-duplicate-decl-specifier -Wstrict-aliasing=2 -MT
> iostream-openssl-common.lo -MD -MP -MF .deps/iostream-openssl-common.Tpo
> -c iostream-openssl-common.c  -fno-common -DPIC -o
> .libs/iostream-openssl-common.o
> iostream-openssl-common.c:34:24: error: use of undeclared identifier
> 'SSL_TXT_SSLV2'
>                 if (strcasecmp(name, SSL_TXT_SSLV2) == 0)
>                                      ^
> 1 error generated.
> make[3]: *** [iostream-openssl-common.lo] Error 1
> make[2]: *** [all-recursive] Error 1
> make[1]: *** [all-recursive] Error 1
> make: *** [all] Error 2
> 
> In openssl/ssl.h the following is defined:
> 
> # define SSL_TXT_SSLV3           "SSLv3"
> # define SSL_TXT_TLSV1           "TLSv1"
> # define SSL_TXT_TLSV1_1         "TLSv1.1"
> # define SSL_TXT_TLSV1_2         "TLSv1.2"
> 
> # define SSL_TXT_ALL             "ALL"
> 
> Any suggestions on how to fix this?
> 
> Kind regards, Maarten
Hi!

Can you try the attached patch?

---
Aki Tuomi
Dovecot oy
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-lib-ssl-iostream-Make-SSLv2-conditional.patch
Type: text/x-patch
Size: 1031 bytes
Desc: not available
URL:
<http://dovecot.org/pipermail/dovecot/attachments/20160307/372aacf4/attachment.bin>

> On March 7, 2016 at 6:09 PM aki.tuomi at dovecot.fi wrote:
> 
> 
> 
> > On March 7, 2016 at 5:54 PM Muffinman <news at koster.tk> wrote:
> > 
> > 
> > Hello all,
> > 
> > I'm trying to compile dovecot 2.2.21 on OS-X 10.11.3 and I'm
running a
> > bit of trouble with OpenSSL. I've cloned OpenSSL (OpenSSL
> > 1.1.0-pre4-dev) from github and in openssl/ssl.h SSL_TXT_SSLV2 is not
> > defined anymore. Compilation fails with:
> > 
> > libtool: compile:  gcc -DHAVE_CONFIG_H -I. -I../.. -I../../src/lib
> > -I../../src/lib-test -DMODULE_DIR=\"/usr/local/lib/dovecot\"
-std=gnu99
> > -g -O2 -Wall -W -Wmissing-prototypes -Wmissing-declarations
> > -Wpointer-arith -Wchar-subscripts -Wformat=2 -Wbad-function-cast
> > -Wno-duplicate-decl-specifier -Wstrict-aliasing=2 -MT
> > iostream-openssl-common.lo -MD -MP -MF
.deps/iostream-openssl-common.Tpo
> > -c iostream-openssl-common.c  -fno-common -DPIC -o
> > .libs/iostream-openssl-common.o
> > iostream-openssl-common.c:34:24: error: use of undeclared identifier
> > 'SSL_TXT_SSLV2'
> >                 if (strcasecmp(name, SSL_TXT_SSLV2) == 0)
> >                                      ^
> > 1 error generated.
> > make[3]: *** [iostream-openssl-common.lo] Error 1
> > make[2]: *** [all-recursive] Error 1
> > make[1]: *** [all-recursive] Error 1
> > make: *** [all] Error 2
> > 
> > In openssl/ssl.h the following is defined:
> > 
> > # define SSL_TXT_SSLV3           "SSLv3"
> > # define SSL_TXT_TLSV1           "TLSv1"
> > # define SSL_TXT_TLSV1_1         "TLSv1.1"
> > # define SSL_TXT_TLSV1_2         "TLSv1.2"
> > 
> > # define SSL_TXT_ALL             "ALL"
> > 
> > Any suggestions on how to fix this?
> > 
> > Kind regards, Maarten
> 
> Hi!
> 
> Can you try the attached patch?
> 
> ---
> Aki Tuomi
> Dovecot oy
Apologies, fixed patch attached.

Aki
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-lib-ssl-iostream-Make-SSLv2-conditional.patch
Type: text/x-patch
Size: 1006 bytes
Desc: not available
URL:
<http://dovecot.org/pipermail/dovecot/attachments/20160307/bfdd4c57/attachment.bin>