dovecot - Dec 2015 - doveadm expunge no longer works

Heya,

Just upgraded from 2.2.19 to dovecot-2.2.21 and noticed expunging mail
no longer works.

# doveadm expunge -u theuser MAILBOX spam all
Fatal: expunge: To avoid accidents, each branch in search query must
contain something else besides MAILBOX (e.g. just add "all" if you
want
everything)

Clearly, I've already got all in there, so I tried capitalising, etc.
Looking at the code, I see expunge_search_args_is_msgset_or_ok
apparently is failing.  I'm wondering if this function [1] is actually doing
what it is supposed to do, since it uses return, instead a var to figure out
whether it is ok or not.  In my case, just because it finds MAILBOX it returns
without looking whether there is any further arguments.

Or am I missing the point here (and how should I expunge a folder of
mail?)

Thanks,
Fabian

[1]
https://github.com/dovecot/core/blob/6971937a6f3e93844dbd43bdbe903628e21a9422/src/doveadm/doveadm-mail-expunge.c#L148

-- 
Fabian Groffen
Gentoo on a different level
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL:
<http://dovecot.org/pipermail/dovecot/attachments/20151231/02b17d73/attachment.sig>

Please ignore, this appears to be fixed by
6971937a6f3e93844dbd43bdbe903628e21a9422 [1].

Thanks,
Fabian

[1]
https://github.com/dovecot/core/commit/6971937a6f3e93844dbd43bdbe903628e21a9422.patch

On 31-12-2015 17:28:34 +0100, Fabian Groffen wrote:
> Heya,
> 
> Just upgraded from 2.2.19 to dovecot-2.2.21 and noticed expunging mail
> no longer works.
> 
> # doveadm expunge -u theuser MAILBOX spam all
> Fatal: expunge: To avoid accidents, each branch in search query must
> contain something else besides MAILBOX (e.g. just add "all" if
you want
> everything)
> 
> Clearly, I've already got all in there, so I tried capitalising, etc.
> Looking at the code, I see expunge_search_args_is_msgset_or_ok
> apparently is failing.  I'm wondering if this function [1] is actually
doing what it is supposed to do, since it uses return, instead a var to figure
out whether it is ok or not.  In my case, just because it finds MAILBOX it
returns without looking whether there is any further arguments.
> 
> Or am I missing the point here (and how should I expunge a folder of
> mail?)
> 
> Thanks,
> Fabian
> 
> [1]
https://github.com/dovecot/core/blob/6971937a6f3e93844dbd43bdbe903628e21a9422/src/doveadm/doveadm-mail-expunge.c#L148
> 
> -- 
> Fabian Groffen
> Gentoo on a different level


-- 
Fabian Groffen
Gentoo on a different level
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL:
<http://dovecot.org/pipermail/dovecot/attachments/20151231/097bf1f7/attachment.sig>