I noticed that disabling services using vpopmail was not being recognized by dovecot. Using "vmoduser -swip user at domain.com" should disable all services, but both pop and imap logins were still allowed. After a bit of digging in the code and confirming with a few debug lines, it appears that lines 38 and 52 of src/auth/passdb-vpopmail.c are the issue (dovecot 2.0.8). These two lines do a strcmp on request->service. It appears that request->service is in lower case, but the comparison values are in upper case. Either updating the values to lowercase or using strcasecmp should fix the issue. Calvin _________________________________________________ Scanned on 27 Dec 2010 23:05:02 This e-mail message is confidential, intended only for the named recipient(s) above and may contain information that is privileged, attorney work product or exempt from disclosure under applicable law. If you have received this message in error, or are not the named recipient(s), please immediately notify the sender at 425-336-0480 and delete the e-mail message from your computer. Thank you.
On Mon, 2010-12-27 at 15:04 -0800, Calvin wrote:> I noticed that disabling services using vpopmail was not being recognized by > dovecot. Using "vmoduser -swip user at domain.com" should disable all services, > but both pop and imap logins were still allowed. After a bit of digging in > the code and confirming with a few debug lines, it appears that lines 38 and > 52 of src/auth/passdb-vpopmail.c are the issue (dovecot 2.0.8). These two > lines do a strcmp on request->service. It appears that request->service is in > lower case, but the comparison values are in upper case. Either updating the > values to lowercase or using strcasecmp should fix the issue.Thanks, fixed: http://hg.dovecot.org/dovecot-2.0/rev/9216e5c861ee -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 198 bytes Desc: This is a digitally signed message part URL: <http://dovecot.org/pipermail/dovecot/attachments/20101230/3bac3536/attachment-0002.bin>
Il 28/12/2010 00:04, Calvin ha scritto:> I noticed that disabling services using vpopmail was not being recognized by > dovecot. Using "vmoduser -swip user at domain.com" should disable all services, > but both pop and imap logins were still allowed. After a bit of digging in > the code and confirming with a few debug lines, it appears that lines 38 and > 52 of src/auth/passdb-vpopmail.c are the issue (dovecot 2.0.8). These two > lines do a strcmp on request->service. It appears that request->service is in > lower case, but the comparison values are in upper case. Either updating the > values to lowercase or using strcasecmp should fix the issue. > CalvinHi Calvin, I have the same issue with my vpopmail installation. Can you share your dovecot.conf file? What vpopmail version you are running? Thanks -- Alessio Cecchi is: @ ILS -> http://www.linux.it/~alessice/ on LinkedIn -> http://www.linkedin.com/in/alessice Assistenza Sistemi GNU/Linux -> http://www.cecchi.biz/ @ PLUG -> ex-Presidente, adesso senatore a vita, http://www.prato.linux.it @ LOLUG -> Socio http://www.lolug.net