dovecot - Oct 2008 - PATCH: Advertise X-REFERENCES2

Don't see any reason why X-REFERENCES2 should not be advertised in the  
CAPABILITY string - the wiki indicates this is a new addition for 1.2,  
and RFC 5256 explicitly states that the THREAD= is to be used for  
upwards-compatible extensions.

# HG changeset patch
# User root at bigworm.curecanti.org
# Date 1225057043 21600
# Branch HEAD
# Node ID 1f082281f8d4e3d364b85c08ec329cf1be7ba61f
# Parent  88a6a193e2884ac882ecc75e9ae9a242acc6188f
Add X-REFERENCES2 to CAPABILITY string.

diff -r 88a6a193e288 -r 1f082281f8d4 configure.in
--- a/configure.in	Sun Oct 26 16:30:50 2008 +0200
+++ b/configure.in	Sun Oct 26 15:37:23 2008 -0600
@@ -2390,7 +2390,7 @@
  dnl **

  capability_banner="IMAP4rev1 LITERAL+ SASL-IR LOGIN-REFERRALS ID
ENABLE"
-capability="$capability_banner SORT THREAD=REFERENCES MULTIAPPEND  
UNSELECT IDLE CHILDREN NAMESPACE UIDPLUS LIST-EXTENDED I18NLEVEL=1  
CONDSTORE QRESYNC ESEARCH SEARCHRES WITHIN CONTEXT=SEARCH"
+capability="$capability_banner SORT THREAD=REFERENCES  
THREAD=X-REFERENCES2 MULTIAPPEND UNSELECT IDLE CHILDREN NAMESPACE  
UIDPLUS LIST-EXTENDED I18NLEVEL=1 CONDSTORE QRESYNC ESEARCH SEARCHRES  
WITHIN CONTEXT=SEARCH"
  AC_DEFINE_UNQUOTED(CAPABILITY_STRING, "$capability", IMAP
capabilities)
  AC_DEFINE_UNQUOTED(CAPABILITY_BANNER_STRING, "$capability_banner",  
IMAP capabilities advertised in banner)


michael

On Oct 26, 2008, at 11:42 PM, Michael M. Slusarz wrote:
> Don't see any reason why X-REFERENCES2 should not be advertised in  
> the CAPABILITY string - the wiki indicates this is a new addition  
> for 1.2, and RFC 5256 explicitly states that the THREAD= is to be  
> used for upwards-compatible extensions.
I was thinking about waiting for INTHREAD draft to go a bit further  
and then rename it to THREAD=REFS. The X-things aren't standard in any  
case so I don't see much point in advertising them. If you really want  
them, you know you can use them regardless of the capability. Or you  
can modify the capability from dovecot.conf.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: PGP.sig
Type: application/pgp-signature
Size: 194 bytes
Desc: This is a digitally signed message part
URL:
<http://dovecot.org/pipermail/dovecot/attachments/20081026/272d2b1a/attachment-0002.bin>