dovecot - Jul 2008 - AIX: mntctl implementation for NFS quota support

Hi Timo, Hello list,

I've played around with dovecot-1.1.1 on AIX to get quotas (especially 
NFS quotas) to work. I've found that dovecot doesn't implement handling 
of 'mntctl' and so it is unable to determine filesystem mountpoints on 
AIX correctly.

Your'll find more information about 'mntctl' here:
http://publib.boulder.ibm.com/infocenter/systems/index.jsp?topic=/com.ibm.aix.basetechref/doc/basetrf1/mntctl.htm

Okay...

I've added mntctl support to 'lib/mountpoint.c' today. My tests are 
looking good and so I'd like to share the patch.
While I'm still not really familiar with dovecots memory management, I 
need someone who is familiar with it to have a look on my lines of code. 
Especially the usage or p_new, t_strconcat and p_free should be checked. 
:-)

To activate the patch you have to add "#define HAVE_VMOUNT_H 1" do 
'config.h'. Maybe someone wants to alter configure* to do this 
automatically?

And of course Timo, if you find it useful, you may include the code in 
one of the next dovecot releases.

Regards, Ralf
-- 
______________________________________________________________________

  Dipl.-Inform. (FH) Ralf Becker     Rechenzentrum (r/ft) der FH Trier
  (Network|Mail|Web|Firewall)           University of applied sciences
  Administrator                           Schneidershof, D-54293 Trier

    Mail: beckerr at fh-trier.de                    Fon: +49 651 8103 499
     Web: http://www.fh-trier.de/~beckerr        Fax: +49 651 8103 214
  PubKey: http://www.fh-trier.de/~beckerr     Crypto: GnuPG, S/MIME
______________________________________________________________________

  Wenn Gott gewollt haette, dass E-Mail in HTML geschrieben wuerden,
  endeten Gebete traditionell mit </amen>. (Tom Listen)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: dovecot-aix-mntctl.patch.gz
Type: application/octet-stream
Size: 1087 bytes
Desc: not available
URL:
<http://dovecot.org/pipermail/dovecot/attachments/20080705/3ebce7c7/attachment-0002.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 6074 bytes
Desc: S/MIME Cryptographic Signature
URL:
<http://dovecot.org/pipermail/dovecot/attachments/20080705/3ebce7c7/attachment-0002.bin>

On Jul 5, 2008, at 10:39 PM, Ralf Becker wrote:
> I've added mntctl support to 'lib/mountpoint.c' today. My tests
are
> looking good and so I'd like to share the patch.
> While I'm still not really familiar with dovecots memory management,  
> I need someone who is familiar with it to have a look on my lines of  
> code. Especially the usage or p_new, t_strconcat and p_free should  
> be checked. :-)
I'd probably change the allocations a bit to avoid extra syscalls.  
Something like:

// guess that 256 bytes is enough usually. use larger value if it's not.
char mtab_static[256], *mtab = mtab_static;

count = mntctl(..);
while (count == 0) {
   mtab = t_malloc(size);
   count = mntctl(..);
}
if (count < 0) {
   i_error("mntctl() failed: %m");
   return -1;
}
..etc..

Also change to HAVE_SYS_VMOUNT_H.
> To activate the patch you have to add "#define HAVE_VMOUNT_H 1"
do
> 'config.h'. Maybe someone wants to alter configure* to do this  
> automatically?
Just add sys/vmount.h to AC_CHECK_HEADERS() list.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: PGP.sig
Type: application/pgp-signature
Size: 194 bytes
Desc: This is a digitally signed message part
URL:
<http://dovecot.org/pipermail/dovecot/attachments/20080706/e2389178/attachment-0002.bin>