dovecot - Jun 2008 - typo in failures.c

Hi, I found a typo on line 101 of dovecot-1.1.rc8/src/lib/failures.c.   
The first two arguments to io_add() are reversed.  The fd should be  
first, and IO_WRITE second.

On Fri, 2008-06-06 at 21:00 -0500, Mike Abbott wrote:
> Hi, I found a typo on line 101 of dovecot-1.1.rc8/src/lib/failures.c.   
> The first two arguments to io_add() are reversed.  The fd should be  
> first, and IO_WRITE second.
Thanks, fixed: http://hg.dovecot.org/dovecot-1.1/rev/7c9895192a23

I wish gcc warned about bad enum usages, it would have caught this.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
URL:
<http://dovecot.org/pipermail/dovecot/attachments/20080607/8ac102bb/attachment-0002.bin>

--On Saturday, June 07, 2008 5:11 AM +0300 Timo Sirainen <tss at iki.fi>
wrote:
> I wish gcc warned about bad enum usages, it would have caught this.
Wow, that surprised me that it lacked that, as I'm so used to it on 
Windows. But I mostly code in C++ there, so perhaps the conversion in C is 
legal?

<http://gcc.gnu.org/ml/gcc/2004-07/msg00375.html>

Except that conversion from one enum type to another looks like it should 
be illegal based on that message.