Greetings, recently I've been writing a database driver module for Dovecot to use SQLite. It's mostly for my own use, but I do recall other people have asked for this. Firstly - Timo, I grow to love your work more and more every day. :) I have not had any trouble figuring out what is needed of the driver, even without any API documentation. However, the one part of the driver that's given me pause has turned out to most likely be unnecessary. Whilst I was trying to work out how to deal with the sql_result->get_values() call without leaking memory, it seemed an odd method to have along side the other calls. So I decided to look for where it was used, to try to understand. Only, it isn't. The _only_ point I can find in the sources that calls that method is in the Postgress SQL driver. Am I missing something? -- Curtis Maloney cmaloney at cardgate.net
On 28.11.2005, at 22:47, Curtis Maloney wrote:> However, the one part of the driver that's given me pause has turned > out to most likely be unnecessary. Whilst I was trying to work out > how to deal with the sql_result->get_values() call without leaking > memory, it seemed an odd method to have along side the other calls. > > So I decided to look for where it was used, to try to understand. > > Only, it isn't. The _only_ point I can find in the sources that > calls that method is in the Postgress SQL driver.Probably I thought it was useful but never actually used it. Maybe it will be some day :) Anyway, you can already see how driver-pgsql.c handles it. The memory is freed when the next row is fetched, or when a new query is sent or the whole driver is deinitialized. -------------- next part -------------- A non-text attachment was scrubbed... Name: PGP.sig Type: application/pgp-signature Size: 186 bytes Desc: This is a digitally signed message part URL: <http://dovecot.org/pipermail/dovecot/attachments/20051202/fb63569d/attachment.bin>