Cruisecontrolrb users - May 2008 - 2 Minor issues with 1.3.0 on windows

Hi all,

Lest I forget:

    Windows XP Pro SP2

    C:\CruiseControl\cruisecontrolrb-1.3.0>ruby --version
    ruby 1.8.6 (2007-09-24 patchlevel 111) [i386-mswin32]


We found two minor problems with CC.rb when trying to run on windows.

The first effects the Dashboard saying there is no project.  In
boot.rb we had to add a .gsub(''\\'',''/'') in
#find_home when returning
the USERPROFILE.  (Unrelated to our problems, but possibly relevant to
some: at line 8 my system would not require the '':'' as it is
already
part of SYSTEMDRIVE).

Second, since our USERPROFILE starts C:\Documents and Settings\... the
we need additional quoting in CommandLine#execute around the :stdout
and :stderr options.  File.expand_path returns a string with embedded
spaces which would be choked on later.  We just wrapped those options
on lines 67 and 68 with quotation marks.

With those two changes, CC.rb is working great for us.  Thanks for
your efforts, and I hope these little notes will help other windows
users.

--
Joe Swatosh

On Mon, May 19, 2008 at 9:26 AM, Joe Swatosh <joe.swatosh at gmail.com>
wrote:
> Hi all,
>
> Lest I forget:
>
>    Windows XP Pro SP2
>
>    C:\CruiseControl\cruisecontrolrb-1.3.0>ruby --version
>    ruby 1.8.6 (2007-09-24 patchlevel 111) [i386-mswin32]
>
>
> We found two minor problems with CC.rb when trying to run on windows.
>
> The first effects the Dashboard saying there is no project.  In
> boot.rb we had to add a .gsub(''\\'',''/'')
in #find_home when returning
> the USERPROFILE.  (Unrelated to our problems, but possibly relevant to
> some: at line 8 my system would not require the '':'' as it
is already
> part of SYSTEMDRIVE).
>
> Second, since our USERPROFILE starts C:\Documents and Settings\... the
> we need additional quoting in CommandLine#execute around the :stdout
> and :stderr options.  File.expand_path returns a string with embedded
> spaces which would be choked on later.  We just wrapped those options
> on lines 67 and 68 with quotation marks.
>
Doh.  Darren pointed out to me that my paragraph above isn''t very
descriptive about exactly
which file needs modification.  The file is lib/command_line.rb.
Our lines 67 and 68 look like:

   options[:stdout] =
"\"#{File.expand_path(options[:stdout])}\"" if
options[:stdout]
   options[:stderr] =
"\"#{File.expand_path(options[:stderr])}\"" if
options[:stderr]

--
Joe

I think we fixed it on the trunk a couple of weeks ago. If you could
check and confirm that the problem is gone, it would be much
appreciated.

-- 
Alex

Hi Alex,

On Wed, Jul 9, 2008 at 10:21 PM, Alexey Verkhovsky
<alexey.verkhovsky at gmail.com> wrote:
> I think we fixed it on the trunk a couple of weeks ago. If you could
> check and confirm that the problem is gone, it would be much
> appreciated.
>
> --
> Alex
I''m sorry I don''t have time to do more than browse the
repository at
the moment, but having done that it looks like both of the issues I
raised in this thread have been fixed.

Thanks!
--
Joe Swatosh

On Sat, Jul 12, 2008 at 11:41 AM, Joe Swatosh <joe.swatosh at gmail.com>
wrote:
> I''m sorry I don''t have time to do more than browse the
repository at
> the moment, but having done that it looks like both of the issues I
> raised in this thread have been fixed.
Thank you. -- Alex