crossbow discuss - Dec 2006 - Code review for IP Instances

> 
> > - ip_ftable.h line 64 and ip_ire.c line 2877: please clarify the
> >   "no netstack_hold()" comment?  seems like the ipst is
obtained from
> >    the ill_ipst or conn_netstack->netstack_ip, or by marching down
some
> >   global netstack list, so what does the comment refer to?
> 
> It refers to the fact that we only do netstack_hold in particular cases, 
>   such as the references from open streams (ill_t and conn_t''s 
> pointers). Internally within IP we rely on IP''s ability to cleanup
e.g.
> ire_t''s when an ill goes away.
> 
> The design document (on opensolaris,org) has some added text to try to 
> explain this. Is there something better we can do in the source code?
Maybe add the above explanation in ip_ftable.h?

thanks,
--Sowmini

sowmini.varadhan at sun.com wrote:
>>> - ip_ftable.h line 64 and ip_ire.c line 2877: please clarify the
>>>   "no netstack_hold()" comment?  seems like the ipst is
obtained from
>>>    the ill_ipst or conn_netstack->netstack_ip, or by marching
down some
>>>   global netstack list, so what does the comment refer to?
>> It refers to the fact that we only do netstack_hold in particular
cases,
>>   such as the references from open streams (ill_t and conn_t''s
>> pointers). Internally within IP we rely on IP''s ability to
cleanup e.g.
>> ire_t''s when an ill goes away.
>>
>> The design document (on opensolaris,org) has some added text to try to 
>> explain this. Is there something better we can do in the source code?
> 
> Maybe add the above explanation in ip_ftable.h?
Will do. I''ll also put it in some other header files that have the same
short comment currently.

    Erik